Skip to content

Boot IRQ quirks for Broadcom and AMD/ATI

Olaf Dabrunz lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Add quirk to disable boot interrupt generation on broadcom HT1000drivers/pci/quirks.c+32 -00 replies
2/3disable AMD/ATI legacy boot interrupt generationdrivers/pci/quirks.c+50 -210 replies
3/3call boot IRQ quirks at end of device init and during resumedrivers/pci/quirks.c+24 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Boot IRQ quirks for Broadcom and AMD/ATI

This is against linux-2.6-tip, branch pci-ioapic-boot-irq-quirks.

The corrected versions of the Broadcom and AMD/ATI boot IRQ quirks, and a patch that uses DECLARE_PCI_FIXUP_FINAL instead of *_EARLY, and adds *_RESUME.

The AMD/ATI SB700S does not need a quirk. The boot IRQs here are active even when the IO-APIC lines are not masked. So even for traditional IRQ handling that does not use masking, the boot IRQs need to be disabled by the BIOS. If there are actual cases of BIOSes that do not disable these boot IRQs in APIC mode, we could consider including an SB700S patch. But I doubt this will be needed, as this problem would quickly surface during testing with any general-purpose OS.

The quirk for the AMD 8131 and AMD 8132 takes identical action as an existing quirk for the AMD 8131 rev. A0 and B0. The existing quirk is due to an AMD erratum to fix IO-APIC mode. Our patch now deletes the older quirk and adds a comment to the new one that describes the two purposes of the quirk.