Skip to content

radio-mr800: fix unplug

Alexey Klimov linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 3 repliesIn review

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] radio-mr800: fix unplug

Hello, all

This patch fix such thing. When you listening the radio with you user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you unplug the device from usb port and then close application or change frequency of the radio - a lot of oopses appear in dmesg. I also had big problems with stability of kernel(different memory leaks, lockings) in ~30% of cases when using mplayer trying to reproduce this bug.

This thing happens with dsbr100 radio and radio-mr800. I told about this thing to Douglas Schilling Landgraf and then he suggested right decision for dsbr100. He told me that he get ideas of preventing this bug from Tobias radio-si470x driver. Hopefully this bug didn't show up in radio-si470x. Well, i used Douglas suggestion and code of si470x and made this patch.

Douglas said that he's going to create patch for dsbr100.

Patch places a lof of safety checks in functions, adds disconnect_lock mutex and changes disconnect and release functions of module. May be it's good to add it to 2.6.28 because it fixes an issue.
I tested this thing under 2.6.28-rc5.

Signature · 7 lines
Best regards, Klimov Alexey


--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list