radio-mr800: fix unplug
cover radio-mr800: fix unplug
Hello, all
This patch fix such thing. When you listening the radio with you user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you unplug the device from usb port and then close application or change frequency of the radio - a lot of oopses appear in dmesg. I also had big problems with stability of kernel(different memory leaks, lockings) in ~30% of cases when using mplayer trying to reproduce this bug.
This thing happens with dsbr100 radio and radio-mr800. I told about this thing to Douglas Schilling Landgraf and then he suggested right decision for dsbr100. He told me that he get ideas of preventing this bug from Tobias radio-si470x driver. Hopefully this bug didn't show up in radio-si470x. Well, i used Douglas suggestion and code of si470x and made this patch.
Douglas said that he's going to create patch for dsbr100.
Patch places a lof of safety checks in functions, adds disconnect_lock mutex and changes disconnect and release functions of module. May be it's good to add it to 2.6.28 because it fixes an issue.
I tested this thing under 2.6.28-rc5.
Signature · 7 lines
Best regards, Klimov Alexey -- video4linux-list mailing list Unsubscribe mailto:[email protected]?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list
Hello Alexey,
Quoted 10 lines · On Wed, 19 Nov 2008 03:35:55 +0300 Alexey Klimov <[email protected]> wrote:
Hello, all
This patch fix such thing. When you listening the radio with you user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you unplug the device from usb port and then close application or change frequency of the radio - a lot of oopses appear in dmesg. I also had big problems with stability of
kernel(different memory leaks, lockings)in ~30% of cases when using mplayer trying to reproduce this bug.
Quoted 8 lines
This thing happens with dsbr100 radio and radio-mr800. I told about this thing to Douglas Schilling Landgraf and then he suggested right decision for dsbr100. He told me that he get ideas of preventing this bug from Tobias radio-si470x driver. Hopefully this bug didn't show up in radio-si470x. Well, i used Douglas suggestion and code of si470x and made this patch.
Douglas said that he's going to create patch for dsbr100.
humm, since you already fixed radio-mr800 and I'm working with other developers to improve em28xx... Are you interested to make a patch to fix dsbr100?
Cheers,
Douglas
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Hello, Douglas
Quoted 22 lines · Douglas Schilling Landgraf
Hello Alexey,
Quoted 17 lines · On Wed, 19 Nov 2008 03:35:55 +0300 Alexey Klimov <[email protected]> wrote:
Hello, all
This patch fix such thing. When you listening the radio with you user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you unplug the device from usb port and then close application or change frequency of the radio - a lot of oopses appear in dmesg. I also had big problems with stability of
kernel(different memory leaks, lockings)in ~30% of cases when using mplayer trying to reproduce this bug.This thing happens with dsbr100 radio and radio-mr800. I told about this thing to Douglas Schilling Landgraf and then he suggested right decision for dsbr100. He told me that he get ideas of preventing this bug from Tobias radio-si470x driver. Hopefully this bug didn't show up in radio-si470x. Well, i used Douglas suggestion and code of si470x and made this patch.
Quoted 9 lines
Quoted 1 line
Douglas said that he's going to create patch for dsbr100.
humm, since you already fixed radio-mr800 and I'm working with other developers to improve em28xx... Are you interested to make a patch to fix dsbr100?
Cheers,
Douglas
Well, if you okay with that and if this patch (for mr800) is right - i can make patch for dsbr100. Currently, i don't have access to this device for a few days. So, if i don't post this patch to this list in a week - please contact with me.
Signature · 6 lines
Best regards, Klimov Alexey -- video4linux-list mailing list Unsubscribe mailto:[email protected]?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list
Hello,
Quoted 32 lines · On Thu, 20 Nov 2008 10:42:40 +0300 "Alexey Klimov" <[email protected]>…
Hello, Douglas
Quoted 28 lines · Douglas Schilling Landgraf
Hello Alexey,
Quoted 10 lines · On Wed, 19 Nov 2008 03:35:55 +0300 Alexey Klimov <[email protected]> wrote:
Hello, all
This patch fix such thing. When you listening the radio with you user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you unplug the device from usb port and then close application or change frequency of the radio - a lot of oopses appear in dmesg. I also had big problems with stability of
kernel(different memory leaks, lockings)in ~30% of cases when using mplayer trying to reproduce this bug.Quoted 8 lines
This thing happens with dsbr100 radio and radio-mr800. I told about this thing to Douglas Schilling Landgraf and then he suggested right decision for dsbr100. He told me that he get ideas of preventing this bug from Tobias radio-si470x driver. Hopefully this bug didn't show up in radio-si470x. Well, i used Douglas suggestion and code of si470x and made this patch.
Douglas said that he's going to create patch for dsbr100.
humm, since you already fixed radio-mr800 and I'm working with other developers to improve em28xx... Are you interested to make a patch to fix dsbr100?
Quoted 6 lines
Quoted 3 lines
Cheers,
DouglasWell, if you okay with that and if this patch (for mr800) is right - i can make patch for dsbr100.
Seems ok.
Quoted 3 lines
Currently, i don't have access to this
device for a few days. So, if i don't post this patch to this list in a week - please contact with me.
Ok.
Cheers,
Douglas
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list