Skip to content

powerpc/book3e: powerpc/book3e: make kgdb to work well

Tiejun Chen linuxppc-dev lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 5 repliesIn review
  2. v56 patches 12 repliesSuperseded
  3. v47 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/26 patches0 repliesSuperseded
v3 posting 1/26 patches1 replySuperseded
v26 patches0 repliesSuperseded
v16 patches2 repliesSuperseded

Changes in v6 from the cover letter

* rebase
* change the C code to initialize the exception stack addresses in the PACA instead.
* Clear the PACA_IRQ_HARD_DIS force to exit directly from this debug exception without replaying interrupt.
* so drop "book3e/kgdb: update thread's dbcr0".

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5powerpc/book3e: initialize crit/mc/dbg kernel stack pointersarch/powerpc/kernel/setup_64.c+12 -60 replies
2/5powerpc/book3e: store crit/mc/dbg exception thread infoarch/powerpc/kernel/exceptions-64e.S+19 -32 replies
3/5powerpc/book3e: support kgdb for kernel spacearch/powerpc/kernel/exceptions-64e.S+3 -11 reply
4/5powerpc/kgdb: use DEFINE_PER_CPU to allocate kgdb's thread_infoarch/powerpc/kernel/kgdb.c+2 -30 replies
5/5powerpc/book3e/kgdb: Fix a single stgep case of lazy IRQarch/powerpc/kernel/kgdb.c+8 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [v6][PATCH 0/5] powerpc/book3e: powerpc/book3e: make kgdb to work well

Scott,

Tested on fsl-p5040 DS.

v6:

* rebase
* change the C code to initialize the exception stack addresses in the PACA instead.
* Clear the PACA_IRQ_HARD_DIS force to exit directly from this debug exception without replaying interrupt.
* so drop "book3e/kgdb: update thread's dbcr0".

v5:

* rebase on merge branch.

Note the original patch, [ATCH 5/7] kgdb/kgdbts: support ppc64, is already merged by Jason.

v4:

* use DEFINE_PER_CPU to allocate kgdb's thread_info
* add patch 7 to make usre copy thread_info only !__check_irq_replay
* leave "andi. r14,r11,MSR_PR" out of "#ifndef CONFIG_KGDB"
since cr0 is still used lately.
* retest

v3:

* make work when enable CONFIG_RELOCATABLE
* fix one typo in patch,
"powerpc/book3e: store critical/machine/debug exception thread info":

	ld	r1,PACAKSAVE(r13);
    ->  ld	r14,PACAKSAVE(r13);

* remove copying the thread_info since booke and book3e always copy the thead_info now when we enter the debug exception, and so drop the v2 patch, "book3e/kgdb: Fix a single stgep case of lazy IRQ"

v2:

* Make sure we cover CONFIG_PPC_BOOK3E_64 safely
* Use LOAD_REG_IMMEDIATE() to load properly
the value of the constant expression in load debug exception stack
* Copy thread infor form the kernel stack coming from usr
* Rebase latest powerpc git tree

v1:

* Copy thread info only when we are from !user mode since we'll get kernel stack coming from usr directly.
* remove save/restore EX_R14/EX_R15 since DBG_EXCEPTION_PROLOG already covered this.
* use CURRENT_THREAD_INFO() conveniently to get thread.
* fix some typos
* add a patch to make sure gdb can generate a single step properly to invoke a kgdb state.
* add a patch to if we need to replay an interrupt, we shouldn't restore that previous backup thread info to make sure we can replay an interrupt lately with a proper thread info.
* rebase latest powerpc git tree

v0:

This patchset is used to support kgdb for book3e.

----------------------------------------------------------------
Tiejun Chen (5):
powerpc/book3e: initialize crit/mc/dbg kernel stack pointers powerpc/book3e: store crit/mc/dbg exception thread info powerpc/book3e: support kgdb for kernel space powerpc/kgdb: use DEFINE_PER_CPU to allocate kgdb's thread_info powerpc/book3e/kgdb: Fix a single stgep case of lazy IRQ

 arch/powerpc/kernel/exceptions-64e.S |   26 ++++++++++++++++++++++----
 arch/powerpc/kernel/kgdb.c           |   13 ++++++++++---
 arch/powerpc/kernel/setup_64.c       |   18 ++++++++++++------
 3 files changed, 44 insertions(+), 13 deletions(-)

Tiejun