Skip to content

Broadwell HW semaphore

Ben Widawsky intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 13 repliesIn review
  2. v117 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15drm/i915: Reorder/respace MI instruction definitiondrivers/gpu/drm/i915/i915_reg.h+26 -261 reply
2/15drm/i915: Don't emit mbox updates without semaphoresdrivers/gpu/drm/i915/intel_ringbuffer.c+6 -53 replies
3/15drm/i915: Move semaphore specific ring members to structdrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gpu_error.c drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+60 -570 replies
4/15drm/i915: Virtualize the ringbuffer signal funcdrivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+27 -150 replies
5/15drm/i915: Move ring_begin to signal()drivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+25 -180 replies
6/15drm/i915: Make semaphore updates more precisedrivers/gpu/drm/i915/intel_ringbuffer.c+22 -211 reply
7/15drm/i915: gen specific ring initdrivers/gpu/drm/i915/intel_ringbuffer.c+92 -421 reply
8/15drm/i915/bdw: implement semaphore signaldrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+197 -462 replies
9/15drm/i915/bdw: implement semaphore waitdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+62 -372 replies
10/15drm/i915: FORCE_RESTORE for gen8 semaphoresdrivers/gpu/drm/i915/i915_gem_context.c+9 -00 replies
11/15drm/i915/bdw: poll semaphoresdrivers/gpu/drm/i915/intel_ringbuffer.c+1 -01 reply
12/15drm/i915: Extract semaphore error collectiondrivers/gpu/drm/i915/i915_gpu_error.c+19 -122 replies
13/15drm/i915/bdw: collect semaphore error statedrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gpu_error.c drivers/gpu/drm/i915/intel_ringbuffer.h+50 -90 replies
14/15drm/i915: unleash semaphores on gen8drivers/gpu/drm/i915/i915_drv.c+0 -60 replies
15/15drm/i915: semaphore debugfsdrivers/gpu/drm/i915/i915_debugfs.c+69 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 00/15] [v2] Broadwell HW semaphore

Reposting this as a new series since two of the patches dropped off since last time.

Functionally it's the same as before. Like before, the patch "drm/i915:
unleash semaphores on gen8" should probably not be merged as it's not 100% clear where the hang is currently coming from. Everything else should be pretty benign for other platforms.

Ben Widawsky (15):
drm/i915: Reorder/respace MI instruction definition drm/i915: Don't emit mbox updates without semaphores drm/i915: Move semaphore specific ring members to struct drm/i915: Virtualize the ringbuffer signal func drm/i915: Move ring_begin to signal()
drm/i915: Make semaphore updates more precise drm/i915: gen specific ring init
drm/i915/bdw: implement semaphore signal drm/i915/bdw: implement semaphore wait drm/i915: FORCE_RESTORE for gen8 semaphores drm/i915/bdw: poll semaphores
drm/i915: Extract semaphore error collection drm/i915/bdw: collect semaphore error state drm/i915: unleash semaphores on gen8
drm/i915: semaphore debugfs

 drivers/gpu/drm/i915/i915_debugfs.c     |  69 +++++++
 drivers/gpu/drm/i915/i915_drv.c         |   6 -
 drivers/gpu/drm/i915/i915_drv.h         |   2 +
 drivers/gpu/drm/i915/i915_gem.c         |  10 +-
 drivers/gpu/drm/i915/i915_gem_context.c |   9 +
 drivers/gpu/drm/i915/i915_gpu_error.c   |  75 ++++++--
 drivers/gpu/drm/i915/i915_reg.h         |  58 +++---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 329 ++++++++++++++++++++++++--------
 drivers/gpu/drm/i915/intel_ringbuffer.h |  87 ++++++++-
 9 files changed, 508 insertions(+), 137 deletions(-)
Signature · 1 line
1.8.5.1