Skip to content

mtd: spi-nor: misc. updates, de-duplication

Brian Norris linux-mtd 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 5 repliesIn review
  2. v210 patches 5 repliesSuperseded
  3. v19 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- move the fsl-quadspi.c rename of

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11mtd: spi-nor: drop \t after #defineinclude/linux/mtd/spi-nor.h+36 -360 replies
2/11mtd: spi-nor: re-name OPCODE_* to SPINOR_OP_*drivers/mtd/devices/m25p80.c drivers/mtd/spi-nor/fsl-quadspi.c drivers/mtd/spi-nor/spi-nor.c +1 more+90 -900 replies
3/11mtd: spi-nor: unify read opcode variants with ST SPI FSMdrivers/mtd/spi-nor/fsl-quadspi.c drivers/mtd/spi-nor/spi-nor.c include/linux/mtd/spi-nor.h+27 -190 replies
4/11Documentation: spi-nor: rewrite some portionsDocumentation/mtd/spi-nor.txt+20 -170 replies
5/11mtd: spi-nor: shorten Kconfig namingdrivers/mtd/Makefile drivers/mtd/devices/Kconfig drivers/mtd/spi-nor/Kconfig +1 more+11 -60 replies
6/11mtd: st_spi_fsm: fixup Kconfig dependencydrivers/mtd/devices/Kconfig+1 -10 replies
7/11mtd: st_spi_fsm: kill duplicate CMD definitionsdrivers/mtd/devices/st_spi_fsm.c+0 -360 replies
8/11mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_*drivers/mtd/devices/serial_flash_cmds.h drivers/mtd/devices/st_spi_fsm.c+87 -870 replies
9/11mtd: st_spi_fsm: begin using spi-nor.h opcodesdrivers/mtd/devices/serial_flash_cmds.h drivers/mtd/devices/st_spi_fsm.c+5 -240 replies
10/11mtd: spi-nor: allow to be built as moduledrivers/mtd/spi-nor/Kconfig+2 -20 replies
11/11mtd: fsl-quadspi: fix __iomem annotations, accessorsdrivers/mtd/spi-nor/fsl-quadspi.c+3 -33 replies

Reviews trailers per patch

10 of 11 patches have a Reviewed-by or Acked-by.

PatchMarek VasutHuang ShijieLee Jones
1/11R-b A-b
2/11R-b A-b
3/11R-b A-b
4/11R-b
5/11R-b A-b
6/11R-b A-b
7/11R-b A-b
8/11R-b A-b
9/11R-b A-b
10/11R-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/11] mtd: spi-nor: misc. updates, de-duplication

A few miscellaneous updates, cleanups, and de-duplications. Mostly trivial stuff, but I had a few oversights in the first round...and in the second round too :(

v3:
- move the fsl-quadspi.c rename of

     SPINOR_OP_QUAD_READ => SPINOR_OP_READ_1_1_4

from patch 8 to patch 3, so that the series bisects properly
- add new patch 11, caught while testing with sparse

v2:
- opcode renames to fsl-quadspi.c (missed a few; I compiled it this time!)
- additional whitespace consistency cleanups
- tweak documentation wording/formatting
- additonal patch (patch 10), to allow building spi-nor as a module

Brian Norris (11):
mtd: spi-nor: drop \t after #define
mtd: spi-nor: re-name OPCODE_* to SPINOR_OP_*
mtd: spi-nor: unify read opcode variants with ST SPI FSM
Documentation: spi-nor: rewrite some portions
mtd: spi-nor: shorten Kconfig naming
mtd: st_spi_fsm: fixup Kconfig dependency
mtd: st_spi_fsm: kill duplicate CMD definitions
mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_*
mtd: st_spi_fsm: begin using spi-nor.h opcodes
mtd: spi-nor: allow to be built as module
mtd: fsl-quadspi: fix __iomem annotations, accessors

 Documentation/mtd/spi-nor.txt           |  37 ++++----
 drivers/mtd/Makefile                    |   2 +-
 drivers/mtd/devices/Kconfig             |   4 +-
 drivers/mtd/devices/m25p80.c            |   4 +-
 drivers/mtd/devices/serial_flash_cmds.h |  44 +++-------
 drivers/mtd/devices/st_spi_fsm.c        | 149 ++++++++++++--------------------
 drivers/mtd/spi-nor/Kconfig             |  11 ++-
 drivers/mtd/spi-nor/Makefile            |   2 +-
 drivers/mtd/spi-nor/fsl-quadspi.c       |  64 +++++++-------
 drivers/mtd/spi-nor/spi-nor.c           |  64 +++++++-------
 include/linux/mtd/spi-nor.h             |  80 +++++++++--------
 11 files changed, 211 insertions(+), 250 deletions(-)
Signature · 1 line
1.8.3.2