Skip to content

add resize callback to ide/core

John Snow qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyApplied
  2. v31 patch 7 repliesSuperseded
  3. v21 patch 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch4 repliesApplied

Changes in v4 from the cover letter

- Added patch that makes the buffer and cache fill order for identify routines more consistent.
- Fixed a bug where the very first call to IDENTIFY does not return any size information.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2IDE: Fill the IDENTIFY request consistentlyhw/ide/core.c+15 -130 replies
2/2ide: Add resize callback to ide/corehw/ide/core.c+59 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/2] add resize callback to ide/core

This patch series fixes incorrect IDENTIFY data returned for an IDE drive after a block_resize event by adding a resize callback for IDE devices.

Inconsistencies between identify routines are also removed so that they read easier.

V4:
- Added patch that makes the buffer and cache fill order for identify routines more consistent.
- Fixed a bug where the very first call to IDENTIFY does not return any size information.

V3:
- Factored out the size update into new functions.
- Fixed the size update for CFATA.
- Added assertion to clarify that ide_resize_cb is non-atapi.

V2:
- Do not attempt to update geometry values, to avoid clobbering user-specified values, if they exist.
- Do not regenerate the entire IDENTIFY buffer to avoid losing any settings that occurred during normal operation.

John Snow (2):
IDE: Fill the IDENTIFY request consistently
ide: Add resize callback to ide/core

 hw/ide/core.c | 97 +++++++++++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 74 insertions(+), 23 deletions(-)
Signature · 1 line
1.9.3