Skip to content

ivshmem security fixes

Andreas Färber qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 5 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ivshmem: Check ivshmem_read() size argumenthw/misc/ivshmem.c+28 -21 reply
2/4ivshmem: validate incoming_posn value from serverhw/misc/ivshmem.c+8 -01 reply
3/4ivshmem: Fix potential OOB r/w accesshw/misc/ivshmem.c+23 -41 reply
4/4ivshmem: Fix fd leak on errorhw/misc/ivshmem.c+1 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMichael S. Tsirkin
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] ivshmem security fixes

Hello,

This series tightens security on incoming data for ivshmem, originally sparked by SUSE's security team (Sebastian Krahmer). I've combined them and tackled remaining review feedback.

Regards,
Andreas

Changes from Sebastian's #2:
* Rebased onto Stefan's patches
* Dropped g_realloc() check (Stefan)
* Fixed fd leak and appended a patch fixing another one (Stefan)
* Simplified comment (Stefan)

Changes from Stefan's series:
* Modified to handle partial reads (Peter/Gerd)
* Changed check from > to >= (Peter)

Cc Cam Macdonell <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Cc Michael S. Tsirkin <[email protected]>
Cc Sebastian Krahmer <[email protected]>
Cc Peter Maydell <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc David Marchand <[email protected]>

Andreas Färber (1):
ivshmem: Fix fd leak on error

Sebastian Krahmer (1):
ivshmem: Fix potential OOB r/w access

Stefan Hajnoczi (2):
ivshmem: Check ivshmem_read() size argument
ivshmem: validate incoming_posn value from server

 hw/misc/ivshmem.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 60 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.4.5