blk-mq: fix race conditions on cpu hotplug handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 17 repliesIn review
- v37 patches 9 repliesSuperseded
- v26 patches 10 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 16 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | blk-mq: avoid setting hctx->tags->cpumask before allocationblock/ | +8 | 1 reply | |
| 2/7 | blk-mq: fix sysfs registration/unregistration raceblock/ block/ include/ +1 more | +27 | 1 reply | |
| 3/7 | blk-mq: Fix use after of free q->mq_mapblock/ | +3 | 3 replies | |
| 4/7 | blk-mq: fix q->mq_usage_counter access raceblock/ | +4 | 1 reply | |
| 5/7 | blk-mq: avoid inserting requests before establishing new mappingblock/ block/ block/ | +52 | 1 reply | |
| 6/7 | blk-mq: fix freeze queue raceblock/ block/ block/ +1 more | +17 | 8 replies | |
| 7/7 | blk-mq: fix deadlock when reading cpu_listblock/ block/ | +7 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Ming Lei | Tejun Heo | Christoph Hellwig |
|---|---|---|---|
| 1/7 | R-b | ||
| 2/7 | R-b | R-b | |
| 3/7 | R-b | R-b | |
| 4/7 | R-b | R-b | |
| 5/7 | R-b | R-b | |
| 6/7 | R-b | A-b | |
| 7/7 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/7] blk-mq: fix race conditions on cpu hotplug handling
This patchset addresses several race conditions on cpu hotplug handling for blk-mq. All problems can be reproducible by the following script.
while true; do
echo 0 > /sys/devices/system/cpu/cpu1/online echo 1 > /sys/devices/system/cpu/cpu1/online
done &
while true; do
modprobe -r null_blk
modprobe null_blk queue_mode=2 irqmode=1
sleep 0.1
done
* Changes from v3
- Rebased to the latest kernel
- Add Reviewed-by tags
* Changes from v2
- Add regression fix for hctx->tags->cpumask
- Remove BLK_MQ_F_SYSFS_UP per-hctx flag and use mq_sysfs_init_done per-queue flag instead with appropriate locking in order to keep track of 'mq' sysfs entry's life
- Add comments on non-trivial stuffs, suggested by Ming
* Changes from v1
- Release q->mq_map in blk_mq_release()
- Fix deadlock when reading cpu_list
- Fix race freeze and unfreeze
Akinobu Mita (7):
blk-mq: avoid setting hctx->tags->cpumask before allocation
blk-mq: fix sysfs registration/unregistration race
blk-mq: Fix use after of free q->mq_map
blk-mq: fix q->mq_usage_counter access race
blk-mq: avoid inserting requests before establishing new mapping
blk-mq: fix freeze queue race
blk-mq: fix deadlock when reading cpu_list
block/blk-core.c | 1 + block/blk-mq-cpumap.c | 9 +++-- block/blk-mq-sysfs.c | 36 ++++++++++++------ block/blk-mq.c | 100 +++++++++++++++++++++++++++++++++++++------------ block/blk-mq.h | 3 +- include/linux/blk-mq.h | 1 - include/linux/blkdev.h | 8 ++++ 7 files changed, 116 insertions(+), 42 deletions(-)
Signature · 1 line
1.9.1