Skip to content

phy: use syscon framework APIs to set ctrl mod reg

Kishon Vijay Abraham I linux-devicetree lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 1 replyIn review
  2. v39 patches 12 repliesSuperseded
  3. v29 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches12 repliesSuperseded

Changes in v4 from the cover letter

*) Added description of why syscon is better in cover letter *) refactored some driver code so that it's easy to remove obsolete
code when phy-omap-control driver is removed.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9phy: ti-pipe3: introduce local struct device* in probedrivers/phy/phy-ti-pipe3.c+27 -270 replies
2/9phy: ti-pipe3: move clk initialization to a separate functiondrivers/phy/phy-ti-pipe3.c+72 -550 replies
3/9phy: ti-pipe3: move sysctrl initialization to a separate functiondrivers/phy/phy-ti-pipe3.c+45 -330 replies
4/9phy: ti-pipe3: move mem resource initialization to a separate functiondrivers/phy/phy-ti-pipe3.c+33 -190 replies
5/9phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probedrivers/phy/phy-ti-pipe3.c+3 -20 replies
6/9phy: ti-pipe3: use *syscon* framework API to power on/off the PHYDocumentation/devicetree/bindings/phy/ti-phy.txt drivers/phy/phy-ti-pipe3.c+81 -170 replies
7/9phy: ti-pipe3: use *syscon* framework API to set PCS value of the PHYDocumentation/devicetree/bindings/phy/ti-phy.txt drivers/phy/phy-ti-pipe3.c+34 -20 replies
8/9phy: omap-usb2: use omap_usb_power_off to power off the PHY during probedrivers/phy/phy-omap-usb2.c+1 -10 replies
9/9phy: omap-usb2: use *syscon* framework API to power on/off the PHYDocumentation/devicetree/bindings/phy/ti-phy.txt drivers/phy/phy-omap-usb2.c include/linux/phy/omap_usb.h+105 -181 reply

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchRoger QuadrosRob Herring
1/9
2/9
3/9
4/9
5/9A-b
6/9A-b
7/9A-b A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] phy: use syscon framework APIs to set ctrl mod reg

phy-omap-control driver was added when there was no proper infrastructure for doing control module initializations. The phy-omap-control driver is not an 'actual' PHY driver and it was just a hack to do PHY related control module initializations. phy-omap-control is also getting unmanageable with the number of platforms each having number of modules (like USB, SATA, PCIe), using the same driver for control module initializations.

Now with SYSCON framework being added to the kernel, phy-omap-control shouldn't be needed and it also provides a uniform API across all the modules to program the control module.

This series is basically to deprecate using phy-omap-control and use syscon APIs to program the control module registers.

Changes from v3:
*) Added description of why syscon is better in cover letter *) refactored some driver code so that it's easy to remove obsolete
code when phy-omap-control driver is removed.

Changes from v2:
No changes.

Changes from v1:
*) cleanup ti_pipe3_probe in multiple steps
*) other minor cleanups

Changes from [1] in PHY patches include
*) cleanup ti_pipe3_probe
*) have mask, power_on and power_off values in usb_phy_data for
omap-usb2 phy

The patches have been pushed to
git://git.ti.com/linux-phy/linux-phy.git syscon_v4

[1] -> https://lkml.org/lkml/2015/6/23/189

All the testing was done both before applying the dt patches and after applying the dt patches.

Kishon Vijay Abraham I (9):
phy: ti-pipe3: introduce local struct device* in probe
phy: ti-pipe3: move clk initialization to a separate function
phy: ti-pipe3: move sysctrl initialization to a separate function
phy: ti-pipe3: move mem resource initialization to a separate
function
phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during
probe
phy: ti-pipe3: use *syscon* framework API to power on/off the PHY
phy: ti-pipe3: use *syscon* framework API to set PCS value of the PHY
phy: omap-usb2: use omap_usb_power_off to power off the PHY during
probe
phy: omap-usb2: use *syscon* framework API to power on/off the PHY

 Documentation/devicetree/bindings/phy/ti-phy.txt |   20 +-
 drivers/phy/phy-omap-usb2.c                      |   94 +++++--
 drivers/phy/phy-ti-pipe3.c                       |  302 ++++++++++++++++------
 include/linux/phy/omap_usb.h                     |   23 ++
 4 files changed, 333 insertions(+), 106 deletions(-)
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html