Skip to content

RFC media: platform: add NVIDIA Tegra VI driver

Bryan Wu linux-media linux-tegra 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest3 patches 1 replyIn review
  2. v3 RFC posting 2/23 patches 0 repliesSuperseded
  3. v3 RFC posting 1/23 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC3 patches2 repliesSuperseded
v1 RFC2 patches12 repliesSuperseded

Changes in v5 from the cover letter

- Introduce 2 kthreads for capture
Use one kthread to start capture a frame and wait for next frame start. Before waiting, it will move the current buffer to another queue which will be handled by the second kthread.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3v4l: tegra: Add NVIDIA Tegra VI driverdrivers/media/platform/Kconfig drivers/media/platform/Makefile drivers/media/platform/tegra/Kconfig +7 more+2786 -01 reply
2/3ARM64: add tegra-vi support in T210 device-treearch/arm64/boot/dts/nvidia/tegra210-p2571.dts arch/arm64/boot/dts/nvidia/tegra210.dtsi+181 -10 replies
3/3Documentation: DT bindings: add VI and CSI bindingsDocumentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt+205 -60 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchHans Verkuil
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH 0/3 RFC v5] media: platform: add NVIDIA Tegra VI driver

This patchset add and enable V4L2 driver for latest NVIDIA Tegra Video Input hardware controller.

It's based on the staging/work branch of Thierry Reding Tegra upstream kernel github repo, which is based on 4.3.0-next-20151106.
(https://github.com/thierryreding/linux/tree/staging/work)

v5:
- Introduce 2 kthreads for capture
Use one kthread to start capture a frame and wait for next frame start. Before waiting, it will move the current buffer to another queue which will be handled by the second kthread.

The second kthread (capture_done) will wait for memory output done sync point event and hand over the buffer to videobuffer2 framework as capture done.

- Fix building issue after upstream V4L2 API changed

- Fix one potential race condition
Increase syncpoint max value before arming syncshot capture

- Remove freezer in kthread since it's problematic according latest discussion in 2015 Kernel Summit
- Verify with a real sensor module (OV5693)

v4:
- fix all the coding style issues
- solve all the minor problems pointed out by Hans Verkuil

v3:
- rework on the locking code related to kthread
- remove some dead code
- other fixes

v2:
- allocate kthread for each channel instead of workqueue
- create tegra-csi as a separated V4L2 subdevice
- define all the register bits needed in this driver
- add device tree binding document
- update things according to Hans and Thierry's review.

Bryan Wu (3):
[media] v4l: tegra: Add NVIDIA Tegra VI driver
ARM64: add tegra-vi support in T210 device-tree
Documentation: DT bindings: add VI and CSI bindings

 .../display/tegra/nvidia,tegra20-host1x.txt        | 211 ++++-
 arch/arm64/boot/dts/nvidia/tegra210-p2571.dts      |   8 +
 arch/arm64/boot/dts/nvidia/tegra210.dtsi           | 174 ++++-
 drivers/media/platform/Kconfig                     |   1 +
 drivers/media/platform/Makefile                    |   2 +
 drivers/media/platform/tegra/Kconfig               |  10 +
 drivers/media/platform/tegra/Makefile              |   3 +
 drivers/media/platform/tegra/tegra-channel.c       | 849 +++++++++++++++++++++
 drivers/media/platform/tegra/tegra-core.c          | 254 ++++++
 drivers/media/platform/tegra/tegra-core.h          | 162 ++++
 drivers/media/platform/tegra/tegra-csi.c           | 560 ++++++++++++++
 drivers/media/platform/tegra/tegra-vi.c            | 732 ++++++++++++++++++
 drivers/media/platform/tegra/tegra-vi.h            | 213 ++++++
 13 files changed, 3172 insertions(+), 7 deletions(-)
 create mode 100644 drivers/media/platform/tegra/Kconfig
 create mode 100644 drivers/media/platform/tegra/Makefile
 create mode 100644 drivers/media/platform/tegra/tegra-channel.c
 create mode 100644 drivers/media/platform/tegra/tegra-core.c
 create mode 100644 drivers/media/platform/tegra/tegra-core.h
 create mode 100644 drivers/media/platform/tegra/tegra-csi.c
 create mode 100644 drivers/media/platform/tegra/tegra-vi.c
 create mode 100644 drivers/media/platform/tegra/tegra-vi.h
Signature · 1 line
2.1.4