Skip to content

qcow2: reopen: Change driver-specific runtime options

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 5 repliesIn review
  2. v213 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- Removed tests that depend on memory size of test machine [Max]
- Rebased, resolved conflicts with Berto's cache cleaning timer series

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13block: Allow specifying driver-specific options to reopenblock.c block/commit.c include/block/block.h+44 -60 replies
2/13qemu-io: Remove duplicate 'open' error messageqemu-io.c+0 -10 replies
3/13qemu-io: Add command 'reopen'qemu-io-cmds.c+90 -00 replies
4/13qcow2: Improve error messageblock/qcow2.c+1 -10 replies
5/13qcow2: Factor out qcow2_update_options()block/qcow2.c+76 -590 replies
6/13qcow2: Move qcow2_update_options() call upblock/qcow2.c+9 -90 replies
7/13qcow2: Move rest of option handling to qcow2_update_options()block/qcow2.c+68 -661 reply
8/13qcow2: Leave s unchanged on qcow2_update_options() failureblock/qcow2.c+35 -221 reply
9/13qcow2: Fix memory leak in qcow2_update_options() error pathblock/qcow2.c+10 -20 replies
10/13qcow2: Make qcow2_update_options() suitable for transactionsblock/qcow2.c+73 -401 reply
11/13qcow2: Support updating driver-specific options in reopenblock/qcow2.c+72 -91 reply
12/13qemu-iotests: Reopen qcow2 with lazy-refcounts changetests/qemu-iotests/039 tests/qemu-iotests/039.out+45 -00 replies
13/13qemu-iotests: More qcow2 reopen teststests/qemu-iotests/137 tests/qemu-iotests/137.out tests/qemu-iotests/group+188 -01 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchMax ReitzEric Blake
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b R-b
6/13R-b R-b
7/13R-b
8/13R-b
9/13R-b R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/13] qcow2: reopen: Change driver-specific runtime options

This is part two of what I had sent earlier as "[PATCH 00/34] block:
Cache mode for children, reopen overhaul and more". Most of the patches were actually already reviewed in v1.

v3:
- Removed tests that depend on memory size of test machine [Max]
- Rebased, resolved conflicts with Berto's cache cleaning timer series

v2:
Apart from a few addressed review comments, there are no functional changes compared to v1. Some rebasing was necessary; also the qemu-iotests cases are new.

Kevin Wolf (13):
block: Allow specifying driver-specific options to reopen
qemu-io: Remove duplicate 'open' error message
qemu-io: Add command 'reopen'
qcow2: Improve error message
qcow2: Factor out qcow2_update_options()
qcow2: Move qcow2_update_options() call up
qcow2: Move rest of option handling to qcow2_update_options()
qcow2: Leave s unchanged on qcow2_update_options() failure
qcow2: Fix memory leak in qcow2_update_options() error path
qcow2: Make qcow2_update_options() suitable for transactions
qcow2: Support updating driver-specific options in reopen
qemu-iotests: Reopen qcow2 with lazy-refcounts change
qemu-iotests: More qcow2 reopen tests

 block.c                    |  42 ++++-
 block/commit.c             |   4 +-
 block/qcow2.c              | 390 ++++++++++++++++++++++++++++++---------------
 include/block/block.h      |   4 +-
 qemu-io-cmds.c             |  90 +++++++++++
 qemu-io.c                  |   1 -
 tests/qemu-iotests/039     |  27 ++++
 tests/qemu-iotests/039.out |  18 +++
 tests/qemu-iotests/137     | 145 +++++++++++++++++
 tests/qemu-iotests/137.out |  42 +++++
 tests/qemu-iotests/group   |   1 +
 11 files changed, 630 insertions(+), 134 deletions(-)
 create mode 100755 tests/qemu-iotests/137
 create mode 100644 tests/qemu-iotests/137.out
Signature · 1 line
1.8.3.1