Error reporting cleanups and fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest24 patches 6 repliesIn review
- v223 patches 42 repliesSuperseded
- v14 patches 16 repliesSuperseded
Changes in v3 from the cover letter
* PATCH 01+11: Commit messages improved, bad Coccinelle like breaks cleaned up [Eric]
* PATCH 02-04+09+12-14+17: Commit messages improved [Eric]
* PATCH 05: Cover a bit more ground in comments [Eric]
* PATCH 16+21: Fix three more instances [Eric]
* PATCH 18: Style fix [Fam]
* PATCH 24: New
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | qemu-nbd: Replace BSDism <err.h> by error_report()qemu-nbd.c | +77 | 0 replies | |
| 2/24 | error: Use error_report_err() where appropriate (again)block/ hw/ hw/ +5 more | +9 | 0 replies | |
| 3/24 | error: Use error_report_err() instead of monitor_printf()hmp.c hw/ migration/ +1 more | +13 | 0 replies | |
| 4/24 | error: Use error_report_err() instead of ad hoc printscontrib/ qdev-monitor.c qemu-nbd.c | +3 | 0 replies | |
| 5/24 | error: Improve documentationinclude/ util/ util/ | +23 | 1 reply | |
| 6/24 | block: Clean up "Could not create temporary overlay" error messageblock.c | +2 | 0 replies | |
| 7/24 | qemu-nbd: Clean up "Failed to load snapshot" error messageqemu-nbd.c | +5 | 0 replies | |
| 8/24 | test-throttle: Simplify qemu_init_main_loop() error handlingtests/ | +1 | 0 replies | |
| 9/24 | error: New error_prepend(), error_reportf_err()include/ util/ | +62 | 0 replies | |
| 10/24 | error: Don't decorate original error message when adding to ithw/ qemu-img.c tests/ +1 more | +4 | 0 replies | |
| 11/24 | error: Use error_reportf_err() where it makes obvious sensearch_init.c block/ blockdev.c +14 more | +47 | 2 replies | |
| 12/24 | error: Use error_prepend() where it makes obvious senseblock.c block/ block/ +3 more | +19 | 0 replies | |
| 13/24 | spapr: Use error_reportf_err()hw/ | +4 | 0 replies | |
| 14/24 | migration: Use error_reportf_err() instead of monitor_printf()migration/ | +6 | 0 replies | |
| 15/24 | qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()qemu-io.c qemu-nbd.c tests/ +14 more | +93 | 0 replies | |
| 16/24 | error: Strip trailing '\n' from error string arguments (again)block/ hw/ hw/ +11 more | +31 | 0 replies | |
| 17/24 | vmdk: Clean up control flow in vmdk_parse_extents() a bitblock/ | +15 | 0 replies | |
| 18/24 | vmdk: Clean up "Invalid extent lines" error messageblock/ tests/ | +14 | 1 reply | |
| 19/24 | pci-assign: Clean up "Failed to assign" error messageshw/ | +8 | 1 reply | |
| 20/24 | vhdx: Fix "log that needs to be replayed" error messageblock/ tests/ | +10 | 0 replies | |
| 21/24 | error: Clean up errors with embedded newlines (again)hw/ kvm-all.c qemu-nbd.c | +7 | 0 replies | |
| 22/24 | hw/s390x: Rename local variables Error *l_err to just errhw/ hw/ | +13 | 0 replies | |
| 23/24 | s390/sclp: Simplify control flow in sclp_realize()hw/ | +3 | 0 replies | |
| 24/24 | error: Consistently name Error * objects err, and not errpcontrib/ hmp.c hw/ +2 more | +29 | 1 reply |
Reviews trailers per patch
All 24 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Fam Zheng | David Hildenbrand | Cornelia Huck | Laszlo Ersek | Dr. David Alan Gilbert | Bharata B Rao |
|---|---|---|---|---|---|---|---|
| 1/24 | R-b | ||||||
| 2/24 | R-b | ||||||
| 3/24 | R-b | ||||||
| 4/24 | R-b | ||||||
| 5/24 | R-b | ||||||
| 6/24 | R-b | ||||||
| 7/24 | R-b | ||||||
| 8/24 | R-b | ||||||
| 9/24 | R-b | ||||||
| 10/24 | R-b | ||||||
| 11/24 | R-b | ||||||
| 12/24 | R-b | ||||||
| 13/24 | R-b | ||||||
| 14/24 | R-b | ||||||
| 15/24 | R-b | ||||||
| 16/24 | R-b | A-b | A-b | R-b | A-b | ||
| 17/24 | R-b | R-b | |||||
| 18/24 | R-b | R-b | |||||
| 19/24 | R-b | R-b | |||||
| 20/24 | R-b | ||||||
| 21/24 | R-b | R-b | |||||
| 22/24 | R-b | R-b | A-b | ||||
| 23/24 | R-b | R-b | A-b | ||||
| 24/24 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [Qemu-devel] [PATCH v3 00/24] Error reporting cleanups and fixes
Two topics:
1. Avoid error_get_pretty() when all you want is extend an error message. Doing that with error_get_pretty() loses the error hint. Provide that don't lose it, and are more convenient to use.
2. Newlines in error messages. Jason Herne's "[PATCH v2] checkpatch:
Detect newlines in error_report and other error functions" will catch at least some instances of this kind of mistake in the future.
Based on my "[PATCH v3 00/13] Clean up some hw_error() misuse".
I intend to take these patches through my tree.
v3:
* PATCH 01+11: Commit messages improved, bad Coccinelle like breaks cleaned up [Eric]
* PATCH 02-04+09+12-14+17: Commit messages improved [Eric]
* PATCH 05: Cover a bit more ground in comments [Eric]
* PATCH 16+21: Fix three more instances [Eric]
* PATCH 18: Style fix [Fam]
* PATCH 24: New
v2:
* 19 new patches...
* PATCH 1 became PATCH 16
* PATCH 2 became PATCH 21, with commit message typo fixed [László]
* PATCH 3 split into PATCH 17-20, partly rewritten
* PATCH 4 became PATCH 22
Markus Armbruster (24):
qemu-nbd: Replace BSDism <err.h> by error_report()
error: Use error_report_err() where appropriate (again)
error: Use error_report_err() instead of monitor_printf()
error: Use error_report_err() instead of ad hoc prints
error: Improve documentation
block: Clean up "Could not create temporary overlay" error message
qemu-nbd: Clean up "Failed to load snapshot" error message
test-throttle: Simplify qemu_init_main_loop() error handling
error: New error_prepend(), error_reportf_err()
error: Don't decorate original error message when adding to it
error: Use error_reportf_err() where it makes obvious sense
error: Use error_prepend() where it makes obvious sense
spapr: Use error_reportf_err()
migration: Use error_reportf_err() instead of monitor_printf() qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()
error: Strip trailing '\n' from error string arguments (again)
vmdk: Clean up control flow in vmdk_parse_extents() a bit
vmdk: Clean up "Invalid extent lines" error message
pci-assign: Clean up "Failed to assign" error messages
vhdx: Fix "log that needs to be replayed" error message
error: Clean up errors with embedded newlines (again) hw/s390x: Rename local variables Error *l_err to just err s390/sclp: Simplify control flow in sclp_realize()
error: Consistently name Error * objects err, and not errp
arch_init.c | 4 +- block.c | 20 +++--- block/qcow2.c | 5 +- block/qed.c | 5 +- block/sheepdog.c | 8 +-- block/vhdx-log.c | 13 ++-- block/vmdk.c | 50 +++++++++------ blockdev.c | 12 ++-- contrib/ivshmem-server/main.c | 10 ++- hmp.c | 61 ++++++++---------- hw/arm/cubieboard.c | 9 ++- hw/arm/digic_boards.c | 3 +- hw/arm/imx25_pdk.c | 2 +- hw/arm/kzm.c | 2 +- hw/arm/netduino2.c | 2 +- hw/arm/xlnx-ep108.c | 2 +- hw/arm/xlnx-zynqmp.c | 2 +- hw/block/dataplane/virtio-blk.c | 8 +-- hw/core/nmi.c | 10 +-- hw/core/qdev-properties.c | 6 +- hw/core/qdev.c | 5 +- hw/i386/kvm/pci-assign.c | 16 ++--- hw/i386/pc.c | 9 ++- hw/ppc/e500.c | 4 +- hw/ppc/spapr.c | 10 +-- hw/ppc/spapr_drc.c | 6 +- hw/s390x/ipl.c | 12 ++-- hw/s390x/s390-skeys-kvm.c | 2 +- hw/s390x/s390-skeys.c | 19 +++--- hw/s390x/sclp.c | 21 +++--- hw/scsi/vhost-scsi.c | 6 +- hw/tpm/tpm_tis.c | 2 +- hw/usb/bus.c | 11 ++-- include/qapi/error.h | 51 +++++++++++++-- include/qemu/sockets.h | 2 +- kvm-all.c | 6 +- migration/ram.c | 2 +- migration/savevm.c | 21 +++--- monitor.c | 6 +- net/vhost-user.c | 6 +- qdev-monitor.c | 3 +- qemu-img.c | 33 ++++------ qemu-io.c | 8 +-- qemu-nbd.c | 128 ++++++++++++++++++++++--------------- qga/commands-posix.c | 2 +- replay/replay.c | 3 +- target-arm/cpu.c | 2 +- target-arm/machine.c | 4 +- tests/qemu-iotests/059.out | 12 ++-- tests/qemu-iotests/060.out | 2 +- tests/qemu-iotests/069.out | 2 +- tests/qemu-iotests/070.out | 5 +- tests/qemu-iotests/075.out | 14 ++-- tests/qemu-iotests/076.out | 6 +- tests/qemu-iotests/078.out | 12 ++-- tests/qemu-iotests/080.out | 36 +++++------ tests/qemu-iotests/083.out | 34 +++++----- tests/qemu-iotests/088.out | 12 ++-- tests/qemu-iotests/092.out | 24 +++---- tests/qemu-iotests/103.out | 8 +-- tests/qemu-iotests/114.out | 2 +- tests/qemu-iotests/116.out | 14 ++-- tests/qemu-iotests/131.out | 2 +- tests/test-aio.c | 4 +- tests/test-string-output-visitor.c | 6 +- tests/test-thread-pool.c | 4 +- tests/test-throttle.c | 15 +---- ui/vnc.c | 4 +- util/error.c | 35 +++++++++- util/qemu-error.c | 8 +-- vl.c | 8 +-- 71 files changed, 467 insertions(+), 436 deletions(-)
Signature · 1 line
2.4.3