Skip to content

Add support for Rockchip RK3288 Ethernet

Sjoerd Simons u-boot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 0 repliesNew
  2. v10 of 10 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Store probe gpio in private data not platdata
- Drop unneeded header file
- Move the hook into the dw_adjust_link function
- Rename the hook to fix_mac_speed, similar to Linux
- Fix various coding style nits
- Adjust to new hook name

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12net: designware: support phy reset device-tree bindingsdrivers/net/designware.c drivers/net/designware.h+80 -62 replies
2/12net: designware: Export various functions/struct to allow subclassingdrivers/net/designware.c drivers/net/designware.h+7 -30 replies
3/12net: designware: Add a fix_mac_speed hookdrivers/net/designware.c drivers/net/designware.h+10 -21 reply
4/12rockchip: rk3288: pinctrl: support more pinsdrivers/pinctrl/rockchip/pinctrl_rk3288.c+1 -12 replies
5/12rockchip: rk3288: Add clock support for the gmac ethernet interfacearch/arm/include/asm/arch-rockchip/cru_rk3288.h drivers/clk/clk_rk3288.c+31 -02 replies
6/12rockchip: rk3288: grf: Define GRF_SOC_CON1 and GRF_SOC_CON3arch/arm/include/asm/arch-rockchip/grf_rk3288.h+53 -02 replies
7/12net: gmac_rk3288: Add RK3288 GMAC driverdrivers/net/Kconfig drivers/net/Makefile drivers/net/gmac_rk3288.c+133 -01 reply
7/12net: gmac_rk3288: Add RK3288 GMAC driver+0 -01 reply
8/12rockchip: rk3288-firefly: Add gmac definitionarch/arm/dts/rk3288-firefly.dtsi+16 -01 reply
9/12rockchip: rock2: dts: use status = "okay" not okarch/arm/dts/rk3288-rock2-square.dts+1 -12 replies
10/12rockchip: Enable networking support on rock2 and fireflyconfigs/firefly-rk3288_defconfig configs/rock2_defconfig+10 -01 reply
11/12rockchip: Add PXE and DHCP to the default boot targetsinclude/configs/rk3288_common.h+3 -10 replies
12/12rockchip: Drop Ethernet from the TODOdoc/README.rockchip+0 -10 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchBin MengSimon Glass
1/12R-b
2/12R-b A-b
3/12
4/12R-b
5/12R-b
6/12R-b
7/12
7/12
8/12A-b
9/12R-b
10/12R-b
11/12A-b
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 00/12] Add support for Rockchip RK3288 Ethernet

Second round to add support for the GMAC Ethernet interface on RK3288 SoCs. I had hope to follow up a lot earlier, but things were bussier then expected :(

To add support I've taken a slightly different approach then some of the other boards with a designware IP block, by creating a new driver to take care of the platfrom glue which subclasses the main designware driver instead of adding the compatibility string the designware driver directly and doing the SoC specific setup in the board files. This seems quite a bit more elegant in a device model based world.

I've only tested this series on a Radxa Rock 2 board, it would be great if someone could test this on other boards with the designware IP especially for those with the reset GPIO in devicetree (e.g. some of the Allwinner boards).

Compared to the first one round the pinctrl related bits were dropped as RK3288 now has a full pinctrl driver. Furthermore the started hook in the designware driver was renamed to fix_mac_speed in line with what linux uses and moved to the dw_link_adjust function.

Changes in v2:
- Store probe gpio in private data not platdata
- Drop unneeded header file
- Move the hook into the dw_adjust_link function
- Rename the hook to fix_mac_speed, similar to Linux
- Fix various coding style nits
- Adjust to new hook name

Sjoerd Simons (12):
net: designware: support phy reset device-tree bindings
net: designware: Export various functions/struct to allow subclassing
net: designware: Add a fix_mac_speed hook
rockchip: rk3288: pinctrl: support more pins
rockchip: rk3288: Add clock support for the gmac ethernet interface
rockchip: rk3288: grf: Define GRF_SOC_CON1 and GRF_SOC_CON3
net: gmac_rk3288: Add RK3288 GMAC driver
rockchip: rk3288-firefly: Add gmac definition
rockchip: rock2: dts: use status = "okay" not ok
rockchip: Enable networking support on rock2 and firefly
rockchip: Add PXE and DHCP to the default boot targets
rockchip: Drop Ethernet from the TODO

 arch/arm/dts/rk3288-firefly.dtsi                |  16 +++
 arch/arm/dts/rk3288-rock2-square.dts            |   2 +-
 arch/arm/include/asm/arch-rockchip/cru_rk3288.h |  17 ++++
 arch/arm/include/asm/arch-rockchip/grf_rk3288.h |  53 ++++++++++
 configs/firefly-rk3288_defconfig                |   5 +
 configs/rock2_defconfig                         |   5 +
 doc/README.rockchip                             |   1 -
 drivers/clk/clk_rk3288.c                        |  14 +++
 drivers/net/Kconfig                             |   7 ++
 drivers/net/Makefile                            |   1 +
 drivers/net/designware.c                        |  90 ++++++++++++++---
 drivers/net/designware.h                        |  18 ++++
 drivers/net/gmac_rk3288.c                       | 125 ++++++++++++++++++++++++
 drivers/pinctrl/rockchip/pinctrl_rk3288.c       |   2 +-
 include/configs/rk3288_common.h                 |   4 +-
 15 files changed, 345 insertions(+), 15 deletions(-)
 create mode 100644 drivers/net/gmac_rk3288.c
Signature · 1 line
2.7.0