Skip to content

serial: 8250_fintek: Fix the IRQ mode and code refactoring

Ji-Ze Hong (Peter Hong) linux-serial lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesNew
  2. v17 patches 7 repliesSuperseded

Changelog from the cover letter

V2
1. Code refacting. Suggest by Ricardo Ribalda Delgado.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6serial: 8250_fintek: Refactoring read/write methoddrivers/tty/serial/8250/8250_fintek.c+38 -350 replies
2/6serial: 8250_fintek: Set IRQ Mode when port probeddrivers/tty/serial/8250/8250_fintek.c+22 -230 replies
3/6serial: 8250_fintek: Set maximum FIFO of F81216Hdrivers/tty/serial/8250/8250_fintek.c+26 -30 replies
4/6serial: 8250_fintek: Add F81216 Supportdrivers/tty/serial/8250/8250_fintek.c+24 -20 replies
5/6serial: 8250_fintek: Add F81866 Supportdrivers/tty/serial/8250/8250_fintek.c+68 -60 replies
6/6serial: 8250_fintek: Add F81865 Supportdrivers/tty/serial/8250/8250_fintek.c+6 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/6] serial: 8250_fintek: Fix the IRQ mode and code refactoring

The following patches will fix the Fintek LPC to UARTs IRQ mode mismatch issue and code refactoring.

Some BIOS only use _OSI("Linux") to distinguish between Linux & Windows. Apply Level/Low to UART trigger mode if Windows, Edge/High otherwise. But since 2.6.23 the mainline kernel no longer returns true for _OSI("Linux"). The BIOS ASL should avoid to use _OSI() to check system type and use ACPI MADT override IRQ mode instead.

We'll try to refactoring the source code more readable with SuperIO read/write register functions.

Changelog:
V2
1. Code refacting. Suggest by Ricardo Ribalda Delgado.

Ji-Ze Hong (Peter Hong) (6):
serial: 8250_fintek: Refactoring read/write method
serial: 8250_fintek: Set IRQ Mode when port probed
serial: 8250_fintek: Set maximum FIFO of F81216H
serial: 8250_fintek: Add F81216 Support
serial: 8250_fintek: Add F81866 Support
serial: 8250_fintek: Add F81865 Support

 drivers/tty/serial/8250/8250_fintek.c | 231 +++++++++++++++++++++++++---------
 1 file changed, 173 insertions(+), 58 deletions(-)
Signature · 1 line
1.9.1