Skip to content

clk: aspeed: Fix is_enabled and prevent reset if clock enabled

Eddie James linux-clk lkml 3 versions – Applied

Status from this message: Applied to clk-fixes

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 9 repliesApplied
  2. v2 posting 1/21 patch 0 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v2 from the cover letter

- Fix is_enabled.
- Check for enabled in the spinlock in the enable function.
- Use is_enabled instead of more code to read the register.

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2clk: aspeed: Fix is_enabled for certain clocksdrivers/clk/clk-aspeed.c+2 -12 replies
2/2clk: aspeed: Prevent reset if clock is enableddrivers/clk/clk-aspeed.c+17 -125 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLei YuJoel Stanley
1/2R-b
2/2Root-caused-by R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] clk: aspeed: Fix is_enabled and prevent reset if clock enabled

Here are two fixes for the Aspeed clock driver. The first fixes the is_enabled clock function to account for different clock gates getting disabled with either 0s or 1s. The second patch addresses some issue found with the LPC controller clock if it gets reset while the clock is enabled, which it is by default. Thanks to Lei Yu for tracking down the LPC issue.

Changes since v1:
- Fix is_enabled.
- Check for enabled in the spinlock in the enable function.
- Use is_enabled instead of more code to read the register.

Eddie James (2):
clk: aspeed: Fix is_enabled for certain clocks
clk: aspeed: Prevent reset if clock is enabled

 drivers/clk/clk-aspeed.c | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)
Signature · 1 line
1.8.3.1

Read the cover letter in its thread