Skip to content

Add support for Gen 11 pipe color features

Uma Shankar intel-gfx 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest5 patches 4 repliesIn review
  2. v85 patches 5 repliesSuperseded
  3. v75 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v66 patches8 repliesSuperseded
v56 patches10 repliesSuperseded
v44 patches11 repliesSuperseded
v33 patches4 repliesSuperseded
v13 patches5 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915/glk: Fix degamma lut programmingdrivers/gpu/drm/i915/i915_pci.c drivers/gpu/drm/i915/intel_color.c+35 -290 replies
2/5drm/i915/icl: Add icl pipe degamma and gamma supportdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_color.c+26 -70 replies
3/5drm/i915/icl: Enable ICL Pipe CSC blockdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_color.c+10 -40 replies
4/5drm/i915/icl: Enable pipe output cscdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_color.c drivers/gpu/drm/i915/intel_drv.h+126 -190 replies
5/5drm/i915/icl: Add degamma and gamma lut size to gen11 capsdrivers/gpu/drm/i915/i915_pci.c+2 -11 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatt RoperMaarten LankhorstVille Syrjälä
SeriesA-b
1/5R-b R-b
2/5R-b
3/5R-b R-b
4/5R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [v9 0/5] Add support for Gen 11 pipe color features

This patch series adds support for Gen11 pipe degamma, CSC and gamma hardware blocks.

CRC checks are not working for 10bit gamma but works for 8bit pallete modes which seems to be due to some rounding errors in pipe. Also there is a corner case where Lut precision is increased to 3.16, hence its not possible to accurately represent 1.0 which will require 17 bits. Support for extending the ABI is already in discussion in below series:
https://patchwork.freedesktop.org/patch/249771/

ToDo: Support for Multi Segmented Gamma will be added later.

v2: Addressed Maarten's review comments and re-ordered the patch series.

v3: Addressed Matt's review comments. Removed rmw patterns as suggested by Matt.

v4: Addressed Matt's review comments.

v5: Addressed Matt's, Ville and Jani Nikula's review comments.

v6: Addressed Matt and Ville's review comments. Extended GLK degamma function and merged ICL degamma support to that. Handled pipe output csc separately along with regular pipe csc. Dropped gamma_mode removal patch as Ville is using that to refactor the gamma handling. This series may need a rebase on top of Ville's below series:
https://patchwork.freedesktop.org/series/55081/.

v7: Rebased the series on top of Ville's color management cleanup and state refactoring series. Addressed Matt's review comments and aligned state handling as per atomic design.

v8: Fixed macro alignment and some checkpatch warnings.

v9: Fix Maarten's review comments and added his RB tag.

Uma Shankar (5):
drm/i915/glk: Fix degamma lut programming drm/i915/icl: Add icl pipe degamma and gamma support drm/i915/icl: Enable ICL Pipe CSC block drm/i915/icl: Enable pipe output csc drm/i915/icl: Add degamma and gamma lut size to gen11 caps

 drivers/gpu/drm/i915/i915_pci.c    |   5 +-
 drivers/gpu/drm/i915/i915_reg.h    |  86 ++++++++++++++++++--
 drivers/gpu/drm/i915/intel_color.c | 155 ++++++++++++++++++++++++++-----------
 drivers/gpu/drm/i915/intel_drv.h   |   3 +
 4 files changed, 194 insertions(+), 55 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx