Skip to content

usb: xhci: Add Clear_TT_Buffer

Jim Lin linux-usb lkml 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest posting 2/22 patches 6 repliesIn review
  2. v11 posting 1/22 patches 0 repliesSuperseded
  3. v102 patches 3 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v92 patches2 repliesSuperseded
v82 patches1 replySuperseded
v71 patch2 repliesSuperseded
v61 patch1 replySuperseded
v51 patch0 repliesSuperseded
v41 patch4 repliesSuperseded
v31 patch2 repliesSuperseded
v21 patch1 replySuperseded
v11 patch1 replySuperseded

Patches in v11 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: Add devaddr in struct usb_devicedrivers/usb/core/hub.c drivers/usb/host/xhci.c include/linux/usb.h+7 -11 reply
2/2usb: xhci: Add Clear_TT_Bufferdrivers/usb/host/xhci-ring.c drivers/usb/host/xhci.c drivers/usb/host/xhci.h+52 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMathias NymanAlan Stern
SeriesA-b
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer

USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt processing for full-/low-speed endpoints connected via a TT, the host software must use the Clear_TT_Buffer request to the TT to ensure that the buffer is not in the busy state".

In our case, a full-speed speaker (ConferenceCam) is behind a high- speed hub (ConferenceCam Connect), sometimes once we get STALL on a request we may continue to get STALL with the folllowing requests, like Set_Interface.

Solution is to invoke usb_hub_clear_tt_buffer() to send Clear_TT_Buffer request to the hub of the device for the following Set_Interface requests to the device to get ACK successfully.

The Clear_TT_Buffer request sent to the hub includes the address of the LS/FS child device in wValue field. usb_hub_clear_tt_buffer() uses udev->devnum to set the address wValue. This won't work for devices connected to xHC.

For other host controllers udev->devnum is the same as the address of the usb device, chosen and set by usb core. With xHC the controller hardware assigns the address, and won't be the same as devnum.

Here we have two patches.
One is to add devaddr in struct usb_device for usb_hub_clear_tt_buffer() to use.
Another is to invoke usb_hub_clear_tt_buffer() for halt processing.

Jim Lin (2):
usb: Add devaddr in struct usb_device
usb: xhci: Add Clear_TT_Buffer

 drivers/usb/core/hub.c       |  4 +++-
 drivers/usb/host/xhci-ring.c | 27 ++++++++++++++++++++++++++-
 drivers/usb/host/xhci.c      | 23 +++++++++++++++++++++++
 drivers/usb/host/xhci.h      |  5 +++++
 include/linux/usb.h          |  2 ++
 5 files changed, 59 insertions(+), 2 deletions(-)
Signature · 1 line
2.1.4