usb: xhci: Add Clear_TT_Buffer
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest posting 2/22 patches 6 repliesIn review
- v11 posting 1/22 patches 0 repliesSuperseded
- v102 patches 3 repliesSuperseded
Earlier versions · 9
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v9 | 2 patches | 2 replies | Superseded | |
| v8 | 2 patches | 1 reply | Superseded | |
| v7 | 1 patch | 2 replies | Superseded | |
| v6 | 1 patch | 1 reply | Superseded | |
| v5 | 1 patch | 0 replies | Superseded | |
| v4 | 1 patch | 4 replies | Superseded | |
| v3 | 1 patch | 2 replies | Superseded | |
| v2 | 1 patch | 1 reply | Superseded | |
| v1 | 1 patch | 1 reply | Superseded |
Patches in v11 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | usb: Add devaddr in struct usb_devicedrivers/ drivers/ include/ | +7 | 1 reply | |
| 2/2 | usb: xhci: Add Clear_TT_Bufferdrivers/ drivers/ drivers/ | +52 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Mathias Nyman | Alan Stern |
|---|---|---|
| Series | A-b | |
| 1/2 | A-b | |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer
USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt processing for full-/low-speed endpoints connected via a TT, the host software must use the Clear_TT_Buffer request to the TT to ensure that the buffer is not in the busy state".
In our case, a full-speed speaker (ConferenceCam) is behind a high- speed hub (ConferenceCam Connect), sometimes once we get STALL on a request we may continue to get STALL with the folllowing requests, like Set_Interface.
Solution is to invoke usb_hub_clear_tt_buffer() to send Clear_TT_Buffer request to the hub of the device for the following Set_Interface requests to the device to get ACK successfully.
The Clear_TT_Buffer request sent to the hub includes the address of the LS/FS child device in wValue field. usb_hub_clear_tt_buffer() uses udev->devnum to set the address wValue. This won't work for devices connected to xHC.
For other host controllers udev->devnum is the same as the address of the usb device, chosen and set by usb core. With xHC the controller hardware assigns the address, and won't be the same as devnum.
Here we have two patches.
One is to add devaddr in struct usb_device for usb_hub_clear_tt_buffer() to use.
Another is to invoke usb_hub_clear_tt_buffer() for halt processing.
Jim Lin (2):
usb: Add devaddr in struct usb_device
usb: xhci: Add Clear_TT_Buffer
drivers/usb/core/hub.c | 4 +++- drivers/usb/host/xhci-ring.c | 27 ++++++++++++++++++++++++++- drivers/usb/host/xhci.c | 23 +++++++++++++++++++++++ drivers/usb/host/xhci.h | 5 +++++ include/linux/usb.h | 2 ++ 5 files changed, 59 insertions(+), 2 deletions(-)
Signature · 1 line
2.1.4