Skip to content

scsi: core: allow auto suspend override by low-level driver

Stanley Chu linux-arm-kernel linux-mediatek linux-scsi 5 versions – Applied

Status from this message: Applied to 5.5/scsi-queue, thank you!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyApplied
  2. v33 patches 3 repliesSuperseded
  3. v2 posting 2/23 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/21 patch0 repliesSuperseded
v13 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Change scsi_device->rpm_autosuspend_on to scsi_device->rpm_autosuspend (Bart)
- Make the comment of scsi_device->rpm_autosuspend more elaborate (Bart)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3scsi: core: allow auto suspend override by low-level driverdrivers/scsi/scsi_sysfs.c drivers/scsi/sd.c include/scsi/scsi_device.h +1 more+11 -20 replies
2/3scsi: ufs: override auto suspend tunables for ufsdrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+19 -00 replies
3/3scsi: ufs-mediatek: enable auto suspend capabilitydrivers/scsi/ufs/ufs-mediatek.c+3 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAvri AltmanBart Van AsscheBean Huo
1/3R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] scsi: core: allow auto suspend override by low-level driver

Until now the scsi mid-layer forbids runtime suspend till userspace enables it. This is mainly to quarantine some disks with broken runtime power management or have high latencies executing suspend resume callbacks. If the userspace doesn't enable the runtime suspend the underlying hardware will be always on even when it is not doing any useful work and thus wasting power.

Some low-level drivers for the controllers can efficiently use runtime power management to reduce power consumption and improve battery life.

This patchset allows runtime suspend parameters override within the LLD itself instead of waiting for userspace to control the power management, and make UFS as the first user of this capability.

v3 => v4:
- Change scsi_device->rpm_autosuspend_on to scsi_device->rpm_autosuspend (Bart)
- Make the comment of scsi_device->rpm_autosuspend more elaborate (Bart)

v2 => v3:
- Create a member indicating autosuspend delay for the same SCSI host in SCSI host template (Bart)
- Use separate variables to control different things, (Bart)
(a) Whether or not runtime suspend is enabled at device creation time
(b) The power management autosuspend delay

v1 => v2:
- Allow "zero" sdev->rpm_autosuspend_delay (Avri)
- Fix format of some lines (Avri)

Stanley Chu (3):
scsi: core: allow auto suspend override by low-level driver
scsi: ufs: override auto suspend tunables for ufs
scsi: ufs-mediatek: enable auto suspend capability

 drivers/scsi/scsi_sysfs.c       |  3 ++-
 drivers/scsi/sd.c               |  4 ++++
 drivers/scsi/ufs/ufs-mediatek.c |  3 +++
 drivers/scsi/ufs/ufshcd.c       |  9 +++++++++
 drivers/scsi/ufs/ufshcd.h       | 10 ++++++++++
 include/scsi/scsi_device.h      |  3 ++-
 include/scsi/scsi_host.h        |  3 +++
 7 files changed, 33 insertions(+), 2 deletions(-)
Signature · 1 line
2.18.0