Skip to content

hw/arm/smmuv3: Correct stream ID and event address handling

Simon Veith qemu-arm qemu-devel 3 versions – Applied

Status from this message: Applied to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 5 repliesApplied
  2. v26 patches 2 repliesSuperseded
  3. v15 patches 7 repliesSuperseded

Changes in v3 from the cover letter

* No changes, but sending again to correct a patch submission mishap that confused Patchew

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6hw/arm/smmuv3: Apply address mask to linear strtab base addresshw/arm/smmuv3.c+1 -10 replies
2/6hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK valuehw/arm/smmuv3-internal.h+1 -11 reply
3/6hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZEhw/arm/smmuv3.c+6 -21 reply
4/6hw/arm/smmuv3: Align stream table base address to table sizehw/arm/smmuv3.c+14 -41 reply
5/6hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macrohw/arm/smmuv3-internal.h+2 -20 replies
6/6hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word positionhw/arm/smmuv3.c+1 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchEric Auger
SeriesT-b
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling

While working on the Linux SMMUv3 driver, I noticed a few cases where the QEMU SMMUv3 behavior relating to stream tables was inconsistent with our hardware.

Also, when debugging those differences, I found that the errors reported through the QEMU SMMUv3 event queue contained the address fields in an incorrect position.

These patches correct the QEMU SMMUv3 behavior to match the specification (and the behavior that I observed in our hardware). Linux guests normally will not notice these issues, but other SMMUv3 driver implementations might.

Changes in v2:

* New patch "hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value" added
* Updated patch "hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE"
* Updated patch "hw/arm/smmuv3: Align stream table base address to table size"

Changes in v3:

* No changes, but sending again to correct a patch submission mishap that confused Patchew

Simon Veith (6):
hw/arm/smmuv3: Apply address mask to linear strtab base address hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE hw/arm/smmuv3: Align stream table base address to table size hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word
position

 hw/arm/smmuv3-internal.h |  6 +++---
 hw/arm/smmuv3.c          | 28 +++++++++++++++++++++-------
 2 files changed, 24 insertions(+), 10 deletions(-)
Signature · 1 line
2.7.4