Split SDM845 interconnect nodes and consolidate RPMh support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 11 repliesIn review
- v14 patches 8 repliesSuperseded
Changes in v2 from the cover letter
- Reorganized dt-binding patches
- Fixed a bug that adds duplicate BCM node to voter (Georgi)
- Addressed misc. comments (Georgi)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | dt-bindings: interconnect: Convert qcom,sdm845 to DT schemaDocumentation/ Documentation/ | +43 | 1 reply | |
| 2/6 | dt-bindings: interconnect: Add YAML schemas for QCOM bcm-voterDocumentation/ | +45 | 1 reply | |
| 3/6 | dt-bindings: interconnect: Update Qualcomm SDM845 DT bindingsDocumentation/ | +40 | 3 replies | |
| 4/6 | interconnect: qcom: Consolidate interconnect RPMh supportdrivers/ drivers/ drivers/ +3 more | +712 | 2 replies | |
| 5/6 | interconnect: qcom: sdm845: Split qnodes into their respective NoCsdrivers/ include/ | +609 | 2 replies | |
| 6/6 | arm64: dts: sdm845: Redefine interconnect provider DT nodesarch/ | +58 | 2 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by.
| Patch | Rob Herring |
|---|---|
| 1/6 | R-b |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] Split SDM845 interconnect nodes and consolidate RPMh support
While there are no current consumers of the SDM845 interconnect device in devicetree, take this opportunity to redefine the interconnect device nodes as the previous definitions of using a single child node under the apps_rsc device did not accurately capture the description of the hardware. The Network-On-Chip (NoC) interconnect devices should be represented in a manner akin to QCS404 platforms[1] where there is a separation of NoC devices and its RPM/RPMh counterparts.
The bcm-voter devices are representing the RPMh devices that the interconnect providers need to communicate with and there can be more than one instance of the Bus Clock Manager (BCM) which can live under different instances of Resource State Coordinators (RSC). There are display use cases where consumers may need to target a different bcm-voter (Some display specific RSC) than the default, and there needs to be a way to represent this connection in devicetree.
This patches series extends the discussions[2][3] involving the SDM845 interconnect bindings by adding accompanying driver implementations using the split NoC devices. Some of the code used to support the SDM845 provider driver are refactored into common modules that can used by other RPMh based interconnect providers such as SC7180[4]. This patch series also updates existing sdm845 binding documentation to DT schema format using json-schema.
v2:
- Reorganized dt-binding patches
- Fixed a bug that adds duplicate BCM node to voter (Georgi)
- Addressed misc. comments (Georgi)
v1: https://lkml.org/lkml/2019/12/16/15
[1]: https://lkml.org/lkml/2019/6/13/143
[2]: https://lkml.org/lkml/2019/7/19/1063
[3]: https://lkml.org/lkml/2019/10/16/1793
[4]: https://lkml.org/lkml/2019/11/26/389
David Dai (6):
dt-bindings: interconnect: Convert qcom,sdm845 to DT schema
dt-bindings: interconnect: Add YAML schemas for QCOM bcm-voter
dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
interconnect: qcom: Consolidate interconnect RPMh support
interconnect: qcom: sdm845: Split qnodes into their respective NoCs
arm64: dts: sdm845: Redefine interconnect provider DT nodes
.../bindings/interconnect/qcom,bcm-voter.yaml | 45 + .../bindings/interconnect/qcom,sdm845.txt | 24 - .../bindings/interconnect/qcom,sdm845.yaml | 74 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 +- drivers/interconnect/qcom/Kconfig | 8 + drivers/interconnect/qcom/Makefile | 4 + drivers/interconnect/qcom/bcm-voter.c | 363 +++++++ drivers/interconnect/qcom/bcm-voter.h | 28 + drivers/interconnect/qcom/icc-rpmh.c | 158 +++ drivers/interconnect/qcom/icc-rpmh.h | 151 +++ drivers/interconnect/qcom/sdm845.c | 1132 ++++++++------------ include/dt-bindings/interconnect/qcom,sdm845.h | 263 ++--- 12 files changed, 1498 insertions(+), 813 deletions(-) create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml delete mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml create mode 100644 drivers/interconnect/qcom/bcm-voter.c create mode 100644 drivers/interconnect/qcom/bcm-voter.h create mode 100644 drivers/interconnect/qcom/icc-rpmh.c create mode 100644 drivers/interconnect/qcom/icc-rpmh.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project