Skip to content

tools/perf: Add extended regs support for powerpc

Athira Rajeev linuxppc-dev 7 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/22 patches 1 replyApplied
  2. v6 posting 1/22 patches 1 replyApplied
  3. v54 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v4 posting 2/24 patches2 repliesSuperseded
v4 posting 1/22 patches2 repliesSuperseded
v32 patches2 repliesSuperseded
v21 patch2 repliesSuperseded

Changes in v6 from the cover letter

- Split perf tools side changes to one patchset as suggested by Arnaldo
Link to previous series:
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=192624

Patches in v6 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2tools/perf: Add perf tools support for extended register capability in powerpctools/arch/powerpc/include/uapi/asm/perf_regs.h tools/perf/arch/powerpc/include/perf_regs.h tools/perf/arch/powerpc/util/header.c +2 more+82 -100 replies
2/2tools/perf: Add perf tools support for extended regs in power10tools/arch/powerpc/include/uapi/asm/perf_regs.h tools/perf/arch/powerpc/include/perf_regs.h tools/perf/arch/powerpc/util/perf_regs.c+15 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMadhavan SrinivasanKajol JainRavi Bangoria
1/2R-b R-b Reviewed-and-tested-by
2/2R-b Reviewed-and-tested-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH V6 0/2] tools/perf: Add extended regs support for powerpc

Patch set to add perf tools support for perf extended register capability in powerpc.

Patch 1/2 adds extended regs for power9 ( mmcr0, mmcr1 and mmcr2 ) to sample_reg_mask in the tool side to use with -I?. Patch 2/2 adds extended regs for power10 ( mmcr3, sier2, sier3) to sample_reg_mask in the tool side.

Ravi bangoria found an issue with perf record -I while testing the changes. The same issue is currently being worked on here:
https://lkml.org/lkml/2020/7/19/413 and will be resolved once fix from Jin Yao is merged.

This includes the perf tools side changes to support extended regs. kernel side changes are sent as separate patchset.

Changelog:
Changes from v5 -> v6
- Split perf tools side changes to one patchset as suggested by Arnaldo
Link to previous series:
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=192624

Changes from v4 -> v5
- initialize perf_reg_extended_max to work on
all platforms as suggested by Ravi Bangoria
- Added Reviewed-and-Tested-by from Ravi Bangoria

Changes from v3 -> v4
- Split the series and send extended regs as separate patch set here. Link to previous series :
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=190462&state=*
Other PMU patches are already merged in powerpc/next.

- Fixed kernel build issue when using config having
CONFIG_PERF_EVENTS set and without CONFIG_PPC_PERF_CTRS
reported by kernel build bot.
- Included Reviewed-by from Kajol Jain.
- Addressed review comments from Ravi Bangoria to initialize perf_reg_extended_max and define it in lowercase since it is local variable.

Anju T Sudhakar (1):
tools/perf: Add perf tools support for extended register capability in
powerpc

Athira Rajeev (1):
tools/perf: Add perf tools support for extended regs in power10

 tools/arch/powerpc/include/uapi/asm/perf_regs.h | 20 ++++++++-
 tools/perf/arch/powerpc/include/perf_regs.h     |  8 +++-
 tools/perf/arch/powerpc/util/header.c           |  9 +---
 tools/perf/arch/powerpc/util/perf_regs.c        | 55 +++++++++++++++++++++++++
 tools/perf/arch/powerpc/util/utils_header.h     | 15 +++++++
 5 files changed, 97 insertions(+), 10 deletions(-)
 create mode 100644 tools/perf/arch/powerpc/util/utils_header.h
Signature · 1 line
1.8.3.1