Skip to content

Add kernel seccomp support for m68k

Michael Schmitz linux-kselftest linux-m68k 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest3 patches 21 repliesIn review
  2. v123 patches 1 replySuperseded
  3. v11 posting 2/23 patches 1 replySuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v11 posting 1/23 patches2 repliesSuperseded
v103 patches6 repliesSuperseded
v93 patches0 repliesSuperseded
v83 patches4 repliesSuperseded
v72 patches0 repliesSuperseded
v62 patches8 repliesSuperseded
v52 patches11 repliesSuperseded
v41 patch2 repliesSuperseded
v2 RFC1 patch0 repliesSuperseded
v1 RFC1 patch0 repliesSuperseded

Patches in v13 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3m68k/kernel - check syscall_trace_enter() return code on m68karch/m68k/68000/entry.S arch/m68k/coldfire/entry.S arch/m68k/kernel/entry.S+7 -02 replies
2/3m68k: add kernel seccomp supportDocumentation/features/seccomp/seccomp-filter/arch-support.txt arch/m68k/Kconfig arch/m68k/include/asm/seccomp.h +4 more+80 -24 replies
3/3tools/testing - seccomp test fixes for m68ktools/testing/selftests/seccomp/seccomp_bpf.c+7 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGeert Uytterhoeven
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [PATCH v13 0/3] Add kernel seccomp support for m68k

Previous version of patch 1 did overwrite a syscall return value that was changed by ptrace or seccomp (in regs->d0) by -ENOSYS when skipping a syscall. Branch directly to ret_from_syscall instead of falling through to badsys (which must set -ENOSYS). I'm sure this can be done more elegantly.

Patch 3 used the wrong struct definition for ARCH_REGS - the kernel ptrace code copies 19 registers (from syscall stack and switch_stack, pt_regs only contains the 14 from the syscall stack). Stack overflow ensues.

With these changes, 79 of 94 seccomp_bpf tests now succeed.

Cheers,

Michael