Skip to content

Add BLK_CTL support for i.MX8MP

Abel Vesa linux-arm-kernel linux-clk linux-devicetree linux-pm lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest14 patches 21 repliesIn review
  2. v414 patches 3 repliesSuperseded
  3. v314 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v217 patches30 repliesSuperseded
v117 patches17 repliesSuperseded

Changes in v5 from the cover letter

* added back the bus_blk_clk in the imx8mp blk_ctl driver (media_blk_ctl)
* added the R-b tag from Rob to the documentation patch

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14dt-bindings: clocks: imx8mp: Rename audiomix ids clocks to audio_blk_ctlinclude/dt-bindings/clock/imx8mp-clock.h+60 -601 reply
2/14dt-bindings: reset: imx8mp: Add audio blk_ctl reset IDsinclude/dt-bindings/reset/imx8mp-reset.h+5 -01 reply
3/14dt-bindings: clock: imx8mp: Add ids for the audio shared gateinclude/dt-bindings/clock/imx8mp-clock.h+11 -11 reply
4/14dt-bindings: clock: imx8mp: Add media blk_ctl clock IDsinclude/dt-bindings/clock/imx8mp-clock.h+28 -01 reply
5/14dt-bindings: reset: imx8mp: Add media blk_ctl reset IDsinclude/dt-bindings/reset/imx8mp-reset.h+28 -01 reply
6/14dt-bindings: clock: imx8mp: Add hdmi blk_ctl clock IDsinclude/dt-bindings/clock/imx8mp-clock.h+40 -01 reply
7/14dt-bindings: reset: imx8mp: Add hdmi blk_ctl reset IDsinclude/dt-bindings/reset/imx8mp-reset.h+12 -01 reply
8/14clk: imx8mp: Add audio shared gatedrivers/clk/imx/clk-imx8mp.c+11 -11 reply
9/14Documentation: bindings: clk: Add bindings for i.MX BLK_CTLDocumentation/devicetree/bindings/clock/fsl,imx-blk-ctl.yaml+60 -02 replies
10/14clk: imx: Add generic blk-ctl driverdrivers/clk/imx/Makefile drivers/clk/imx/clk-blk-ctl.c drivers/clk/imx/clk-blk-ctl.h+383 -17 replies
11/14clk: imx: Add blk-ctl driver for i.MX8MPdrivers/clk/imx/Makefile drivers/clk/imx/clk-blk-ctl-imx8mp.c+318 -11 reply
12/14arm64: dts: imx8mp: Add audio_blk_ctl nodearch/arm64/boot/dts/freescale/imx8mp.dtsi+15 -00 replies
13/14arm64: dts: imx8mp: Add media_blk_ctl nodearch/arm64/boot/dts/freescale/imx8mp.dtsi+15 -00 replies
14/14arm64: dts: imx8mp: Add hdmi_blk_ctl nodearch/arm64/boot/dts/freescale/imx8mp.dtsi+7 -00 replies

Reviews trailers per patch

12 of 14 patches have a Reviewed-by or Acked-by.

PatchRob HerringDong AishengStephen Boyd
1/14A-b R-b A-b
2/14A-b R-b A-b
3/14A-b R-b A-b
4/14A-b R-b A-b
5/14A-b R-b A-b
6/14A-b R-b A-b
7/14A-b R-b A-b
8/14R-b A-b
9/14R-b R-b A-b
10/14
11/14R-b
12/14R-b
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/14] Add BLK_CTL support for i.MX8MP

The BLK_CTL according to HW design is basically the wrapper of the entire function specific group of IPs and holds GPRs that usually cannot be placed into one specific IP from that group. Some of these GPRs are used to control some clocks, other some resets, others some very specific function that does not fit into clocks or resets. Since the clocks are registered using the i.MX clock subsystem API, the driver is placed into the clock subsystem, but it also registers the resets. For the other functionalities that other GPRs might have, the syscon is used.

Changes since v4:
* added back the bus_blk_clk in the imx8mp blk_ctl driver (media_blk_ctl)
* added the R-b tag from Rob to the documentation patch

Abel Vesa (14):
dt-bindings: clocks: imx8mp: Rename audiomix ids clocks to
audio_blk_ctl
dt-bindings: reset: imx8mp: Add audio blk_ctl reset IDs
dt-bindings: clock: imx8mp: Add ids for the audio shared gate
dt-bindings: clock: imx8mp: Add media blk_ctl clock IDs
dt-bindings: reset: imx8mp: Add media blk_ctl reset IDs
dt-bindings: clock: imx8mp: Add hdmi blk_ctl clock IDs
dt-bindings: reset: imx8mp: Add hdmi blk_ctl reset IDs
clk: imx8mp: Add audio shared gate
Documentation: bindings: clk: Add bindings for i.MX BLK_CTL
clk: imx: Add generic blk-ctl driver
clk: imx: Add blk-ctl driver for i.MX8MP
arm64: dts: imx8mp: Add audio_blk_ctl node
arm64: dts: imx8mp: Add media_blk_ctl node
arm64: dts: imx8mp: Add hdmi_blk_ctl node

 .../devicetree/bindings/clock/fsl,imx-blk-ctl.yaml |  60 ++++
 arch/arm64/boot/dts/freescale/imx8mp.dtsi          |  37 +++
 drivers/clk/imx/Makefile                           |   2 +-
 drivers/clk/imx/clk-blk-ctl-imx8mp.c               | 317 +++++++++++++++++++++
 drivers/clk/imx/clk-blk-ctl.c                      | 302 ++++++++++++++++++++
 drivers/clk/imx/clk-blk-ctl.h                      |  80 ++++++
 drivers/clk/imx/clk-imx8mp.c                       |  12 +-
 include/dt-bindings/clock/imx8mp-clock.h           | 200 +++++++++----
 include/dt-bindings/reset/imx8mp-reset.h           |  45 +++
 9 files changed, 992 insertions(+), 63 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx-blk-ctl.yaml
 create mode 100644 drivers/clk/imx/clk-blk-ctl-imx8mp.c
 create mode 100644 drivers/clk/imx/clk-blk-ctl.c
 create mode 100644 drivers/clk/imx/clk-blk-ctl.h
Signature · 1 line
2.7.4