Skip to content

riscv: Add qspinlock/qrwlock

[email protected] linux-arch linux-csky linux-riscv linuxppc-dev lkml openrisc sparclinux 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest9 patches 10 repliesIn review
  2. v57 patches 2 repliesSuperseded
  3. v44 patches 58 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v34 patches2 repliesSuperseded

Changes in v6 from the cover letter

- Add ticket-lock for riscv, default is qspinlock
- Keep ticket-lock for csky, default is ticketlock
- Using smp_cond_load for riscv ticket-lock
- Optimize csky ticketlock with smp_cond_load, store_release
- Add PPC_LBARX_LWARX for powerpc

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9locking/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32kernel/Kconfig.locks kernel/locking/qspinlock.c+28 -215 replies
2/9riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlockarch/riscv/Kconfig arch/riscv/include/asm/Kbuild arch/riscv/include/asm/spinlock.h +1 more+11 -1360 replies
3/9riscv: locks: Introduce ticket-based spinlock implementationarch/riscv/Kconfig arch/riscv/include/asm/spinlock.h arch/riscv/include/asm/spinlock_types.h+107 -13 replies
4/9csky: locks: Optimize coding conventionarch/csky/include/asm/spinlock.h+4 -71 reply
5/9csky: Convert custom spinlock/rwlock to generic qspinlock/qrwlockarch/csky/Kconfig arch/csky/include/asm/Kbuild arch/csky/include/asm/spinlock.h +1 more+18 -00 replies
6/9openrisc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32arch/openrisc/Kconfig+1 -01 reply
7/9sparc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32arch/sparc/Kconfig+1 -00 replies
8/9xtensa: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32arch/xtensa/Kconfig+1 -00 replies
9/9powerpc/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32arch/powerpc/Kconfig+1 -00 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchGuo RenStafford Horne
1/9
2/9T-b
3/9
4/9
5/9
6/9A-b
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/9] riscv: Add qspinlock/qrwlock

From: Guo Ren <[email protected]>

Current riscv is still using baby spinlock implementation. It'll cause fairness and cache line bouncing problems. Many people are involved and pay the efforts to improve it:

- The first version of patch was made in 2019.1:
https://lore.kernel.org/linux-riscv/20190211043829.30096-1-michaeljclark at mac.com/#r

- The second version was made in 2020.11:
https://lore.kernel.org/linux-riscv/1606225437-22948-2-git-send-email-guoren at kernel.org/

- A good discussion at Platform HSC.2021-03-08:
https://drive.google.com/drive/folders/1ooqdnIsYx7XKor5O1XTtM6D1CHp4hc0p

- A good discussion on V4 in mailling list:
https://lore.kernel.org/linux-riscv/1616868399-82848-1-git-send-email-guoren at kernel.org/T/#t

- Openrisc's maintainer want to implement arch_cmpxchg infrastructure.
https://lore.kernel.org/linux-riscv/1616868399-82848-1-git-send-email-guoren at kernel.org/T/#m11b712fb6a4fda043811b1f4c3d61446951ed65a

Hope your comments and Tested-by or Co-developed-by or Reviewed-by ...

Let's kick the qspinlock into riscv right now (Also for the architecture which hasn't xchg16 atomic instruction.)

Change V6:
- Add ticket-lock for riscv, default is qspinlock
- Keep ticket-lock for csky, default is ticketlock
- Using smp_cond_load for riscv ticket-lock
- Optimize csky ticketlock with smp_cond_load, store_release
- Add PPC_LBARX_LWARX for powerpc

Change V5:
- Fixup #endif comment typo by Waiman
- Remove cmpxchg coding convention patches which will get into a separate patchset later by Arnd's advice
- Try to involve more architectures in the discussion

Change V4:
- Remove custom sub-word xchg implementation
- Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 in locking/qspinlock

Change V3:
- Coding convention by Peter Zijlstra's advices

Change V2:
- Coding convention in cmpxchg.h
- Re-implement short xchg
- Remove char & cmpxchg implementations

Guo Ren (8):
locking/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32
riscv: locks: Introduce ticket-based spinlock implementation
csky: locks: Optimize coding convention
csky: Convert custom spinlock/rwlock to generic qspinlock/qrwlock
openrisc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32
sparc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32
xtensa: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 powerpc/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

Michael Clark (1):
riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock

 arch/csky/Kconfig                       |   8 ++
 arch/csky/include/asm/Kbuild            |   2 +
 arch/csky/include/asm/spinlock.h        |  15 +--
 arch/csky/include/asm/spinlock_types.h  |   4 +
 arch/openrisc/Kconfig                   |   1 +
 arch/powerpc/Kconfig                    |   1 +
 arch/riscv/Kconfig                      |   8 ++
 arch/riscv/include/asm/Kbuild           |   3 +
 arch/riscv/include/asm/spinlock.h       | 158 +++++++++---------------
 arch/riscv/include/asm/spinlock_types.h |  26 ++--
 arch/sparc/Kconfig                      |   1 +
 arch/xtensa/Kconfig                     |   1 +
 kernel/Kconfig.locks                    |   3 +
 kernel/locking/qspinlock.c              |  46 +++----
 14 files changed, 142 insertions(+), 135 deletions(-)
Signature · 1 line
2.17.1