Skip to content

Introduce Architectural LBR for vPMU

Yang Weijiang kvm lkml 8 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest16 patches 1 replyApplied
  2. v1116 patches 20 repliesSuperseded
  3. v1016 patches 7 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v917 patches1 replySuperseded
v815 patches5 repliesSuperseded
v715 patches10 repliesSuperseded
v612 patches2 repliesSuperseded
v513 patches25 repliesSuperseded

Changes in v12 from the cover letter

1. Refactor KVM pmu helpers and fixed some commit messages. (Kan)
2. Use SMRAM to save/restore MSR_ARCH_LBR_CTL at SMM entry/exit. (Paolo)
3. Add Kan's reviewed-by in commit messages.
4. Rebased to queue:kvm/kvm.git

Patches in v12 Applied

#Subject and filesSizeRepliesApplied
1/16perf/x86/intel: Fix the comment about guest LBR support on KVMarch/x86/events/intel/core.c+1 -20 replies
2/16perf/x86/lbr: Simplify the exposure check for the LBR_INFO registersarch/x86/events/intel/lbr.c+1 -30 replies
3/16KVM: x86: Report XSS as an MSR to be saved if there are supported featuresarch/x86/kvm/x86.c+5 -00 replies
4/16KVM: x86: Refresh CPUID on writes to MSR_IA32_XSSarch/x86/kvm/cpuid.c arch/x86/kvm/x86.c+17 -50 replies
5/16KVM: x86: Add Arch LBR MSRs to msrs_to_save_all listarch/x86/kvm/x86.c+6 -00 replies
6/16KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBRarch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/pmu_intel.c+51 -00 replies
7/16KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL for guest Arch LBRarch/x86/events/intel/lbr.c arch/x86/include/asm/msr-index.h arch/x86/include/asm/vmx.h +2 more+66 -80 replies
8/16KVM: x86/pmu: Refactor code to support guest Arch LBRarch/x86/kvm/vmx/pmu_intel.c arch/x86/kvm/vmx/vmx.c+38 -150 replies
9/16KVM: x86: Refine the matching and clearing logic for supported_xssarch/x86/kvm/vmx/vmx.c arch/x86/kvm/x86.c+8 -30 replies
10/16KVM: x86/vmx: Check Arch LBR config when return perf capabilitiesarch/x86/include/asm/vmx.h arch/x86/kvm/vmx/capabilities.h arch/x86/kvm/vmx/vmx.c+19 -20 replies
11/16KVM: x86: Add XSAVE Support for Architectural LBRarch/x86/kvm/vmx/vmx.c arch/x86/kvm/x86.c+5 -10 replies
12/16KVM: nVMX: Add necessary Arch LBR settings for nested VMarch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/pmu_intel.c arch/x86/kvm/vmx/vmcs12.c +1 more+10 -30 replies
13/16KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guestarch/x86/kvm/vmx/vmx.c+20 -00 replies
14/16KVM: x86/vmx: Flip Arch LBREn bit on guest state changearch/x86/kvm/vmx/vmx.c+26 -00 replies
15/16KVM: x86: Add Arch LBR data MSR access interfacearch/x86/kvm/vmx/pmu_intel.c+10 -00 replies
16/16KVM: x86/cpuid: Advertise Arch LBR feature in CPUIDarch/x86/kvm/cpuid.c+32 -10 replies

Reviews trailers per patch

9 of 16 patches have a Reviewed-by or Acked-by.

PatchKan LiangAndi KleenJim Mattson
1/16R-b R-b
2/16R-b R-b
3/16
4/16
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16
10/16
11/16
12/16
13/16R-b
14/16
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/16] Introduce Architectural LBR for vPMU

Intel CPU model-specific LBR(Legacy LBR) evolved into Architectural LBR(Arch LBR[0]), it's the replacement of legacy LBR on new platforms. The native support patches were merged into 5.9 kernel tree, and this patch series is to enable Arch LBR in vPMU so that guest can benefit from the merits of the feature.

The main advantages of Arch LBR are [1]:
- Faster context switching due to XSAVES support and faster reset of LBR MSRs via the new DEPTH MSR
- Faster LBR read for a non-PEBS event due to XSAVES support, which lowers the overhead of the NMI handler.
- Linux kernel can support the LBR features without knowing the model number of the current CPU.

From end user's point of view, the usage of Arch LBR is the same as the Legacy LBR that has been merged in the mainline.

Note, in this series, we impose one restriction for guest Arch LBR:
Guest can only set the same LBR record depth as host, this is due to the special behavior of MSR_ARCH_LBR_DEPTH: 1) On write to the MSR, it'll reset all Arch LBR recording MSRs to 0s. 2) XRSTORS resets all record MSRs to 0s if the saved depth mismatches MSR_ARCH_LBR_DEPTH. Enforcing the restriction keeps the KVM enabling patch simple and straightforward.

[0] https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf
[1] https://lore.kernel.org/lkml/[email protected]/

Qemu patch:
https://patchwork.ozlabs.org/project/qemu-devel/cover/[email protected]/

Previous version:
v11: https://lore.kernel.org/all/[email protected]/

Changes in v12:
1. Refactor KVM pmu helpers and fixed some commit messages. (Kan)
2. Use SMRAM to save/restore MSR_ARCH_LBR_CTL at SMM entry/exit. (Paolo)
3. Add Kan's reviewed-by in commit messages.
4. Rebased to queue:kvm/kvm.git

Like Xu (6):
perf/x86/intel: Fix the comment about guest LBR support on KVM perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBR
KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL for guest Arch LBR
KVM: x86: Refine the matching and clearing logic for supported_xss
KVM: x86: Add XSAVE Support for Architectural LBR

Sean Christopherson (1):
KVM: x86: Report XSS as an MSR to be saved if there are supported
features

Yang Weijiang (9):
KVM: x86: Refresh CPUID on writes to MSR_IA32_XSS
KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list
KVM: x86/pmu: Refactor code to support guest Arch LBR
KVM: x86/vmx: Check Arch LBR config when return perf capabilities
KVM: nVMX: Add necessary Arch LBR settings for nested VM
KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guest
KVM: x86/vmx: Flip Arch LBREn bit on guest state change
KVM: x86: Add Arch LBR data MSR access interface
KVM: x86/cpuid: Advertise Arch LBR feature in CPUID

 arch/x86/events/intel/core.c     |   3 +-
 arch/x86/events/intel/lbr.c      |   6 +-
 arch/x86/include/asm/kvm_host.h  |   3 +
 arch/x86/include/asm/msr-index.h |   1 +
 arch/x86/include/asm/vmx.h       |   4 +
 arch/x86/kvm/cpuid.c             |  49 +++++++++-
 arch/x86/kvm/vmx/capabilities.h  |   9 ++
 arch/x86/kvm/vmx/nested.c        |   7 +-
 arch/x86/kvm/vmx/pmu_intel.c     | 159 +++++++++++++++++++++++++++----
 arch/x86/kvm/vmx/vmcs12.c        |   1 +
 arch/x86/kvm/vmx/vmcs12.h        |   3 +-
 arch/x86/kvm/vmx/vmx.c           |  80 +++++++++++++++-
 arch/x86/kvm/x86.c               |  23 ++++-
 13 files changed, 310 insertions(+), 38 deletions(-)

base-commit: a3808d88461270c71d3fece5e51cc486ecdac7d0

Signature · 1 line
2.27.0