Skip to content

mpc83xx_wdt rework, support for mpc8610 and mpc8xx

Anton Vorontsov linuxppc-dev lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/28 patches 9 repliesIn review
  2. v4 posting 1/28 patches 0 repliesSuperseded
  3. v38 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v26 patches9 repliesSuperseded

Changes in v4 from the cover letter

- None. Simply resending, plus adding Andrew Morton and linux-kernel to Cc, since I'm constantly getting bounces from Wim Van Sebroeck's email:

- - - -
<[email protected]>:
213.249.96.99 does not like recipient.
Remote host said: 450 Client host rejected: cannot find your hostname, [85.21.88.2] Giving up on 213.249.96.99.
I'm not going to try again; this message has been in the queue too long.
- - - -

Patches in v4 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8mpc83xx_wdt: fix checkpatch issuesdrivers/watchdog/mpc83xx_wdt.c+7 -52 replies
2/8mpc83xx_wdt: convert to the OF platform driverdrivers/watchdog/mpc83xx_wdt.c+30 -320 replies
3/8mpc83xx_wdt: add support for MPC86xx CPUsdrivers/watchdog/Kconfig drivers/watchdog/mpc83xx_wdt.c+74 -100 replies
4/8mpc83xx_wdt: rename to mpc8xxx_wdtdrivers/watchdog/Kconfig drivers/watchdog/Makefile drivers/watchdog/mpc83xx_wdt.c +1 more+304 -2970 replies
5/8mpc8xxx_wdt: various renames, mostly s/mpc83xx/mpc8xxx/gdrivers/watchdog/mpc8xxx_wdt.c+52 -520 replies
6/8mpc8xxx_wdt: add support for MPC8xx watchdogsdrivers/watchdog/Kconfig drivers/watchdog/mpc8xxx_wdt.c+35 -120 replies
7/8fsl_soc: remove mpc83xx_wdt codearch/powerpc/sysdev/fsl_soc.c+0 -460 replies
8/886xx: mpc8610_hpcd: add watchdog nodearch/powerpc/boot/dts/mpc8610_hpcd.dts+5 -00 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchStephen RothwellJochen Friedrich
1/8
2/8A-b
3/8
4/8
5/8
6/8T-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH 0/8 v4] mpc83xx_wdt rework, support for mpc8610 and mpc8xx

Hi all,

No comments on the previous version for two weeks... resending once again.

Changes since v3:

- None. Simply resending, plus adding Andrew Morton and linux-kernel to Cc, since I'm constantly getting bounces from Wim Van Sebroeck's email:

- - - -
<[email protected]>:
213.249.96.99 does not like recipient.
Remote host said: 450 Client host rejected: cannot find your hostname, [85.21.88.2] Giving up on 213.249.96.99.
I'm not going to try again; this message has been in the queue too long.
- - - -

Not sure whose fault is it though.

Andrew, if Wim will not get this series and there will no objections, could you please pick [WATCHDOG] ones?

Changes since v2:

- New patch to fix current driver's checkpatch issues;
- New patch supporting MPC8xx watchdogs;
- Removed MODULE_ALIAS("platform:mpc83xx_wdt"), since this driver is no longer on the platform bus;
- When renaming the driver also mention what kind of CPUs we support. Also give a pointer for BookE watchdog driver. Though BookE users will not see the MPC8xxx driver at all, because we're explicitly listing the CPU families in "depends on". But this tip might be useful for developers.
- Scott Wood noticed that we don't need device_type anymore. I thought that OpenFirmware defines this type, but google didn't prove that. So I just removed the device_type.

Changes since v1:

- Scott Wood asked for mpc83xx_wdt on multiplatform kernels. Done via OF platform driver;
- Kumar Gala asked for mpc83xx_wdt -> mpc8xxx_wdt rename. Done in two steps;
- Segher Boessenkool noticed a negligence in the wdt device tree node. Fixed by removing mpc83xx_wdt compatible entry.

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2