aic7xxx: debloat

Denys Vlasenko linux-scsi lkml 1 version Jul 1, 2008 In review

Get series with b4

b4 am [email protected]

Versions newest first

v1 Latest Jul 1, 20083 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#	Subject and files	Size	Replies
1/3	aic7xxx: introduce "dont_generate_debug_code" keyword in aicasm parser`drivers/scsi/aic7xxx/aicasm/aicasm_gram.y` `drivers/scsi/aic7xxx/aicasm/aicasm_scan.l` `drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c` +1 more	+16 -1	0 replies
2/3	aic7xxx: update .reg files`drivers/scsi/aic7xxx/aic79xx.reg` `drivers/scsi/aic7xxx/aic7xxx.reg`	+311 -0	1 reply
3/3	aic7xxx: update *_shipped files`drivers/scsi/aic7xxx/aic79xx_reg.h_shipped` `drivers/scsi/aic7xxx/aic79xx_reg_print.c_shipped` `drivers/scsi/aic7xxx/aic7xxx_reg.h_shipped` +1 more	+133 ~~-4197~~	0 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] aic7xxx: debloat

Hi Hannes,

aic7xxx still contains ~30kb of dead code if pretty printing of registers is requested. These patches deal with it.

I did not get any feedback from you whether the approach of adding "dont_generate_debug_code" marker would be acceptable despite asking twice. I decided that it's a "Yes".

The patches are compile tested on linux-2.6.26-rc8 and apply cleanly to current scsi-misc.

Size differences:

text data bss dec hex filename
DEBUG_ENABLE+PRETTY_PRINT:

 234697    2362    1188  238247   3a2a7 linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 205092    2362    1188  208642   32f02 linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o
NO_DEBUG_ENABLE+PRETTY_PRINT:
 227272    2362    1172  230806   38596 linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 197671    2362    1172  201205   311f5 linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o
DEBUG_ENABLE+NO_PRETTY_PRINT:
 192457    2362    1188  196007   2fda7 linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 192457    2362    1188  196007   2fda7 linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o
NO_DEBUG_ENABLE+NO_PRETTY_PRINT:
 185040    2362    1172  188574   2e09e linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 185040    2362    1172  188574   2e09e linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o

Please apply to scsi-misc.

Signed-off-by Denys Vlasenko <[email protected]>

--
vda

Read the cover letter in its thread