Skip to content

et131x cleanups - phase 1

Alan Cox netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26et1310: kill pAdapter in favour of a sane namedrivers/staging/et131x/et1310_eeprom.c drivers/staging/et131x/et1310_jagcore.c drivers/staging/et131x/et1310_mac.c +9 more+794 -7941 reply
2/26et131x: spinlocksdrivers/staging/et131x/et1310_phy.c drivers/staging/et131x/et1310_pm.c drivers/staging/et131x/et1310_rx.c +3 more+69 -690 replies
3/26et131x: power statedrivers/staging/et131x/et1310_pm.h drivers/staging/et131x/et1310_rx.c drivers/staging/et131x/et131x_initpci.c +1 more+1 -160 replies
4/26et131x: kill unused RCV_REF macrosdrivers/staging/et131x/et131x_adapter.h+0 -20 replies
5/26et131x: kill refcountdrivers/staging/et131x/et1310_pm.c drivers/staging/et131x/et1310_rx.c drivers/staging/et131x/et131x_adapter.h+0 -130 replies
6/26et131x: MPSend macrosdrivers/staging/et131x/et1310_tx.c drivers/staging/et131x/et131x_adapter.h+4 -90 replies
7/26et131x: kill copied PCI fieldsdrivers/staging/et131x/et1310_eeprom.c drivers/staging/et131x/et1310_phy.c drivers/staging/et131x/et131x_adapter.h +2 more+8 -320 replies
8/26et131x: Take a kref for the PCI pointer we cachedrivers/staging/et131x/et131x_initpci.c+3 -10 replies
9/26et131x: CSRAddress to regsdrivers/staging/et131x/et1310_jagcore.c drivers/staging/et131x/et1310_mac.c drivers/staging/et131x/et1310_phy.c +8 more+72 -720 replies
10/26et131x: Eliminate RegistryDMA Cachedrivers/staging/et131x/et1310_tx.c drivers/staging/et131x/et131x_adapter.h drivers/staging/et131x/et131x_config.c+1 -30 replies
11/26et131x: eliminate write only registry fieldsdrivers/staging/et131x/et131x_adapter.h drivers/staging/et131x/et131x_config.c+0 -80 replies
12/26et131x: clean up constant rx/tx registry fieldsdrivers/staging/et131x/et1310_jagcore.c drivers/staging/et131x/et1310_rx.c drivers/staging/et131x/et1310_tx.c +3 more+19 -430 replies
13/26et131x: attack the config stuffdrivers/staging/et131x/et131x_adapter.h drivers/staging/et131x/et131x_config.c drivers/staging/et131x/et131x_initpci.c+23 -960 replies
14/26et131x: config is already zeroeddrivers/staging/et131x/et131x_config.c+18 -570 replies
15/26et131x: fold the diet config into the other codedrivers/staging/et131x/Makefile drivers/staging/et131x/et131x_config.c drivers/staging/et131x/et131x_initpci.c+86 -1840 replies
16/26et131x: de-hungarianise a bitdrivers/staging/et131x/et1310_eeprom.c drivers/staging/et131x/et1310_mac.c drivers/staging/et131x/et1310_phy.c +5 more+377 -3930 replies
17/26et131x: continue pruning unused fieldsdrivers/staging/et131x/et1310_jagcore.h drivers/staging/et131x/et1310_phy.c drivers/staging/et131x/et131x_adapter.h+1 -240 replies
18/26et131x: remove unused PCI identifiersdrivers/staging/et131x/et1310_phy.h drivers/staging/et131x/et1310_pm.h drivers/staging/et131x/et131x_defs.h+0 -630 replies
19/26et131x: eeprom remove featuresdrivers/staging/et131x/et1310_eeprom.c drivers/staging/et131x/et1310_eeprom.h drivers/staging/et131x/et131x_config.c +1 more+7 -360 replies
20/26et131x: sort out the mmc enable routinedrivers/staging/et131x/et1310_address_map.h drivers/staging/et131x/et1310_jagcore.c+10 -380 replies
21/26et131x: clean up MMC_SRAM_drivers/staging/et131x/et1310_address_map.h drivers/staging/et131x/et131x_debug.c+13 -330 replies
22/26et131x: quick tidy of the debug codedrivers/staging/et131x/et131x_debug.c+38 -470 replies
23/26et131x: kill the Q_ADDR structdrivers/staging/et131x/et1310_address_map.h drivers/staging/et131x/et1310_jagcore.c drivers/staging/et131x/et131x_debug.c+30 -630 replies
24/26et131x: clean up PM_CSR_tdrivers/staging/et131x/et1310_address_map.h drivers/staging/et131x/et1310_mac.c drivers/staging/et131x/et1310_pm.c +2 more+43 -740 replies
25/26et131x: clean up DMA10/DMA4 typesdrivers/staging/et131x/et1310_address_map.h drivers/staging/et131x/et1310_rx.c drivers/staging/et131x/et1310_rx.h +3 more+120 -2010 replies
26/26et131x: clean up MP_FLAG macrosdrivers/staging/et131x/et1310_mac.c drivers/staging/et131x/et1310_phy.c drivers/staging/et131x/et1310_pm.c +5 more+24 -390 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/26] et131x cleanups - phase 1

Begin turning the et131x driver into something presentable. The only hairy bit is the DMA10 stuff. Has all been lightly tested.

---

Alan Cox (26):
et131x: clean up MP_FLAG macros
et131x: clean up DMA10/DMA4 types
et131x: clean up PM_CSR_t
et131x: kill the Q_ADDR struct
et131x: quick tidy of the debug code
et131x: clean up MMC_SRAM_
et131x: sort out the mmc enable routine
et131x: eeprom remove features
et131x: remove unused PCI identifiers
et131x: continue pruning unused fields
et131x: de-hungarianise a bit
et131x: fold the diet config into the other code
et131x: config is already zeroed
et131x: attack the config stuff
et131x: clean up constant rx/tx registry fields
et131x: eliminate write only registry fields
et131x: Eliminate RegistryDMA Cache
et131x: CSRAddress to regs
et131x: Take a kref for the PCI pointer we cache
et131x: kill copied PCI fields
et131x: MPSend macros
et131x: kill refcount
et131x: kill unused RCV_REF macros
et131x: power state
et131x: spinlocks
et1310: kill pAdapter in favour of a sane name

 drivers/staging/et131x/Makefile             |    1 
 drivers/staging/et131x/et1310_address_map.h |  311 ++++----------
 drivers/staging/et131x/et1310_eeprom.c      |  190 ++++-----
 drivers/staging/et131x/et1310_eeprom.h      |   16 -
 drivers/staging/et131x/et1310_jagcore.c     |   73 +--
 drivers/staging/et131x/et1310_jagcore.h     |   19 -
 drivers/staging/et131x/et1310_mac.c         |  228 +++++------
 drivers/staging/et131x/et1310_phy.c         |  524 ++++++++++++------------
 drivers/staging/et131x/et1310_phy.h         |   37 --
 drivers/staging/et131x/et1310_pm.c          |   65 +--
 drivers/staging/et131x/et1310_pm.h          |   40 --
 drivers/staging/et131x/et1310_rx.c          |  365 ++++++++---------
 drivers/staging/et131x/et1310_rx.h          |    4 
 drivers/staging/et131x/et1310_tx.c          |  580 +++++++++++++--------------
 drivers/staging/et131x/et1310_tx.h          |    6 
 drivers/staging/et131x/et131x_adapter.h     |   74 ---
 drivers/staging/et131x/et131x_config.c      |  323 ---------------
 drivers/staging/et131x/et131x_debug.c       |  107 ++---
 drivers/staging/et131x/et131x_defs.h        |   16 -
 drivers/staging/et131x/et131x_initpci.c     |  300 ++++++++------
 drivers/staging/et131x/et131x_isr.c         |   60 +--
 drivers/staging/et131x/et131x_netdev.c      |   72 ++-
 delete mode 100644 drivers/staging/et131x/et131x_config.c