Skip to content

ARM: mach-shmobile: sh7372 INTC DT update

Magnus Damm linux-sh 1 version In review

Get series with b4
b4 am 20121116103433.4231.27004.sendpatchset@w520

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ARM: mach-shmobile: sh7372 INTC DT INTCA/INTCS typo fixarch/arm/mach-shmobile/intc-sh7372.c+1 -10 replies
2/4ARM: mach-shmobile: sh7372 INTC DT section mismatch fixarch/arm/mach-shmobile/intc-sh7372.c+4 -40 replies
3/4ARM: mach-shmobile: sh7372 INTC DT init cleanuparch/arm/mach-shmobile/intc-sh7372.c+20 -340 replies
4/4ARM: mach-shmobile: sh7372 INTC DT consolidationarch/arm/boot/dts/sh7372.dtsi arch/arm/mach-shmobile/intc-sh7372.c drivers/sh/intc/of_intc.c+55 -1470 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/04] ARM: mach-shmobile: sh7372 INTC DT update

ARM: mach-shmobile: sh7372 INTC DT update

[PATCH 01/04] ARM: mach-shmobile: sh7372 INTC DT INTCA/INTCS typo fix [PATCH 02/04] ARM: mach-shmobile: sh7372 INTC DT section mismatch fix [PATCH 03/04] ARM: mach-shmobile: sh7372 INTC DT init cleanup [PATCH 04/04] ARM: mach-shmobile: sh7372 INTC DT consolidation

This series shaves off 100 lines of code from the INTC DT implementation available in the devel/of branch of
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git

These patches are the result of me trying to get the new INTC DT code working on the sh7372 Mackerel board. With these fixes and cleanups applied the board boots as expected with DT, but as usual the sh7372 SoC setup code is using serial ports and timers as platform devices.

I tried using the INTC DT interrupt controller code with external interrupt pins on the sh7372 mackerel board with DT, but for some reason the following network device refuses to probe due to some interrupt issue.

       lan9220@14000000 {
               compatible = "smsc,lan9220", "smsc,lan9115";
               reg = <0x14000000 0x2000000>;
               phy-mode = "mii";
               interrupt-parent = <&intca_irq_pins_lo>;
               interrupts = <0x2c0>;
               reg-io-width = <4>;
               smsc,irq-push-pull;
       };

The above snippet is nicked and adjusted from my earlier prototype patches:
[PATCH] sh: INTC IRQ domain and DT support prototype
[PATCH] ARM: mach-shmobile: sh7372 DT IRQ prototype

I wonder, is there any outstanding INTC work related to IRQ domains?

Perhaps the best way forward is that Iwamatsu-san rolls these changes into his current patches and releases a new version after updating the other SoCs.

---

 arch/arm/boot/dts/sh7372.dtsi        |    8 -
 arch/arm/mach-shmobile/intc-sh7372.c |  250 +++++++++-------------------------
 drivers/sh/intc/of_intc.c            |    8 -
 3 files changed, 80 insertions(+), 186 deletions(-)