Skip to content

Improve CFAR handling

Paul Mackerras kvm-ppc linuxppc-dev 1 version In review

Get series with b4
b4 am 20130205040902.GA20303@drongo

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4powerpc: Remove Cell-specific relocation-on interrupt vector codearch/powerpc/kernel/exceptions-64s.S+0 -100 replies
2/4powerpc: Save CFAR before branching in interrupt entry pathsarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+133 -460 replies
3/4KVM: PPC: Book3S HV: Preserve guest CFAR register valuearch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/kvm_book3s_asm.h arch/powerpc/include/asm/kvm_host.h +2 more+24 -21 reply
4/4KVM: PPC: Book3S PR: Fix compilation on 32-bit machinesarch/powerpc/kvm/book3s_pr.c+1 -00 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchAlexander Graf
1/4
2/4
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Improve CFAR handling

The CFAR (Come From Address Register) is useful for debugging; it records the address of the most recent taken branch or rfid instructions. At present, KVM doesn't even try to context switch it, and the first-level interrupt handlers for some interrupts have a branch before it gets saved, which will corrupt it.

This series fixes the interrupt handlers to not corrupt the CFAR, and makes KVM context-switch it. The series is against Ben H.'s next branch. The last patch in the series corrects a compile error for 32-bit PR KVM configs which was introduced by an earlier commit in Ben's next branch.

I suggest this series should go via Ben's tree rather than the KVM tree, since most of the changes are to core powerpc interrupt handling code. Alex, if you could ack patch 3/4 that would be helpful.

Paul.