Skip to content

Introducing goto for error and lock handling

Quentin Lambert kernel-janitors lkml 1 version In review

Get series with b4
b4 am 20150311140247.GA17012@sloth

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Staging: dgnc: dgnc_driver: Add a missing call to dgnc_tty_uninitdrivers/staging/dgnc/dgnc_driver.c+1 -00 replies
2/3Staging: dgnc: Use goto for error handlingdrivers/staging/dgnc/dgnc_cls.c drivers/staging/dgnc/dgnc_driver.c drivers/staging/dgnc/dgnc_neo.c+22 -415 replies
3/3Staging: dgnc: Use goto for spinlock release before returndrivers/staging/dgnc/dgnc_tty.c+23 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Introducing goto for error and lock handling

The first patch fix a missing call to dgnc_tty_uninit.

The other two patches focus on the TODO item:
use goto statements for error handling when appropriate

The second patch resolves cases where the improvement seems clear.

The third patch deals with cases where the added value did not seem as important or the changes felt more complex.

Quentin Lambert (3):
Staging: dgnc: dgnc_driver: Add a missing call to dgnc_tty_uninit
Staging: dgnc: Use goto for error handling
Staging: dgnc: Use goto for spinlock release before return

 drivers/staging/dgnc/dgnc_cls.c    | 19 ++++++---------
 drivers/staging/dgnc/dgnc_driver.c | 13 +++--------
 drivers/staging/dgnc/dgnc_neo.c    | 30 ++++++++++--------------
 drivers/staging/dgnc/dgnc_tty.c    | 48 ++++++++++++++++++--------------------
 4 files changed, 45 insertions(+), 65 deletions(-)
Signature · 1 line
1.9.1