Skip to contentSkip to conversation

Introducing goto for error and lock handling

PATCH In review Quentin Lambert 1 participant 1 message Mar 11, 2015 Kernel janitors

lore
Share & tools
lore
#0 lore raw

cover Introducing goto for error and lock handling

The first patch fix a missing call to dgnc_tty_uninit.

The other two patches focus on the TODO item:
use goto statements for error handling when appropriate

The second patch resolves cases where the improvement seems clear.

The third patch deals with cases where the added value did not seem as important or the changes felt more complex.

Quentin Lambert (3):
Staging: dgnc: dgnc_driver: Add a missing call to dgnc_tty_uninit
Staging: dgnc: Use goto for error handling
Staging: dgnc: Use goto for spinlock release before return

 drivers/staging/dgnc/dgnc_cls.c    | 19 ++++++---------
 drivers/staging/dgnc/dgnc_driver.c | 13 +++--------
 drivers/staging/dgnc/dgnc_neo.c    | 30 ++++++++++--------------
 drivers/staging/dgnc/dgnc_tty.c    | 48 ++++++++++++++++++--------------------
 4 files changed, 45 insertions(+), 65 deletions(-)
Signature · 1 line
1.9.1