Skip to content

iio: distance: srf08: add IIO driver for us ranger

Andreas Klinger linux-devicetree linux-i2c linux-iio lkml 4 versions – Applied

Status from this message: Applied to the togreg branch of iio.git. Will be first

Get series with b4
b4 am 20170125190609.GA9246@andreas

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesApplied
  2. v33 patches 4 repliesSuperseded
  3. v22 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches1 replySuperseded

Changes in v4 from the cover letter

Jonathan suggested to use the same units for the max_range attribute as used for the distance raw value which is now changed in the driver. Thanks for the review and detailed suggestions.

* Patch 2: "iio: distance: srf08: add IIO driver for us ranger"
- changed units of max_range attribute to meter
- changed max_range_available to print out min-, step- and max-value instead of each single value

* Patch 3: "iio: distance: srf08: add driver ABI documentation"
- removed standard elements from documentation
- changed documentation of max_range_available attribute

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3iio: distance: srf08: add trivial DT bindingDocumentation/devicetree/bindings/i2c/trivial-devices.txt Documentation/devicetree/bindings/vendor-prefixes.txt+2 -01 reply
2/3iio: distance: srf08: add IIO driver for us rangerdrivers/iio/proximity/Kconfig drivers/iio/proximity/Makefile drivers/iio/proximity/srf08.c+411 -11 reply
3/3iio: distance: srf08: add driver ABI documentationDocumentation/ABI/testing/sysfs-bus-iio-distance-srf08+22 -01 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] iio: distance: srf08: add IIO driver for us ranger

This patch series adds IIO driver support for srf08 ultrasonic ranger devices.

The first patch add a trivial device tree binding for the device together with a new vendor devantech.

The second patch is the IIO driver which in turn is using I2C to talk to the device.

The third patch documents the added userspace ABI

Documentation about the sensor can be found here:

http://www.robot-electronics.co.uk/htm/srf08tech.html

Changes in v4:
Jonathan suggested to use the same units for the max_range attribute as used for the distance raw value which is now changed in the driver. Thanks for the review and detailed suggestions.

* Patch 2: "iio: distance: srf08: add IIO driver for us ranger"
- changed units of max_range attribute to meter
- changed max_range_available to print out min-, step- and max-value instead of each single value

* Patch 3: "iio: distance: srf08: add driver ABI documentation"
- removed standard elements from documentation
- changed documentation of max_range_available attribute

Changes in v3:
Thanks to the reviews of Jonathan, Rob and Lars.
Some changes to the driver were made:

* Patch 2: "iio: distance: srf08: add IIO driver for us ranger"
- defaults values for sensitivity (gain) and max. range are set in

    probe()

- while waiting for ultrasonic echo first wait as long as the physically measurement need as a function of the max. range and then wait in smaller steps until the response can be read.
- attributes are now called sensor_sensitivity instead of gain and sensor_max_range instead of range_mm
- device-name is now "srf08"
- config menu is now calles "Proximity and distance sensors" instead of a separate menu

* Patch 3: "iio: distance: srf08: add driver ABI documentation"
- newly created to document the driver specific interfaces

Changes in v2:
Lots of updates thanks to Peters really fast review within 30 minutes after first submission of the driver.

* Patch 2: "iio: distance: srf08: add IIO driver for us ranger"
- alphabetic order in Makefile
- use of u8 while accessing registers
- avoid endianness problems with 16 bit values
- missing return value checks
- some explaining documentation added

Andreas Klinger (3):
iio: distance: srf08: add trivial DT binding
iio: distance: srf08: add IIO driver for us ranger
iio: distance: srf08: add driver ABI documentation

 .../ABI/testing/sysfs-bus-iio-distance-srf08       |  22 ++
 .../devicetree/bindings/i2c/trivial-devices.txt    |   1 +
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 drivers/iio/proximity/Kconfig                      |  13 +-
 drivers/iio/proximity/Makefile                     |   1 +
 drivers/iio/proximity/srf08.c                      | 398 +++++++++++++++++++++
 6 files changed, 435 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-distance-srf08
 create mode 100644 drivers/iio/proximity/srf08.c
Signature · 1 line
2.1.4