Skip to content

Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions

Thomas Petazzoni u-boot 1 version New

Get series with b4
b4 am 20170824211332.7a6d7aea@windsurf

Versions newest first

  1. v1 Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions

Hello,

Quoted 7 lines · Wolfgang Denk
Quoted 4 lines

I believe this patch series is a step in that direction. With this patch series applied, we can now clearly identify which boards have custom values for CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE}, and therefore more easily move these from the .h files to defconfig files.

So you think moving this to Kconfig would be a second step? Ok, fine with me.

Yes, this would be a second step. The current patch series eliminates the situations where the .h files use the default values, or values that are close enough to the default values for the default value to remain reasonable.

Of course, the patches should be reviewed, and the decision taken by them potentially discussed.

Quoted 5 lines
Quoted 2 lines

The choice for such values is totally independent from the HW, but rather tied to the specific use of a given board. For the same board,

No, it is not. Buffer sizes eat on RAM, and there are environments (like today in SPL) where this may be a precious resource.

Right, true.

Quoted 10 lines
Quoted 5 lines

most people will find the default value to be OK, some people will need a larger number of command arguments or a bigger Linux kernel command line.

Let me know what your preference is.

I think it makes a lot of sense to keep such configuration parameters changable, but we hould not stop half way but rather move this to Kconfig so it's easy to use a default setting, and only boards with special needs have to adjust this in their defconfig files.

OK. So let's review this first patch series. Once we agree on it and it gets merged, I can work on the second step of moving those configuration options to Kconfig.

Thanks for the very useful feedback!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Read the cover letter in its thread