RFC Current State of my clk patches
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest29 patches 20 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/29 | therm: split return code and value in nvkm_get_tempdrm/ drm/ drm/ +6 more | +55 | 2 replies | |
| 2/29 | hwmon: properly check for errorsdrm/ | +26 | 1 reply | |
| 3/29 | subdev/volt/gk104: return error when read failsdrm/ | +6 | 2 replies | |
| 4/29 | clk: Rename nvkm_pstate_calc to nvkm_clk_update and export itdrm/ drm/ | +17 | 2 replies | |
| 5/29 | clk: Remove dstatedrm/ drm/ | +2 | 1 reply | |
| 6/29 | clk: Make pstate a pointer to nvkm_pstatedrm/ drm/ drm/ +1 more | +26 | 2 replies | |
| 7/29 | clk: Hold information about the current cstate statusdrm/ drm/ | +27 | 1 reply | |
| 8/29 | clk: We should pass the pstate id around not the index in the listdrm/ drm/ | +41 | 2 replies | |
| 9/29 | clk: Set clocks to pre suspend state after suspenddrm/ | +7 | 1 reply | |
| 10/29 | core/device: Move therm behind clkdrm/ | +1 | 0 replies | |
| 11/29 | debugfs: Wake up GPU before doing any reclockingdrm/ | +4 | 0 replies | |
| 12/29 | therm: Don't cancel the timerdrm/ | +2 | 0 replies | |
| 13/29 | therm: Move the temp readout into the alarmdrm/ drm/ | +21 | 0 replies | |
| 14/29 | therm: Trigger reclock in temperature daemondrm/ | +8 | 1 reply | |
| 15/29 | bios: add thermal policies tabledrm/ drm/ drm/ | +109 | 2 replies | |
| 16/29 | clk: parse thermal policies for throttling thresholdsdrm/ drm/ | +44 | 2 replies | |
| 17/29 | clk: thermal throttlingdrm/ drm/ | +33 | 1 reply | |
| 18/29 | clk: Only do partial reclocks as requireddrm/ drm/ | +21 | 0 replies | |
| 19/29 | secboot/acr352: reset PMU after secbootdrm/ | +13 | 0 replies | |
| 20/29 | device: enable clk for Maxwell2drm/ drm/ | +12 | 0 replies | |
| 21/29 | clk: Save the max clock we can setdrm/ drm/ | +3 | 0 replies | |
| 22/29 | nvif: Add boost info and set operationsdrm/ drm/ | +76 | 0 replies | |
| 23/29 | debugfs: Add boost interface to change the boost_modedrm/ | +80 | 0 replies | |
| 24/29 | bios/vpstate: there are some fermi vbios with no boost or tdp entrydrm/ | +8 | 0 replies | |
| 25/29 | bios/vpstate: parse max battery iddrm/ drm/ | +3 | 0 replies | |
| 26/29 | clk: refactor the base and boost clock limits so that we can limit pstates as welldrm/ drm/ drm/ | +36 | 0 replies | |
| 27/29 | clk: implement limiting pstates just like we do for cstatesdrm/ | +52 | 0 replies | |
| 28/29 | clk: move the switch out of the loop in nvkm_cstate_validdrm/ | +19 | 0 replies | |
| 29/29 | clk: limit clocks on batterydrm/ drm/ | +19 | 0 replies |
Reviews trailers per patch
14 of 29 patches have a Reviewed-by or Acked-by.
| Patch | Martin Peres | Pierre Moreau |
|---|---|---|
| 1/29 | ||
| 2/29 | R-b | |
| 3/29 | R-b | |
| 4/29 | ||
| 5/29 | R-b | R-b |
| 6/29 | R-b | |
| 7/29 | R-b | A-b |
| 8/29 | R-b | |
| 9/29 | R-b | R-b |
| 10/29 | ||
| 11/29 | ||
| 12/29 | R-b | |
| 13/29 | ||
| 14/29 | R-b | R-b |
| 15/29 | A-b | |
| 16/29 | ||
| 17/29 | R-b | |
| 18/29 | ||
| 19/29 | ||
| 20/29 | ||
| 21/29 | R-b | |
| 22/29 | R-b | |
| 23/29 | R-b | |
| 24/29 | ||
| 25/29 | ||
| 26/29 | ||
| 27/29 | ||
| 28/29 | ||
| 29/29 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/29] Current State of my clk patches
Just wanted to post updated versions of my last series/patches. Reviews welcomed.
It would be also nice if we agree on features I should focus upstreaming, so that this work can be better splitted or reordered.
Sadly most of my patches depend on the rather big clk subdev rework and I think those patches shows best, why I think this rework is actually needed and makes things much easier to add later on.
Feature overview:
1- 3: Hwmon fixes on suspended device
4- 8: Clk subdev rework to decouple current and expected clock states
Fix reclocking while suspended
9: Restore clocks on Suspend
10: Fix reclocking while going into suspend
11: Fix reclocking while suspending
12-14: Thermal daemon triggers reclocks on temperature change when needed
includes volt updates and dropping cstates according to the vbios
15-17: Thermal throttling
18: Don't do full reclocks when only parts need to be updated
19-20: Hacky Workaround for enabling Maxwell2 reclocking (hidden behind module parameter) 21-23: debugfs file to change boost mode
24-29: Parse battery vpstate to throttle clocks when system is running on battery
Karol Herbst (29):
therm: split return code and value in nvkm_get_temp
hwmon: properly check for errors
subdev/volt/gk104: return error when read fails
clk: Rename nvkm_pstate_calc to nvkm_clk_update and export it
clk: Remove dstate
clk: Make pstate a pointer to nvkm_pstate
clk: Hold information about the current cstate status
clk: We should pass the pstate id around not the index in the list
clk: Set clocks to pre suspend state after suspend core/device: Move therm behind clk
debugfs: Wake up GPU before doing any reclocking
therm: Don't cancel the timer
therm: Move the temp readout into the alarm
therm: Trigger reclock in temperature daemon
bios: add thermal policies table
clk: parse thermal policies for throttling thresholds
clk: thermal throttling
clk: Only do partial reclocks as required secboot/acr352: reset PMU after secboot
device: enable clk for Maxwell2
clk: Save the max clock we can set
nvif: Add boost info and set operations
debugfs: Add boost interface to change the boost_mode bios/vpstate: there are some fermi vbios with no boost or tdp entry bios/vpstate: parse max battery id
clk: refactor the base and boost clock limits so that we can limit
pstates as well
clk: implement limiting pstates just like we do for cstates
clk: move the switch out of the loop in nvkm_cstate_valid
clk: limit clocks on battery
drm/nouveau/include/nvif/if0001.h | 15 + drm/nouveau/include/nvkm/core/device.h | 2 +- .../include/nvkm/subdev/bios/thermal_policies.h | 27 ++ drm/nouveau/include/nvkm/subdev/bios/vpstate.h | 1 + drm/nouveau/include/nvkm/subdev/clk.h | 23 +- drm/nouveau/include/nvkm/subdev/therm.h | 3 +- drm/nouveau/nouveau_debugfs.c | 90 ++++- drm/nouveau/nouveau_hwmon.c | 48 ++- drm/nouveau/nvkm/engine/device/base.c | 3 + drm/nouveau/nvkm/engine/device/ctrl.c | 66 +++- drm/nouveau/nvkm/subdev/bios/Kbuild | 1 + drm/nouveau/nvkm/subdev/bios/thermal_policies.c | 81 +++++ drm/nouveau/nvkm/subdev/bios/vpstate.c | 13 +- drm/nouveau/nvkm/subdev/clk/base.c | 375 +++++++++++++++------ drm/nouveau/nvkm/subdev/clk/gk104.c | 10 +- drm/nouveau/nvkm/subdev/pmu/gk20a.c | 18 +- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 13 + drm/nouveau/nvkm/subdev/therm/base.c | 59 ++-- drm/nouveau/nvkm/subdev/therm/g84.c | 11 +- drm/nouveau/nvkm/subdev/therm/gp100.c | 9 +- drm/nouveau/nvkm/subdev/therm/nv40.c | 9 +- drm/nouveau/nvkm/subdev/therm/nv50.c | 9 +- drm/nouveau/nvkm/subdev/therm/priv.h | 4 +- drm/nouveau/nvkm/subdev/therm/temp.c | 16 +- drm/nouveau/nvkm/subdev/volt/base.c | 3 + drm/nouveau/nvkm/subdev/volt/gk104.c | 7 +- 26 files changed, 723 insertions(+), 193 deletions(-) create mode 100644 drm/nouveau/include/nvkm/subdev/bios/thermal_policies.h create mode 100644 drm/nouveau/nvkm/subdev/bios/thermal_policies.c
Signature · 6 lines
2.14.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau