Skip to content

qmp: 'wakeup-suspend-support' in query-target

Daniel Henrique Barboza qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 6 repliesIn review
  2. v42 patches 3 repliesSuperseded
  3. v32 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v22 patches3 repliesSuperseded

Changes in v5 from the cover letter

- removed a paragraph in the recently added qemu_register_wakeup_notifier comment that was added. That paragraph was adding too much in-depth information about the current design of the system_wakeup, making it harder to understand the whole point (suggested by Mike Roth).
- previous version link:
https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00879.html

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qmp: adding 'wakeup-suspend-support' in query-targetarch_init.c include/sysemu/sysemu.h qapi-schema.json +1 more+26 -10 replies
2/2qga: update guest-suspend-ram and guest-suspend-hybrid descriptionsqga/qapi-schema.json+10 -40 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMichael Roth
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

v5:
- removed a paragraph in the recently added qemu_register_wakeup_notifier comment that was added. That paragraph was adding too much in-depth information about the current design of the system_wakeup, making it harder to understand the whole point (suggested by Mike Roth).
- previous version link:
https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00879.html

v4:
- added a comment in 'qemu_register_wakeup_notifier' about the effects of adding a wakeup notifier without proper suspend/wakeup support in the logic of the new wakeup-suspend-support flag, as suggested by Mike Roth
- previous version link:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg00358.html

v3:
- added a "(since 2.12)" notation in the new flag, as suggested by Eric Blake
- added a "backwards compatible" note in the commit msg
- previous version link:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg00093.html

v2:
- changed the approach based on v1 discussions: instead of a new API, add the required flag in QMP query-target
- dropped patch 2 since query-target does not have an HMP counterpart
- previous version link:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00889.html

Daniel Henrique Barboza (2):
qmp: adding 'wakeup-suspend-support' in query-target
qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

 arch_init.c             |  1 +
 include/sysemu/sysemu.h |  1 +
 qapi-schema.json        |  4 +++-
 qga/qapi-schema.json    | 14 ++++++++++----
 vl.c                    | 21 +++++++++++++++++++++
 5 files changed, 36 insertions(+), 5 deletions(-)
Signature · 1 line
2.14.3