Skip to content

Series short description

Alexander Duyck netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 8 repliesIn review
  2. v28 patches 21 repliesSuperseded
  3. v15 patches 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6udp: Record gso_segs when supporting UDP segmentation offloadnet/ipv4/udp.c+2 -00 replies
2/6udp: Do not pass MSS as parameter to GSO segmentationinclude/net/udp.h net/ipv4/udp_offload.c net/ipv6/udp_offload.c+6 -40 replies
3/6udp: Do not pass checksum as a parameter to GSO segmentationinclude/net/udp.h net/ipv4/udp_offload.c net/ipv6/udp_offload.c+20 -221 reply
4/6udp: Partially unroll handling of first segment and last segmentnet/ipv4/udp_offload.c+19 -145 replies
5/6udp: Add support for software checksum and GSO_PARTIAL with GSO offloadnet/ipv4/udp_offload.c net/ipv6/udp_offload.c+20 -201 reply
6/6udp: Do not copy destructor if one is not presentnet/ipv4/udp_offload.c+14 -81 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchEric DumazetWillem de Bruijn
1/6R-b A-b
2/6R-b A-b
3/6A-b
4/6R-b A-b
5/6A-b
6/6R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [net-next PATCH v3 0/6] Series short description

This patch set addresses a number of issues I found while sorting out enabling UDP GSO Segmentation support for ixgbe/ixgbevf. Specifically there were a number of issues related to the checksum and such that seemed to cause either minor irregularities or kernel panics in the case of the offload request being allowed to traverse between name spaces.

With this set applied I am was able to get UDP GSO traffic to pass over vxlan tunnels in both offloaded modes and non-offloaded modes for ixgbe and ixgbevf.

I submitted the driver specific patches earlier as an RFC:
https://patchwork.ozlabs.org/project/netdev/list/?series=42477&archive=both&state=*

v2: Updated patches based on feedback from Eric Dumazet
Split first patch into several patches based on feedback from Eric
v3: Drop patch that was calling pskb_may_pull as it was redundant.
Added code to use MANGLED_0 in case of UDP checksum
Drop patch adding NETIF_F_GSO_UDP_L4 to list of GSO software offloads Added Acked-by for patches reviewed by Willem and not changed

---

Alexander Duyck (6):
udp: Record gso_segs when supporting UDP segmentation offload
udp: Do not pass MSS as parameter to GSO segmentation
udp: Do not pass checksum as a parameter to GSO segmentation
udp: Partially unroll handling of first segment and last segment
udp: Add support for software checksum and GSO_PARTIAL with GSO offload
udp: Do not copy destructor if one is not present

 include/net/udp.h      |    3 +-
 net/ipv4/udp.c         |    2 +
 net/ipv4/udp_offload.c |   94 +++++++++++++++++++++++++++++++-----------------
 net/ipv6/udp_offload.c |   16 +-------
 4 files changed, 64 insertions(+), 51 deletions(-)