Skip to content

drm/i915/gen11: Implement planar format support.

Maarten Lankhorst intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15drm/i915: Clean up casts to crtc_state in intel_atomic_commit_tail()drivers/gpu/drm/i915/intel_display.c+12 -101 reply
2/15drm/i915: Handle cursor updating active_planes correctly.drivers/gpu/drm/i915/intel_display.c+17 -82 replies
3/15drm/i915: Make intel_crtc_disable_planes() use active planes mask.drivers/gpu/drm/i915/intel_display.c+14 -151 reply
4/15drm/i915: Replace call to commit_planes_on_crtc with internal update, v2.drivers/gpu/drm/i915/intel_atomic_plane.c drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+33 -221 reply
5/15drm/i915: Clean up scaler setup.drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_atomic.c drivers/gpu/drm/i915/intel_display.c+66 -510 replies
6/15drm/i915: Force NV12 coordinates to be a multiple of 2drivers/gpu/drm/i915/intel_display.c+9 -00 replies
7/15drm/i915: Unconditionally clear plane_state->visible flagdrivers/gpu/drm/i915/intel_atomic_plane.c+2 -10 replies
8/15drm/i915/gen11: Enable 6 sprites on gen11drivers/gpu/drm/i915/intel_device_info.c drivers/gpu/drm/i915/intel_display.h+7 -10 replies
9/15drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v2.drivers/gpu/drm/i915/intel_atomic_plane.c drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h +1 more+210 -190 replies
10/15drm/i915/gen11: Handle watermarks correctly for separate Y/UV planes.drivers/gpu/drm/i915/intel_pm.c+72 -500 replies
11/15drm/i915: Move programming plane scaler to its own function.drivers/gpu/drm/i915/intel_sprite.c+52 -380 replies
12/15drm/i915/gen11: Program the scalers correctly for planar formats.drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_atomic.c drivers/gpu/drm/i915/intel_display.c +2 more+34 -150 replies
13/15drm/i915/gen11: Program the chroma upsampler for HDR planes.drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_sprite.c+44 -00 replies
14/15drm/i915/gen11: Program the Y and UV plane for planar mode correctly.drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_sprite.c+38 -130 replies
15/15drm/i915/gen11: Expose planar format support on gen11.drivers/gpu/drm/i915/intel_display.c+9 -70 replies

Reviews trailers per patch

3 of 15 patches have a Reviewed-by or Acked-by.

PatchMatt Roper
1/15R-b
2/15
3/15R-b
4/15R-b
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] drm/i915/gen11: Implement planar format support.

Gen11 has to program 2 planes to enable planar formats. One scans out the Y plane, the other the UV plane.

The UV plane is the plane that matters for Z-order and performs color correction etc. The Y plane is always sprite 4 or 5, and only feeds Y pixels directly to the chroma upsampler on the UV plane, which will convert it to YUV444 that will be processed further without scaler. If there's no chroma upsampler on a plane, it will be done by a scaler, which needs to know the Y plane to take pixels from.

Maarten Lankhorst (15):
drm/i915: Clean up casts to crtc_state in intel_atomic_commit_tail() drm/i915: Handle cursor updating active_planes correctly. drm/i915: Make intel_crtc_disable_planes() use active planes mask. drm/i915: Replace call to commit_planes_on_crtc with internal update,

    v2.

drm/i915: Clean up scaler setup.
drm/i915: Force NV12 coordinates to be a multiple of 2 drm/i915: Unconditionally clear plane_state->visible flag drm/i915/gen11: Enable 6 sprites on gen11
drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v2. drm/i915/gen11: Handle watermarks correctly for separate Y/UV planes. drm/i915: Move programming plane scaler to its own function. drm/i915/gen11: Program the scalers correctly for planar formats. drm/i915/gen11: Program the chroma upsampler for HDR planes. drm/i915/gen11: Program the Y and UV plane for planar mode correctly. drm/i915/gen11: Expose planar format support on gen11.

 drivers/gpu/drm/i915/i915_reg.h           |  32 +++-
 drivers/gpu/drm/i915/intel_atomic.c       | 112 +++++++-----
 drivers/gpu/drm/i915/intel_atomic_plane.c | 155 ++++++++++++-----
 drivers/gpu/drm/i915/intel_device_info.c  |   5 +-
 drivers/gpu/drm/i915/intel_display.c      | 200 ++++++++++++++++------
 drivers/gpu/drm/i915/intel_display.h      |   3 +
 drivers/gpu/drm/i915/intel_drv.h          |  65 +++++++
 drivers/gpu/drm/i915/intel_pm.c           | 134 +++++++++------
 drivers/gpu/drm/i915/intel_sprite.c       | 161 +++++++++++------
 9 files changed, 618 insertions(+), 249 deletions(-)
Signature · 6 lines
2.18.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx