Skip to content

Add CPU clock support for Armada 7K/8K

Gregory CLEMENT linux-arm-kernel linux-clk linux-devicetree lkml 8 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest6 patches 6 repliesApplied
  2. v66 patches 2 repliesSuperseded
  3. v5 posting 2/26 patches 2 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v5 posting 1/26 patches0 repliesSuperseded
v46 patches3 repliesSuperseded
v36 patches6 repliesSuperseded
v25 patches2 repliesSuperseded
v16 patches13 repliesSuperseded

Changes in v7 from the cover letter

- Update binding documentation for the AP clock to mention that they expose reference clocks for the cluster to make distinction with the cluster clocks themselves exposed by the cpu clock.

- Add precision on the number of parent clock in the binding documentation.

- Also fix the example by using the reg address in the node name.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/6dt-bindings: ap806: add the cluster clock node in the syscon fileDocumentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt+29 -22 replies
2/6clk: mvebu: add helper file for Armada AP and CP clocksdrivers/clk/mvebu/Kconfig drivers/clk/mvebu/Makefile drivers/clk/mvebu/ap806-system-controller.c +3 more+61 -421 reply
3/6clk: mvebu: add CPU clock driver for Armada 7K/8Kdrivers/clk/mvebu/Kconfig drivers/clk/mvebu/Makefile drivers/clk/mvebu/ap-cpu-clk.c+263 -01 reply
4/6clk: mvebu: ap806: Fix clock name for the clusterdrivers/clk/mvebu/ap806-system-controller.c+2 -21 reply
5/6arm64: marvell: enable the Armada 7K/8K CPU clk driverarch/arm64/Kconfig.platforms+1 -00 replies
6/6arm64: dts: marvell: Add cpu clock node on Armada 7K/8Karch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi arch/arm64/boot/dts/marvell/armada-ap806.dtsi+11 -01 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/6R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/6] Add CPU clock support for Armada 7K/8K

Hello,

This is the seventh version of a series allowing to manage the cpu clock for Armada 7K/8K.

For these SoCs, the CPUs share the same clock by cluster, so actually the clock management is done at cluster level.

As for the other Armada 7K/8K clocks it is possible to have multiple AP so here again we need to have unique name: the purpose of the second patch is to share a common code which will be used in 3 drivers.

The last 2 patch enable the driver at dt and platform level and will be applied through the mvebu subsystem.

Changelog v6->v7:

- Update binding documentation for the AP clock to mention that they expose reference clocks for the cluster to make distinction with the cluster clocks themselves exposed by the cpu clock.

- Add precision on the number of parent clock in the binding documentation.

- Also fix the example by using the reg address in the node name.

Changelog v5->v6:

- Restraint the reg property for the child node to not overlap the other node.
- Give a specific compatible to ap_syscon1.

Changelog v4->v5:

- As requested by the device tree maintainer make the reg property mandatory

- Updated the device tree files accordingly with the new binding

Changelog v3->v4:
- Rebased on v5.1-rc1
- Mention in the binding that a reg property can be used to make the device tree maintainer happy in the hope that there will be finally a review on this patch blocking the whole series.

Changelog v2->v3:
- Add back the first patch documenting the binding

Changelog v1->v2:
- Header cleanup
- Use unsigned int instead of it for cluster member of the ap_cpu_clk struct
- Use clk_hw instead of clk
- Use regmap_read_poll_timeout
- Use for_each_of_cpu_node
- Remove unnecessary WARN_ON()
- Remove headers from armada_ap_cp_helper.h
- Few other minor cleanup

Gregory CLEMENT (6):
dt-bindings: ap806: add the cluster clock node in the syscon file
clk: mvebu: add helper file for Armada AP and CP clocks
clk: mvebu: add CPU clock driver for Armada 7K/8K
clk: mvebu: ap806: Fix clock name for the cluster
arm64: marvell: enable the Armada 7K/8K CPU clk driver
arm64: dts: marvell: Add cpu clock node on Armada 7K/8K

 .../arm/marvell/ap806-system-controller.txt   |  31 ++-
 arch/arm64/Kconfig.platforms                  |   1 +
 .../boot/dts/marvell/armada-ap806-quad.dtsi   |   4 +
 arch/arm64/boot/dts/marvell/armada-ap806.dtsi |   7 +
 drivers/clk/mvebu/Kconfig                     |   8 +
 drivers/clk/mvebu/Makefile                    |   2 +
 drivers/clk/mvebu/ap-cpu-clk.c                | 259 ++++++++++++++++++
 drivers/clk/mvebu/ap806-system-controller.c   |  24 +-
 drivers/clk/mvebu/armada_ap_cp_helper.c       |  30 ++
 drivers/clk/mvebu/armada_ap_cp_helper.h       |  11 +
 drivers/clk/mvebu/cp110-system-controller.c   |  32 +--
 11 files changed, 365 insertions(+), 44 deletions(-)
 create mode 100644 drivers/clk/mvebu/ap-cpu-clk.c
 create mode 100644 drivers/clk/mvebu/armada_ap_cp_helper.c
 create mode 100644 drivers/clk/mvebu/armada_ap_cp_helper.h
Signature · 1 line
2.20.1