Skip to content

cutils: Cleanup, improve documentation

Philippe Mathieu-Daudé qemu-devel qemu-riscv qemu-trivial 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 6 repliesIn review
  2. v23 patches 16 repliesApplied
  3. v13 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Fixed RISC-V (Laurent)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"include/qemu-common.h include/qemu/cutils.h qapi/string-output-visitor.c +1 more+14 -80 replies
2/3util/cutils: Move ctype macros to "cutils.h"hw/core/bus.c hw/core/qdev-properties.c hw/s390x/s390-virtio-ccw.c +10 more+34 -222 replies
3/3util/cutils: Move function documentations to the headerinclude/qemu/cutils.h util/cutils.c+224 -1854 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric BlakeDavid GibsonStefano GarzarellaCornelia Huck
1/3R-b R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/3] cutils: Cleanup, improve documentation

This series is a fairly trivial cleanup of "cutils.h" (size_to_str() and ctype macros moved into it), and some documentation improvements.

Since v2:
- Fixed RISC-V (Laurent)

Since v1:
- Fixed checkpatch errors (patchew)
- Added Stefano R-b

$ git backport-diff -u v2
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[----] [--] 'util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"' 002/3:[0001] [FC] 'util/cutils: Move ctype macros to "cutils.h"' 003/3:[----] [--] 'util/cutils: Move function documentations to the header'

v2: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00629.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg05927.html

Regards,

Phil.

Philippe Mathieu-Daudé (3):
util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h" util/cutils: Move ctype macros to "cutils.h" util/cutils: Move function documentations to the header

 hw/core/bus.c                |   2 +-
 hw/core/qdev-properties.c    |   1 +
 hw/s390x/s390-virtio-ccw.c   |   1 +
 hw/scsi/scsi-generic.c       |   2 +-
 include/qemu-common.h        |  17 ---
 include/qemu/cutils.h        | 262 +++++++++++++++++++++++++++++++++++
 qapi/qapi-util.c             |   2 +-
 qapi/string-output-visitor.c |   2 +-
 qobject/json-parser.c        |   1 -
 target/ppc/monitor.c         |   1 +
 target/riscv/cpu.c           |   1 +
 ui/keymaps.c                 |   1 +
 util/cutils.c                | 191 -------------------------
 util/id.c                    |   2 +-
 util/readline.c              |   1 -
 15 files changed, 272 insertions(+), 215 deletions(-)
Signature · 1 line
2.20.1