Skip to content

Fixes to kms_addfb_basic + RFC IGT buf alloc

Deepak Rawat igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3igt/kms_addfb_basic: Call dumb destroy in case have dumb buffertests/kms_addfb_basic.c+52 -180 replies
2/3igt/kms_addfb_basic: Call igt_require_gem for gem specific tilingtests/kms_addfb_basic.c+8 -06 replies
3/3igt/kms_addfb_basic: Add missing calls to gem_closetests/kms_addfb_basic.c+11 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/3] Fixes to kms_addfb_basic + RFC IGT buf alloc

Hi,

Sending a few fixes to kms_addfb_basic which are mainly for vmwgfx to run without error. These are really shortsighted fix and with this I would like to get feedback from community regarding BO allocation for drivers like vmwgfx which have private IOCTL for allocation. My end goal is to add vmwgfx BO support which creating igt_fb.

Currently igt_fb is somewhat tied to handle. I didn't looked into much detail but my fist thought was to separate out handle, is_dumb, etc from igt_fb and have a separate struct for BO. Similarly distinct API for BO create/destroy. Or is this unnecessary and simply adding a new API igt_destroy_bo should be enough to solve problems where igt_create_bo_with_dimensions() was used.

I would like to know if anyone else looked into this or it's in their TODO list.

Thanks,
Deepak

Deepak Rawat (3):
igt/kms_addfb_basic: Call dumb destroy in case have dumb buffer igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling igt/kms_addfb_basic: Add missing calls to gem_close

 tests/kms_addfb_basic.c | 91 ++++++++++++++++++++++++++++++++---------
 1 file changed, 71 insertions(+), 20 deletions(-)
Signature · 6 lines
2.17.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev