Skip to contentSkip to conversation

Fixes to kms_addfb_basic + RFC IGT buf alloc

PATCH In review Deepak Rawat 3 participants 12 messages Jan 16, 2019

lore
Share & tools
lore

Deepak Rawat

author
#0 lore raw

cover Fixes to kms_addfb_basic + RFC IGT buf alloc

Hi,

Sending a few fixes to kms_addfb_basic which are mainly for vmwgfx to run without error. These are really shortsighted fix and with this I would like to get feedback from community regarding BO allocation for drivers like vmwgfx which have private IOCTL for allocation. My end goal is to add vmwgfx BO support which creating igt_fb.

Currently igt_fb is somewhat tied to handle. I didn't looked into much detail but my fist thought was to separate out handle, is_dumb, etc from igt_fb and have a separate struct for BO. Similarly distinct API for BO create/destroy. Or is this unnecessary and simply adding a new API igt_destroy_bo should be enough to solve problems where igt_create_bo_with_dimensions() was used.

I would like to know if anyone else looked into this or it's in their TODO list.

Thanks,
Deepak

Deepak Rawat (3):
igt/kms_addfb_basic: Call dumb destroy in case have dumb buffer igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling igt/kms_addfb_basic: Add missing calls to gem_close

 tests/kms_addfb_basic.c | 91 ++++++++++++++++++++++++++++++++---------
 1 file changed, 71 insertions(+), 20 deletions(-)
Signature · 6 lines
2.17.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#1 lore raw

PATCH 1/3 igt/kms_addfb_basic: Call dumb destroy in case have dumb buffer

Drivers not necessarily support GEM interface to destroy dumb buffer, so call DRM_IOCTL_MODE_DESTROY_DUMB in case bo is a dumb buffer.

Signed-off-by Deepak Rawat <[email protected]>
---
 tests/kms_addfb_basic.c | 70 ++++++++++++++++++++++++++++++-----------
 1 file changed, 52 insertions(+), 18 deletions(-)
tests/kms_addfb_basic.c +52 -18
index 400241a9..47dce2d4 100644
@@ -70,6 +70,7 @@ static int rmfb(int fd, uint32_t id)
 static void invalid_tests(int fd)
 {
 	struct local_drm_mode_fb_cmd2 f = {};
+	bool is_dumb = false;
 
 	f.width = 512;
 	f.height = 512;

@@ -78,7 +79,7 @@ static void invalid_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
 			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);

@@ -242,8 +243,13 @@ static void invalid_tests(int fd)
 	}
 
 	igt_fixture {
-		gem_close(fd, gem_bo);
-		gem_close(fd, gem_bo_small);
+		if (is_dumb) {
+			kmstest_dumb_destroy(fd, gem_bo);
+			kmstest_dumb_destroy(fd, gem_bo_small);
+		} else {
+			gem_close(fd, gem_bo);
+			gem_close(fd, gem_bo_small);
+		}
 	}
 }
 

@@ -251,6 +257,7 @@ static void pitch_tests(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
 	int bad_pitches[] = { 0, 32, 63, 128, 256, 256*4, 999, 64*1024 };
+	bool is_dumb = false;
 	int i;
 
 	f.width = 512;

@@ -260,7 +267,7 @@ static void pitch_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 	}
 

@@ -284,8 +291,12 @@ static void pitch_tests(int fd)
 		}
 	}
 
-	igt_fixture
-		gem_close(fd, gem_bo);
+	igt_fixture {
+		if (is_dumb)
+			kmstest_dumb_destroy(fd, gem_bo);
+		else
+			gem_close(fd, gem_bo);
+	}
 }
 
 static void tiling_tests(int fd)

@@ -293,6 +304,7 @@ static void tiling_tests(int fd)
 	struct drm_mode_fb_cmd2 f = {};
 	uint32_t tiled_x_bo = 0;
 	uint32_t tiled_y_bo = 0;
+	bool is_dumb = false;
 
 	f.width = 512;
 	f.height = 512;

@@ -303,7 +315,7 @@ static void tiling_tests(int fd)
 		igt_fixture {
 			tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
 				DRM_FORMAT_XRGB8888, LOCAL_I915_FORMAT_MOD_X_TILED,
-				1024*4, NULL, NULL, NULL);
+				1024*4, NULL, NULL, &is_dumb);
 			igt_assert(tiled_x_bo);
 
 			tiled_y_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,

@@ -353,8 +365,13 @@ static void tiling_tests(int fd)
 		}
 
 		igt_fixture {
-			gem_close(fd, tiled_x_bo);
-			gem_close(fd, tiled_y_bo);
+			if (is_dumb) {
+				kmstest_dumb_destroy(fd, tiled_x_bo);
+				kmstest_dumb_destroy(fd, tiled_y_bo);
+			} else {
+				gem_close(fd, tiled_x_bo);
+				gem_close(fd, tiled_y_bo);
+			}
 		}
 	}
 }

@@ -364,6 +381,7 @@ static void size_tests(int fd)
 	struct drm_mode_fb_cmd2 f = {};
 	struct drm_mode_fb_cmd2 f_16 = {};
 	struct drm_mode_fb_cmd2 f_8 = {};
+	bool is_dumb = false;
 
 	f.width = 1024;
 	f.height = 1024;

@@ -382,7 +400,7 @@ static void size_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
 			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);

@@ -453,18 +471,24 @@ static void size_tests(int fd)
 
 
 	igt_fixture {
-		gem_close(fd, gem_bo);
-		gem_close(fd, gem_bo_small);
+		if (is_dumb) {
+			kmstest_dumb_destroy(fd, gem_bo);
+			kmstest_dumb_destroy(fd, gem_bo_small);
+		} else {
+			gem_close(fd, gem_bo);
+			gem_close(fd, gem_bo_small);
+		}
 	}
 }
 
 static void addfb25_tests(int fd)
 {
 	struct local_drm_mode_fb_cmd2 f = {};
+	bool is_dumb = false;
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 
 		memset(&f, 0, sizeof(f));

@@ -522,8 +546,12 @@ static void addfb25_tests(int fd)
 			f.fb_id = 0;
 		}
 	}
-	igt_fixture
-		gem_close(fd, gem_bo);
+	igt_fixture {
+		if (is_dumb)
+			kmstest_dumb_destroy(fd, gem_bo);
+		else
+			gem_close(fd, gem_bo);
+	}
 }
 
 static int addfb_expected_ret(int fd)

@@ -540,11 +568,12 @@ static int addfb_expected_ret(int fd)
 static void addfb25_ytile(int fd)
 {
 	struct local_drm_mode_fb_cmd2 f = {};
+	bool is_dumb = false;
 	int gen;
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
 			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);

@@ -598,8 +627,13 @@ static void addfb25_ytile(int fd)
 	}
 
 	igt_fixture {
-		gem_close(fd, gem_bo);
-		gem_close(fd, gem_bo_small);
+		if (is_dumb) {
+			kmstest_dumb_destroy(fd, gem_bo);
+			kmstest_dumb_destroy(fd, gem_bo_small);
+		} else {
+			gem_close(fd, gem_bo);
+			gem_close(fd, gem_bo_small);
+		}
 	}
 }
Signature · 6 lines
2.17.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#2 lore raw

PATCH 2/3 igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

In reply to Deepak Rawat

For tests using gem specific buffer tiling, add a call to igt_require_gem so that these tests don't fail at later stage.

Signed-off-by Deepak Rawat <[email protected]>
---
 tests/kms_addfb_basic.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/kms_addfb_basic.c +8 -0
index 47dce2d4..9c4c2c4d 100644
@@ -131,6 +131,8 @@ static void invalid_tests(int fd)
 	}
 
 	igt_subtest("clobberred-modifier") {
+		igt_require_gem(fd);
+
 		f.flags = 0;
 		f.modifier[0] = 0;
 		gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);

@@ -313,6 +315,8 @@ static void tiling_tests(int fd)
 
 	igt_subtest_group {
 		igt_fixture {
+			igt_require_gem(fd);
+
 			tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
 				DRM_FORMAT_XRGB8888, LOCAL_I915_FORMAT_MOD_X_TILED,
 				1024*4, NULL, NULL, &is_dumb);

@@ -464,6 +468,8 @@ static void size_tests(int fd)
 	}
 
 	igt_subtest("bo-too-small-due-to-tiling") {
+		igt_require_gem(fd);
+
 		gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
 			   errno == EINVAL);

@@ -521,6 +527,8 @@ static void addfb25_tests(int fd)
 
 	igt_subtest_group {
 		igt_fixture {
+			igt_require_gem(fd);
+
 			gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
 			igt_require_fb_modifiers(fd);
 		}
Signature · 6 lines
2.17.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#3 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

Quoting Deepak Rawat (2019-01-16 00:22:29)

Quoted 2 lines

For tests using gem specific buffer tiling, add a call to igt_require_gem so that these tests don't fail at later stage.

KMS operates independently from GEM on i915. So long as you are not calling gem_execbuf, it should continue to work even if we disable the GPU, i.e. igt_require_gem() should not be required here (afaik). -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

Quoted 9 lines · Chris Wilson

Quoting Deepak Rawat (2019-01-16 00:22:29)

Quoted 2 lines

For tests using gem specific buffer tiling, add a call to igt_require_gem so that these tests don't fail at later stage.

KMS operates independently from GEM on i915. So long as you are not calling gem_execbuf, it should continue to work even if we disable the
GPU, i.e. igt_require_gem() should not be required here (afaik). -Chris

gem_set_tiling() calls an i915 private IOCTL which I think would fail when GEM is disabled or on other drivers. So I guess either have a igt_require_gem() or perhaps GEM specific private IOCTL calls SKIP on other drivers.

Deepak

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

Quoting Deepak Singh Rawat (2019-01-16 16:11:16)

Quoted 11 lines · Chris Wilson
Quoted 9 lines

Quoting Deepak Rawat (2019-01-16 00:22:29)

Quoted 2 lines

For tests using gem specific buffer tiling, add a call to igt_require_gem so that these tests don't fail at later stage.

KMS operates independently from GEM on i915. So long as you are not calling gem_execbuf, it should continue to work even if we disable the
GPU, i.e. igt_require_gem() should not be required here (afaik). -Chris

Quoted 4 lines

gem_set_tiling() calls an i915 private IOCTL which I think would fail when GEM is disabled or on other drivers. So I guess either have a igt_require_gem() or perhaps GEM specific private IOCTL calls SKIP on other drivers.

Ah, you want igt_require(is_i915_device(fd)), or introduce something like igt_require_i915(fd). Even better if such specifics are removed, or moved to a subtest group that are clearly device specific. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#6 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

Quoted 21 lines · Chris Wilson

Quoting Deepak Singh Rawat (2019-01-16 16:11:16)

Quoted 13 lines · Chris Wilson
Quoted 11 lines

Quoting Deepak Rawat (2019-01-16 00:22:29)

Quoted 2 lines

For tests using gem specific buffer tiling, add a call to igt_require_gem so that these tests don't fail at later stage.

KMS operates independently from GEM on i915. So long as you are not
calling gem_execbuf, it should continue to work even if we disable
the
GPU, i.e. igt_require_gem() should not be required here (afaik). -Chris

Quoted 6 lines

gem_set_tiling() calls an i915 private IOCTL which I think would fail
when GEM is disabled or on other drivers. So I guess either have a igt_require_gem() or perhaps GEM specific private IOCTL calls SKIP on
other drivers.

Quoted 5 lines

Ah, you want igt_require(is_i915_device(fd)), or introduce something like igt_require_i915(fd). Even better if such specifics are removed, or
moved to a subtest group that are clearly device specific. -Chris

I am not sure if i915 and GEM are independent of each other but yes you are right about kms_addfb_basic.c should not have device/GEM specific requires. Perhaps the better way would be something like (instead of gem_set_tiling()):

set_tiling() -> device_specific_tiling()

Also set_tiling() wrapper SKIP's for drivers which do not support tiling, which for now applies to all except i915.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

Quoting Deepak Singh Rawat (2019-01-16 16:34:39)

Quoted 33 lines · Chris Wilson
Quoted 21 lines

Quoting Deepak Singh Rawat (2019-01-16 16:11:16)

Quoted 13 lines · Chris Wilson
Quoted 11 lines

Quoting Deepak Rawat (2019-01-16 00:22:29)

Quoted 2 lines

For tests using gem specific buffer tiling, add a call to igt_require_gem so that these tests don't fail at later stage.

KMS operates independently from GEM on i915. So long as you are not
calling gem_execbuf, it should continue to work even if we disable
the
GPU, i.e. igt_require_gem() should not be required here (afaik). -Chris

Quoted 6 lines

gem_set_tiling() calls an i915 private IOCTL which I think would fail
when GEM is disabled or on other drivers. So I guess either have a igt_require_gem() or perhaps GEM specific private IOCTL calls SKIP on
other drivers.

Quoted 5 lines

Ah, you want igt_require(is_i915_device(fd)), or introduce something like igt_require_i915(fd). Even better if such specifics are removed, or
moved to a subtest group that are clearly device specific. -Chris

I am not sure if i915 and GEM are independent of each other but yes you are right about kms_addfb_basic.c should not have device/GEM specific requires. Perhaps the better way would be something like (instead of gem_set_tiling()):

Quoted 4 lines

set_tiling() -> device_specific_tiling()

Also set_tiling() wrapper SKIP's for drivers which do not support tiling, which for now applies to all except i915.

It's not just testing a backend tiling format, but also the corresponding I915_FORMAT_MOD. It won't generalise more than a starting point for testing other backend specific DRM_FORMAT_MODIFIERS.

That addfb_expected_ret() is bogus. A different backend may reuse the same value as I915_FORMAT_MOD_Y_TILED for a completely different purpose, that ends up being valid for the given addfb.

My reading is addfb25_tests(); addfb25_ytile(); tiling_tests(); are all i915-specific and should be placed in an i915 subtest group. And that we should try to extract the (one?) generic addfb25 tests. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#8 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

Quoted 9 lines · Chris Wilson

It's not just testing a backend tiling format, but also the corresponding I915_FORMAT_MOD. It won't generalise more than a starting
point for testing other backend specific DRM_FORMAT_MODIFIERS.

That addfb_expected_ret() is bogus. A different backend may reuse the same value as I915_FORMAT_MOD_Y_TILED for a completely different purpose, that ends up being valid for the given addfb.

Quoted 6 lines

My reading is addfb25_tests(); addfb25_ytile(); tiling_tests(); are all
i915-specific and should be placed in an i915 subtest group. And that we
should try to extract the (one?) generic addfb25 tests. -Chris

Thanks for the explanation. I agree.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#9 lore raw

PATCH 3/3 igt/kms_addfb_basic: Add missing calls to gem_close

In reply to Deepak Rawat

Few gem_close calls were missing add them.

Signed-off-by Deepak Rawat <[email protected]>
---
 tests/kms_addfb_basic.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
tests/kms_addfb_basic.c +11 -2
index 9c4c2c4d..dd948ca8 100644
@@ -372,9 +372,11 @@ static void tiling_tests(int fd)
 			if (is_dumb) {
 				kmstest_dumb_destroy(fd, tiled_x_bo);
 				kmstest_dumb_destroy(fd, tiled_y_bo);
+				kmstest_dumb_destroy(fd, gem_bo);
 			} else {
 				gem_close(fd, tiled_x_bo);
 				gem_close(fd, tiled_y_bo);
+				gem_close(fd, gem_bo);
 			}
 		}
 	}

@@ -651,6 +653,7 @@ static void prop_tests(int fd)
 	struct drm_mode_obj_get_properties get_props = {};
 	struct drm_mode_obj_set_property set_prop = {};
 	uint64_t prop, prop_val;
+	bool is_dumb = false;
 
 	f.width = 1024;
 	f.height = 1024;

@@ -659,7 +662,7 @@ static void prop_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 
 		f.handles[0] = gem_bo;

@@ -704,8 +707,14 @@ static void prop_tests(int fd)
 				    &set_prop) == -1 && errno == EINVAL);
 	}
 
-	igt_fixture
+	igt_fixture {
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
+		if (is_dumb) {
+			kmstest_dumb_destroy(fd, gem_bo);
+		} else {
+			gem_close(fd, gem_bo);
+		}
+	}
 
 }
Signature · 6 lines
2.17.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
CI
#10 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Fixes to kms_addfb_basic + RFC IGT buf alloc

In reply to Deepak Rawat
== Series Details ==

== Series Details ==

Series: Fixes to kms_addfb_basic + RFC IGT buf alloc
URL : https://patchwork.freedesktop.org/series/55270/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5430 -> IGTPW_2243
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/55270/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2243 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
- fi-skl-iommu: PASS -> INCOMPLETE [fdo#108602] / [fdo#108744]

* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bwr-2160: PASS -> FAIL [fdo#100368]

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]

* igt@prime_vgem@basic-fence-flip:
- fi-skl-6260u: PASS -> FAIL [fdo#104008]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278

Participating hosts (46 -> 43)
------------------------------

Additional (2): fi-icl-y fi-byt-clapper
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-glk-j4005

Build changes
-------------

* IGT: IGT_4773 -> IGTPW_2243

CI_DRM_5430: 19fd97ec0d642516406be0e69280b2136f5399e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2243: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2243/
IGT_4773: 951e2b1a016b750544d0f42459b13b9c70631c68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2243/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

CI
#11 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for Fixes to kms_addfb_basic + RFC IGT buf alloc

In reply to Deepak Rawat
== Series Details ==

== Series Details ==

Series: Fixes to kms_addfb_basic + RFC IGT buf alloc
URL : https://patchwork.freedesktop.org/series/55270/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5430_full -> IGTPW_2243_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/55270/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2243_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@in-flight-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] / [fdo#106702]

* igt@gem_exec_schedule@pi-ringfull-render:
- shard-apl: NOTRUN -> FAIL [fdo#103158]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +1

* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> FAIL [fdo#108597] +1
- shard-apl: NOTRUN -> FAIL [fdo#108597] +1

* igt@kms_cursor_crc@cursor-256x256-random:

    - shard-glk:          PASS -> FAIL [fdo#103232] +1
    - shard-apl:          PASS -> FAIL [fdo#103232]
    - shard-kbl:          PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x21-random:

    - shard-apl:          NOTRUN -> FAIL [fdo#103232]
    - shard-kbl:          NOTRUN -> FAIL [fdo#103232]
    - shard-glk:          NOTRUN -> FAIL [fdo#103232]

* igt@kms_flip@dpms-vs-vblank-race:
- shard-glk: PASS -> FAIL [fdo#103060]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +1
- shard-glk: PASS -> FAIL [fdo#103167]

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] +1
- shard-apl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-kbl: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-glk: NOTRUN -> FAIL [fdo#103166]

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]

* igt@perf_pmu@rc6-runtime-pm-long:
- shard-glk: PASS -> FAIL [fdo#105010]

#### Possible fixes ####

* igt@gem_softpin@noreloc-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS +1

* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-128x42-random:

    - shard-glk:          FAIL [fdo#103232] -> PASS +2
    - shard-apl:          FAIL [fdo#103232] -> PASS +1
    - shard-kbl:          FAIL [fdo#103232] -> PASS

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: FAIL [fdo#105767] -> PASS

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS

* igt@kms_flip@dpms-off-confusion:
- shard-apl: {SKIP} [fdo#109271] -> PASS +4

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-kbl: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +5

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- shard-apl: {SKIP} [fdo#109271] / [fdo#109278] -> PASS +3

* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-kbl: FAIL [fdo#103166] -> PASS +1

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS

* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS

* igt@perf_pmu@busy-idle-check-all-bcs0:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS

* igt@prime_vgem@basic-fence-flip:
- shard-kbl: DMESG-WARN [fdo#103313] / [fdo#105345] -> PASS

* igt@sw_sync@sync_busy_fork_unixsocket:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

#### Warnings ####

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-apl: {SKIP} [fdo#109271] / [fdo#109278] -> FAIL [fdo#108145]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105345]: https://bugs.freedesktop.org/show_bug.cgi?id=105345
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106702]: https://bugs.freedesktop.org/show_bug.cgi?id=106702
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4773 -> IGTPW_2243
* Piglit: piglit_4509 -> None

CI_DRM_5430: 19fd97ec0d642516406be0e69280b2136f5399e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2243: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2243/
IGT_4773: 951e2b1a016b750544d0f42459b13b9c70631c68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2243/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev