Network announce changes
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest9 patches 1 replyApplied
- v59 patches 5 repliesSuperseded
- v49 patches 0 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 9 patches | 4 replies | Applied | |
| v2 | 9 patches | 7 replies | Superseded | |
| v1 | 9 patches | 14 replies | Superseded |
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | net: Introduce announce timerinclude/ include/ migration/ +3 more | +125 | 0 replies | |
| 2/9 | migration: Add announce parametershmp.c include/ migration/ +1 more | +180 | 0 replies | |
| 3/9 | virtio-net: Switch to using announce timerhw/ hw/ include/ | +30 | 0 replies | |
| 4/9 | migration: Switch to using announce timerinclude/ include/ include/ +6 more | +81 | 0 replies | |
| 5/9 | net: Add a network device specific self-announcement abilityinclude/ net/ | +7 | 0 replies | |
| 6/9 | virtio-net: Allow qemu_announce_self to trigger virtio announcementshw/ hw/ | +33 | 0 replies | |
| 7/9 | qmp: Add announce-self commandnet/ qapi/ | +27 | 0 replies | |
| 8/9 | hmp: Add hmp_announce_selfhmp-commands.hx hmp.c hmp.h +1 more | +23 | 0 replies | |
| 9/9 | tests: Add a test for qemu self announcementstests/ tests/ | +85 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Michael S. Tsirkin | Vladislav Yasevich | Markus Armbruster |
|---|---|---|---|
| 1/9 | R-b | ||
| 2/9 | R-b | A-b | |
| 3/9 | R-b | ||
| 4/9 | R-b | ||
| 5/9 | R-b | ||
| 6/9 | R-b | ||
| 7/9 | R-b | ||
| 8/9 | R-b | Signend-off-by | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v6 0/9] Network announce changes
From: "Dr. David Alan Gilbert" <[email protected]>
Hi,
This is a reworking of a few sets of patches from 2017
that were put together by myself, Germano and Vlad that make the network announce system more flexible.
Firstly, it's parameterised, so that you can change the number
of packets and the gap between them; the number can be set to 0 to disable announce completely.
Secondly, you can force an announce by a qmp or hmp command at
any time. This is useful if you need the guest to do an announce for a different reason; for example if the management layer has just juggled some bonding configuration around.
The packet creation and timing also moves to net/ from migration/
The previous set was:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05594.html
Dave
v6
qmp format change (from Markus's review) removed gcov line from test (from Thomas's review) slightly expanded HMP help text (from Thomas's review)
Dr. David Alan Gilbert (9):
net: Introduce announce timer
migration: Add announce parameters
virtio-net: Switch to using announce timer
migration: Switch to using announce timer
net: Add a network device specific self-announcement ability
virtio-net: Allow qemu_announce_self to trigger virtio announcements
qmp: Add announce-self command
hmp: Add hmp_announce_self
tests: Add a test for qemu self announcements
hmp-commands.hx | 16 ++++ hmp.c | 33 ++++++++ hmp.h | 1 + hw/net/trace-events | 6 ++ hw/net/virtio-net.c | 69 ++++++++++++---- include/hw/virtio/virtio-net.h | 4 +- include/migration/misc.h | 12 +-- include/net/announce.h | 41 ++++++++++ include/net/net.h | 2 + include/qemu/typedefs.h | 1 + include/sysemu/sysemu.h | 2 - migration/migration.c | 103 +++++++++++++++++++++++- migration/migration.h | 4 + migration/savevm.c | 72 +---------------- migration/trace-events | 1 - net/Makefile.objs | 1 + net/announce.c | 140 +++++++++++++++++++++++++++++++++ net/trace-events | 3 + qapi/migration.json | 53 ++++++++++++- qapi/net.json | 43 ++++++++++ tests/Makefile.include | 3 + tests/test-announce-self.c | 82 +++++++++++++++++++ tests/test-hmp.c | 1 + 23 files changed, 590 insertions(+), 103 deletions(-) create mode 100644 include/net/announce.h create mode 100644 net/announce.c create mode 100644 tests/test-announce-self.c
Signature · 1 line
2.20.1