Skip to content

genirq/affinity: Overhaul the multiple interrupt sets support

Thomas Gleixner linux-block linux-nvme linux-pci lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 13 repliesIn review
  2. v58 patches 6 repliesSuperseded

Changes in v6 from the cover letter

- Change the invocation for the driver callback so it is invoked even when there are no interrupts left to spread out. That ensures that the driver can adjust to the situation (in case of NVME a single interrupt)

- Make sure the callback is invoked in the legacy irq fallback case so the driver is not in a stale state from a failed MSI[X} allocation attempt.

- Fix the adjustment logic in the NVME driver as pointed out by Ming and Marc, plus another corner case I found during testing.

- Simplify the unmanaged set support

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7genirq/affinity: Code consolidationinclude/linux/interrupt.h kernel/irq/affinity.c+38 -381 reply
2/7genirq/affinity: Store interrupt sets size in struct irq_affinitydrivers/nvme/host/pci.c include/linux/interrupt.h kernel/irq/affinity.c+21 -110 replies
3/7genirq/affinity: Add new callback for (re)calculating interrupt setsdrivers/pci/msi.c drivers/scsi/be2iscsi/be_main.c include/linux/interrupt.h +2 more+71 -325 replies
4/7nvme-pci: Simplify interrupt allocationdrivers/nvme/host/pci.c+39 -770 replies
5/7genirq/affinity: Remove the leftovers of the original set supportkernel/irq/affinity.c+4 -161 reply
6/7PCI/MSI: Remove obsolete sanity checks for multiple interrupt setsdrivers/pci/msi.c+0 -141 reply
7/7genirq/affinity: Add support for non-managed affinity setsinclude/linux/interrupt.h kernel/irq/affinity.c+13 -54 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMing LeiMarc Zyngier
SeriesA-b
1/7R-b
2/7
3/7
4/7
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [patch v6 0/7] genirq/affinity: Overhaul the multiple interrupt sets support

This is the final update to the series with a few corner cases fixes vs. V5 which can be found here:

https://lkml.kernel.org/r/20190214204755.819014197 at linutronix.de

The series applies against:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master

and is also available from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.irq

Changes vs. V5:

- Change the invocation for the driver callback so it is invoked even when there are no interrupts left to spread out. That ensures that the driver can adjust to the situation (in case of NVME a single interrupt)

- Make sure the callback is invoked in the legacy irq fallback case so the driver is not in a stale state from a failed MSI[X} allocation attempt.

- Fix the adjustment logic in the NVME driver as pointed out by Ming and Marc, plus another corner case I found during testing.

- Simplify the unmanaged set support

Thanks,

tglx

8<-------------

 drivers/nvme/host/pci.c         |  117 +++++++++++++---------------------------
 drivers/pci/msi.c               |   39 +++++--------
 drivers/scsi/be2iscsi/be_main.c |    2 
 include/linux/interrupt.h       |   35 ++++++++---
 include/linux/pci.h             |    4 -
 kernel/irq/affinity.c           |  116 ++++++++++++++++++++++++---------------
 6 files changed, 153 insertions(+), 160 deletions(-)