Remove qdev_get_machine() call from ppc_cpu_parse_featurestr()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | cpu: Rename parse_cpu_model() to parse_cpu_option()bsd-user/ exec.c include/ +2 more | +16 | 2 replies | |
| 2/5 | cpu: Extract CPU class lookup from parse_cpu_option()exec.c include/ | +21 | 3 replies | |
| 3/5 | linux-user: Use lookup_cpu_class()linux-user/ | +3 | 2 replies | |
| 4/5 | bsd-user: Use lookup_cpu_class()bsd-user/ | +3 | 1 reply | |
| 5/5 | cpu: Add MachineState parameter to parse_features()exec.c include/ qom/ +5 more | +19 | 2 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Markus Armbruster | David Gibson | Igor Mammedov |
|---|---|---|---|
| Series | R-b | ||
| 1/5 | R-b | R-b | |
| 2/5 | R-b | ||
| 3/5 | R-b | ||
| 4/5 | R-b | ||
| 5/5 | R-b A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr()
My initial goal was simple: removing the qdev_get_machine() call from ppc_cpu_parse_featurestr() because I want to make qdev_get_machine() available only to softmmu code.
Before doing this, I had to make *-user not call CPUClass::parse_features() anymore (it was pointless to call it, anyway).
While doing this, I decided to rename parse_cpu_model() to something clearer (parse_cpu_option()).
As a nice side effect, now the dependency between machine object creation and parse_cpu_option() is not hidden anymore.
Eduardo Habkost (5):
cpu: Rename parse_cpu_model() to parse_cpu_option()
cpu: Extract CPU class lookup from parse_cpu_option()
linux-user: Use lookup_cpu_class()
bsd-user: Use lookup_cpu_class()
cpu: Add MachineState parameter to parse_features()
include/qom/cpu.h | 18 ++++++++++++++---- target/ppc/cpu-qom.h | 3 ++- bsd-user/main.c | 4 +++- exec.c | 28 +++++++++++++++------------- linux-user/main.c | 4 +++- qom/cpu.c | 3 ++- target/i386/cpu.c | 3 ++- target/ppc/translate_init.inc.c | 7 ++++--- target/sparc/cpu.c | 3 ++- vl.c | 19 ++++++++++--------- 10 files changed, 57 insertions(+), 35 deletions(-)
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140