Skip to content

Remove qdev_get_machine() call from ppc_cpu_parse_featurestr()

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cpu: Rename parse_cpu_model() to parse_cpu_option()bsd-user/main.c exec.c include/qom/cpu.h +2 more+16 -162 replies
2/5cpu: Extract CPU class lookup from parse_cpu_option()exec.c include/qom/cpu.h+21 -103 replies
3/5linux-user: Use lookup_cpu_class()linux-user/main.c+3 -12 replies
4/5bsd-user: Use lookup_cpu_class()bsd-user/main.c+3 -11 reply
5/5cpu: Add MachineState parameter to parse_features()exec.c include/qom/cpu.h qom/cpu.c +5 more+19 -122 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarkus ArmbrusterDavid GibsonIgor Mammedov
SeriesR-b
1/5R-b R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr()

My initial goal was simple: removing the qdev_get_machine() call from ppc_cpu_parse_featurestr() because I want to make qdev_get_machine() available only to softmmu code.

Before doing this, I had to make *-user not call CPUClass::parse_features() anymore (it was pointless to call it, anyway).

While doing this, I decided to rename parse_cpu_model() to something clearer (parse_cpu_option()).

As a nice side effect, now the dependency between machine object creation and parse_cpu_option() is not hidden anymore.

Eduardo Habkost (5):
cpu: Rename parse_cpu_model() to parse_cpu_option()
cpu: Extract CPU class lookup from parse_cpu_option()
linux-user: Use lookup_cpu_class()
bsd-user: Use lookup_cpu_class()
cpu: Add MachineState parameter to parse_features()

 include/qom/cpu.h               | 18 ++++++++++++++----
 target/ppc/cpu-qom.h            |  3 ++-
 bsd-user/main.c                 |  4 +++-
 exec.c                          | 28 +++++++++++++++-------------
 linux-user/main.c               |  4 +++-
 qom/cpu.c                       |  3 ++-
 target/i386/cpu.c               |  3 ++-
 target/ppc/translate_init.inc.c |  7 ++++---
 target/sparc/cpu.c              |  3 ++-
 vl.c                            | 19 ++++++++++---------
 10 files changed, 57 insertions(+), 35 deletions(-)
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140