Remove qdev_get_machine() call from ppc_cpu_parse_featurestr()
cover Remove qdev_get_machine() call from ppc_cpu_parse_featurestr()
My initial goal was simple: removing the qdev_get_machine() call from ppc_cpu_parse_featurestr() because I want to make qdev_get_machine() available only to softmmu code.
Before doing this, I had to make *-user not call CPUClass::parse_features() anymore (it was pointless to call it, anyway).
While doing this, I decided to rename parse_cpu_model() to something clearer (parse_cpu_option()).
As a nice side effect, now the dependency between machine object creation and parse_cpu_option() is not hidden anymore.
Eduardo Habkost (5):
cpu: Rename parse_cpu_model() to parse_cpu_option()
cpu: Extract CPU class lookup from parse_cpu_option()
linux-user: Use lookup_cpu_class()
bsd-user: Use lookup_cpu_class()
cpu: Add MachineState parameter to parse_features()
include/qom/cpu.h | 18 ++++++++++++++---- target/ppc/cpu-qom.h | 3 ++- bsd-user/main.c | 4 +++- exec.c | 28 +++++++++++++++------------- linux-user/main.c | 4 +++- qom/cpu.c | 3 ++- target/i386/cpu.c | 3 ++- target/ppc/translate_init.inc.c | 7 ++++--- target/sparc/cpu.c | 3 ++- vl.c | 19 ++++++++++--------- 10 files changed, 57 insertions(+), 35 deletions(-)
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
PATCH 1/5 cpu: Rename parse_cpu_model() to parse_cpu_option()
The "model[,option...]" string parsed by the function is not just a CPU model. Rename the function and its argument to indicate it expects the full "-cpu" option to be provided.
--- include/qom/cpu.h | 6 +++--- bsd-user/main.c | 2 +- exec.c | 4 ++-- linux-user/main.c | 2 +- vl.c | 18 +++++++++--------- 5 files changed, 16 insertions(+), 16 deletions(-)
include/qom/cpu.h +3 -3
@@ -689,15 +689,15 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model);CPUState *cpu_create (const char *typename);/** -* parse_cpu_model: -* @cpu_model: The model string including optional parameters. +* parse_cpu_option: +* @cpu_option: The -cpu option including optional parameters. * * processes optional parameters and registers them as global properties * * Returns: type of CPU to create or prints error and terminates process * if an error occurred. */ -const char *parse_cpu_model (const char *cpu_model); +const char *parse_cpu_option (const char *cpu_option);/** * cpu_has_work:
bsd-user/main.c +1 -1
@@ -903,7 +903,7 @@ int main(int argc, char **argv)/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 ); - cpu_type =parse_cpu_model (cpu_model); + cpu_type =parse_cpu_option (cpu_model); cpu =cpu_create (cpu_type); env = cpu->env_ptr;#if defined(TARGET_SPARC ) || defined(TARGET_PPC )
exec.c +2 -2
@@ -982,14 +982,14 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp)#endif } -const char *parse_cpu_model (const char *cpu_model) +const char *parse_cpu_option (const char *cpu_option) {ObjectClass *oc;CPUClass *cc;gchar **model_pieces;const char *cpu_type; - model_pieces =g_strsplit (cpu_model,"," ,2 ); + model_pieces =g_strsplit (cpu_option,"," ,2 ); oc =cpu_class_by_name (CPU_RESOLVING_TYPE , model_pieces[0 ]);if (oc ==NULL ) {
linux-user/main.c +1 -1
@@ -660,7 +660,7 @@ int main(int argc, char **argv, char **envp)if (cpu_model ==NULL ) { cpu_model =cpu_get_model (get_elf_eflags (execfd)); } - cpu_type =parse_cpu_model (cpu_model); + cpu_type =parse_cpu_option (cpu_model);/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 );
vl.c +9 -9
@@ -3002,7 +3002,7 @@ int main(int argc, char **argv, char **envp)const char *optarg;const char *loadvm =NULL ;MachineClass *machine_class; -const char *cpu_model; +const char *cpu_option;const char *vga_model =NULL ;const char *qtest_chrdev =NULL ;const char *qtest_log =NULL ;
@@ -3081,7 +3081,7 @@ int main(int argc, char **argv, char **envp)QLIST_INIT (&vm_change_state_head);os_setup_early_signal_handling (); - cpu_model =NULL ; + cpu_option =NULL ; snapshot =0 ; nb_nics =0 ;
@@ -3133,7 +3133,7 @@ int main(int argc, char **argv, char **envp)switch (popt->index) {case QEMU_OPTION_cpu:/* hw initialization will check this */ - cpu_model = optarg; + cpu_option = optarg;break ;case QEMU_OPTION_hda:case QEMU_OPTION_hdb:
@@ -4050,8 +4050,8 @@ int main(int argc, char **argv, char **envp)qemu_set_hw_version (machine_class->hw_version); } -if (cpu_model &&is_help_option (cpu_model)) { -list_cpus (stdout, &fprintf, cpu_model); +if (cpu_option &&is_help_option (cpu_option)) { +list_cpus (stdout, &fprintf, cpu_option);exit (0 ); }
@@ -4299,9 +4299,9 @@ int main(int argc, char **argv, char **envp)* Global properties get set up by qdev_prop_register_global(), * called from user_register_global_props(), and certain option * desugaring. Also in CPU feature desugaring (buried in -* parse_cpu_model()), which happens below this point, but may +* parse_cpu_option()), which happens below this point, but may * only target the CPU type, which can only be created after -* parse_cpu_model() returned the type. +* parse_cpu_option() returned the type. * * Machine compat properties: object_set_machine_compat_props(). * Accelerator compat props: object_set_accelerator_compat_props(),
@@ -4465,8 +4465,8 @@ int main(int argc, char **argv, char **envp)/* parse features once if machine provides default cpu_type */ current_machine->cpu_type = machine_class->default_cpu_type; -if (cpu_model) { - current_machine->cpu_type =parse_cpu_model (cpu_model); +if (cpu_option) { + current_machine->cpu_type =parse_cpu_option (cpu_option); }parse_numa_opts (current_machine);
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
Re: [Qemu-devel] [PATCH 1/5] cpu: Rename parse_cpu_model() to parse_cpu_option()
Quoted 5 lines · Eduardo Habkost
The "model[,option...]" string parsed by the function is not just a CPU model. Rename the function and its argument to indicate it expects the full "-cpu" option to be provided.
Signed-off-by Eduardo Habkost <[email protected]>
Quoted 143 lines
--- include/qom/cpu.h | 6 +++--- bsd-user/main.c | 2 +- exec.c | 4 ++-- linux-user/main.c | 2 +- vl.c | 18 +++++++++--------- 5 files changed, 16 insertions(+), 16 deletions(-)include/qom/cpu.h +3
-3@@ -689,15 +689,15 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model);CPUState *cpu_create (const char *typename);/** -* parse_cpu_model: -* @cpu_model: The model string including optional parameters. +* parse_cpu_option: +* @cpu_option: The -cpu option including optional parameters. * * processes optional parameters and registers them as global properties * * Returns: type of CPU to create or prints error and terminates process * if an error occurred. */ -const char *parse_cpu_model (const char *cpu_model); +const char *parse_cpu_option (const char *cpu_option);/** * cpu_has_work: bsd-user/main.c +1
-1@@ -903,7 +903,7 @@ int main(int argc, char **argv)/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 ); - cpu_type =parse_cpu_model (cpu_model); + cpu_type =parse_cpu_option (cpu_model); cpu =cpu_create (cpu_type); env = cpu->env_ptr;#if defined(TARGET_SPARC ) || defined(TARGET_PPC )exec.c +2
-2@@ -982,14 +982,14 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp)#endif } -const char *parse_cpu_model (const char *cpu_model) +const char *parse_cpu_option (const char *cpu_option) {ObjectClass *oc;CPUClass *cc;gchar **model_pieces;const char *cpu_type; - model_pieces =g_strsplit (cpu_model,"," ,2 ); + model_pieces =g_strsplit (cpu_option,"," ,2 ); oc =cpu_class_by_name (CPU_RESOLVING_TYPE , model_pieces[0 ]);if (oc ==NULL ) {linux-user/main.c +1
-1@@ -660,7 +660,7 @@ int main(int argc, char **argv, char **envp)if (cpu_model ==NULL ) { cpu_model =cpu_get_model (get_elf_eflags (execfd)); } - cpu_type =parse_cpu_model (cpu_model); + cpu_type =parse_cpu_option (cpu_model);/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 );vl.c +9
-9@@ -3002,7 +3002,7 @@ int main(int argc, char **argv, char **envp)const char *optarg;const char *loadvm =NULL ;MachineClass *machine_class; -const char *cpu_model; +const char *cpu_option;const char *vga_model =NULL ;const char *qtest_chrdev =NULL ;const char *qtest_log =NULL ;@@ -3081,7 +3081,7 @@ int main(int argc, char **argv, char **envp)QLIST_INIT (&vm_change_state_head);os_setup_early_signal_handling (); - cpu_model =NULL ; + cpu_option =NULL ; snapshot =0 ; nb_nics =0 ;@@ -3133,7 +3133,7 @@ int main(int argc, char **argv, char **envp)switch (popt->index) {case QEMU_OPTION_cpu:/* hw initialization will check this */ - cpu_model = optarg; + cpu_option = optarg;break ;case QEMU_OPTION_hda:case QEMU_OPTION_hdb:@@ -4050,8 +4050,8 @@ int main(int argc, char **argv, char **envp)qemu_set_hw_version (machine_class->hw_version); } -if (cpu_model &&is_help_option (cpu_model)) { -list_cpus (stdout, &fprintf, cpu_model); +if (cpu_option &&is_help_option (cpu_option)) { +list_cpus (stdout, &fprintf, cpu_option);exit (0 ); }@@ -4299,9 +4299,9 @@ int main(int argc, char **argv, char **envp)* Global properties get set up by qdev_prop_register_global(), * called from user_register_global_props(), and certain option * desugaring. Also in CPU feature desugaring (buried in -* parse_cpu_model()), which happens below this point, but may +* parse_cpu_option()), which happens below this point, but may * only target the CPU type, which can only be created after -* parse_cpu_model() returned the type. +* parse_cpu_option() returned the type. * * Machine compat properties: object_set_machine_compat_props(). * Accelerator compat props: object_set_accelerator_compat_props(), @@ -4465,8 +4465,8 @@ int main(int argc, char **argv, char **envp)/* parse features once if machine provides default cpu_type */ current_machine->cpu_type = machine_class->default_cpu_type; -if (cpu_model) { - current_machine->cpu_type =parse_cpu_model (cpu_model); +if (cpu_option) { + current_machine->cpu_type =parse_cpu_option (cpu_option); }parse_numa_opts (current_machine);
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH 1/5] cpu: Rename parse_cpu_model() to parse_cpu_option()
In reply to Eduardo HabkostQuoted 5 lines · On Tue, 16 Apr 2019 23:59:40 -0300 Eduardo Habkost <[email protected]> wrote:
The "model[,option...]" string parsed by the function is not just a CPU model. Rename the function and its argument to indicate it expects the full "-cpu" option to be provided.
Signed-off-by Eduardo Habkost <[email protected]>
Quoted 143 lines
--- include/qom/cpu.h | 6 +++--- bsd-user/main.c | 2 +- exec.c | 4 ++-- linux-user/main.c | 2 +- vl.c | 18 +++++++++--------- 5 files changed, 16 insertions(+), 16 deletions(-)include/qom/cpu.h +3
-3@@ -689,15 +689,15 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model);CPUState *cpu_create (const char *typename);/** -* parse_cpu_model: -* @cpu_model: The model string including optional parameters. +* parse_cpu_option: +* @cpu_option: The -cpu option including optional parameters. * * processes optional parameters and registers them as global properties * * Returns: type of CPU to create or prints error and terminates process * if an error occurred. */ -const char *parse_cpu_model (const char *cpu_model); +const char *parse_cpu_option (const char *cpu_option);/** * cpu_has_work: bsd-user/main.c +1
-1@@ -903,7 +903,7 @@ int main(int argc, char **argv)/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 ); - cpu_type =parse_cpu_model (cpu_model); + cpu_type =parse_cpu_option (cpu_model); cpu =cpu_create (cpu_type); env = cpu->env_ptr;#if defined(TARGET_SPARC ) || defined(TARGET_PPC )exec.c +2
-2@@ -982,14 +982,14 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp)#endif } -const char *parse_cpu_model (const char *cpu_model) +const char *parse_cpu_option (const char *cpu_option) {ObjectClass *oc;CPUClass *cc;gchar **model_pieces;const char *cpu_type; - model_pieces =g_strsplit (cpu_model,"," ,2 ); + model_pieces =g_strsplit (cpu_option,"," ,2 ); oc =cpu_class_by_name (CPU_RESOLVING_TYPE , model_pieces[0 ]);if (oc ==NULL ) {linux-user/main.c +1
-1@@ -660,7 +660,7 @@ int main(int argc, char **argv, char **envp)if (cpu_model ==NULL ) { cpu_model =cpu_get_model (get_elf_eflags (execfd)); } - cpu_type =parse_cpu_model (cpu_model); + cpu_type =parse_cpu_option (cpu_model);/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 );vl.c +9
-9@@ -3002,7 +3002,7 @@ int main(int argc, char **argv, char **envp)const char *optarg;const char *loadvm =NULL ;MachineClass *machine_class; -const char *cpu_model; +const char *cpu_option;const char *vga_model =NULL ;const char *qtest_chrdev =NULL ;const char *qtest_log =NULL ;@@ -3081,7 +3081,7 @@ int main(int argc, char **argv, char **envp)QLIST_INIT (&vm_change_state_head);os_setup_early_signal_handling (); - cpu_model =NULL ; + cpu_option =NULL ; snapshot =0 ; nb_nics =0 ;@@ -3133,7 +3133,7 @@ int main(int argc, char **argv, char **envp)switch (popt->index) {case QEMU_OPTION_cpu:/* hw initialization will check this */ - cpu_model = optarg; + cpu_option = optarg;break ;case QEMU_OPTION_hda:case QEMU_OPTION_hdb:@@ -4050,8 +4050,8 @@ int main(int argc, char **argv, char **envp)qemu_set_hw_version (machine_class->hw_version); } -if (cpu_model &&is_help_option (cpu_model)) { -list_cpus (stdout, &fprintf, cpu_model); +if (cpu_option &&is_help_option (cpu_option)) { +list_cpus (stdout, &fprintf, cpu_option);exit (0 ); }@@ -4299,9 +4299,9 @@ int main(int argc, char **argv, char **envp)* Global properties get set up by qdev_prop_register_global(), * called from user_register_global_props(), and certain option * desugaring. Also in CPU feature desugaring (buried in -* parse_cpu_model()), which happens below this point, but may +* parse_cpu_option()), which happens below this point, but may * only target the CPU type, which can only be created after -* parse_cpu_model() returned the type. +* parse_cpu_option() returned the type. * * Machine compat properties: object_set_machine_compat_props(). * Accelerator compat props: object_set_accelerator_compat_props(), @@ -4465,8 +4465,8 @@ int main(int argc, char **argv, char **envp)/* parse features once if machine provides default cpu_type */ current_machine->cpu_type = machine_class->default_cpu_type; -if (cpu_model) { - current_machine->cpu_type =parse_cpu_model (cpu_model); +if (cpu_option) { + current_machine->cpu_type =parse_cpu_option (cpu_option); }parse_numa_opts (current_machine);
PATCH 2/5 cpu: Extract CPU class lookup from parse_cpu_option()
In reply to Eduardo HabkostThe new function will be useful in user mode, when we already have a CPU model and don't need to parse any extra options.
--- include/qom/cpu.h | 9 +++++++++ exec.c | 22 ++++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-)
include/qom/cpu.h +9 -0
@@ -699,6 +699,15 @@ CPUState *cpu_create(const char *typename);*/ const char *parse_cpu_option (const char *cpu_option); +/** +* lookup_cpu_class: +* @cpu_model: CPU model name +* +* Look up CPU class corresponding to a given CPU model name. +*/ +CPUClass *lookup_cpu_class (const char *cpu_model,Error **errp); + +/** * cpu_has_work: * @cpu: The vCPU to check.
exec.c +12 -10
@@ -982,24 +982,26 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp)#endif } +CPUClass *lookup_cpu_class (const char *cpu_model,Error **errp) +{ +ObjectClass *oc =cpu_class_by_name (CPU_RESOLVING_TYPE , cpu_model); +if (oc ==NULL ) { +error_setg (errp,"unable to find CPU model '%s'" , cpu_model); +return NULL ; + } +return CPU_CLASS (oc); +} +const char *parse_cpu_option (const char *cpu_option) { -ObjectClass *oc;CPUClass *cc;gchar **model_pieces;const char *cpu_type; model_pieces =g_strsplit (cpu_option,"," ,2 ); - oc =cpu_class_by_name (CPU_RESOLVING_TYPE , model_pieces[0 ]); -if (oc ==NULL ) { -error_report ("unable to find CPU model '%s'" , model_pieces[0 ]); -g_strfreev (model_pieces); -exit (EXIT_FAILURE ); - } - - cpu_type =object_class_get_name (oc); - cc =CPU_CLASS (oc); + cc =lookup_cpu_class (model_pieces[0 ], &error_fatal); + cpu_type =object_class_get_name (OBJECT_CLASS (cc)); cc->parse_features (cpu_type, model_pieces[1 ], &error_fatal);g_strfreev (model_pieces);return cpu_type;
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
Re: [Qemu-devel] [PATCH 2/5] cpu: Extract CPU class lookup from parse_cpu_option()
Quoted 14 lines · Eduardo Habkost
The new function will be useful in user mode, when we already have a CPU model and don't need to parse any extra options.
Signed-off-by Eduardo Habkost <[email protected]>--- include/qom/cpu.h | 9 +++++++++ exec.c | 22 ++++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-)include/qom/cpu.h +0
-0
include/qom/cpu.h CPUState *cpu_create(const char *typename); · line 708
Quoted 10 lines
include/qom/cpu.h +7
-0@@ -699,6 +699,15 @@ CPUState *cpu_create(const char *typename);*/ const char *parse_cpu_option (const char *cpu_option); +/** +* lookup_cpu_class: +* @cpu_model: CPU model name +* +* Look up CPU class corresponding to a given CPU model name. +*/ +CPUClass *lookup_cpu_class (const char *cpu_model,Error **errp);
Nitpicks, feel free to ignore.
Naming: lookup_cpu_class() makes my reading circuits stall momentarily, because lookup is a noun. The verb is spelled look up. No stall:cpu_class_lookup(), look_up_cpu_class(), cpu_class_by_name_err(), cpu_class_parse(), ...
Doc string: this is a wrapper around cpu_class_by_name(). Perhaps that should be spelled out.
Apropos cpu_class_by_name(): it returns ObjectClass, not CPUClass. Isn't that odd?
Position: If you put it before cpu_create() rather than after, it's next to the function it wraps. But perhaps you prefer to keep it next to parse_cpu_option().
[...]
Re: [Qemu-devel] [PATCH 2/5] cpu: Extract CPU class lookup from parse_cpu_option()
Quoted 37 lines · Markus Armbruster
Quoted 14 lines · Eduardo Habkost
The new function will be useful in user mode, when we already have a CPU model and don't need to parse any extra options.
Signed-off-by Eduardo Habkost <[email protected]>--- include/qom/cpu.h | 9 +++++++++ exec.c | 22 ++++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-)include/qom/cpu.h +0
-0include/qom/cpu.h CPUState *cpu_create(const char *typename); · line 708
Quoted 10 lines
include/qom/cpu.h +7
-0@@ -699,6 +699,15 @@ CPUState *cpu_create(const char *typename);*/ const char *parse_cpu_option (const char *cpu_option); +/** +* lookup_cpu_class: +* @cpu_model: CPU model name +* +* Look up CPU class corresponding to a given CPU model name. +*/ +CPUClass *lookup_cpu_class (const char *cpu_model,Error **errp);Nitpicks, feel free to ignore.
Naming:
lookup_cpu_class()makes my reading circuits stall momentarily, because lookup is a noun. The verb is spelled look up. No stall:cpu_class_lookup(),look_up_cpu_class(),cpu_class_by_name_err(),cpu_class_parse(), ...Doc string: this is a wrapper around
cpu_class_by_name(). Perhaps that should be spelled out.
Quoted 6 lines
Apropos
cpu_class_by_name(): it returns ObjectClass, not CPUClass. Isn't that odd?Position: If you put it before
cpu_create()rather than after, it's next to the function it wraps. But perhaps you prefer to keep it next toparse_cpu_option().
Your suggestions make sense. I didn't notice how close lookup_cpu_class() was to the declaration of cpu_class_by_name(). I was seeing lookup_cpu_class() as "this portion of parse_cpu_option() I need", and not as "a wrapper to cpu_class_by_name()".
What about:
/**
* arch_cpu_class_by_name:
* @cpu_model: CPU model name
*
* Arch-specific wrapper around cpu_class_by_name(), uses CPU_RESOLVING_TYPE
* for the current architecture.
*/
CPUClass *arch_cpu_class_by_name(const char *cpu_model, Error **errp);
Signature · 1 line
Eduardo
Re: [Qemu-devel] [PATCH 2/5] cpu: Extract CPU class lookup from parse_cpu_option()
In reply to Eduardo HabkostQuoted 4 lines · Eduardo Habkost
The new function will be useful in user mode, when we already have a CPU model and don't need to parse any extra options.
Signed-off-by Eduardo Habkost <[email protected]>
Quoted 66 lines
--- include/qom/cpu.h | 9 +++++++++ exec.c | 22 ++++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-)include/qom/cpu.h +9
-0@@ -699,6 +699,15 @@ CPUState *cpu_create(const char *typename);*/ const char *parse_cpu_option (const char *cpu_option); +/** +* lookup_cpu_class: +* @cpu_model: CPU model name +* +* Look up CPU class corresponding to a given CPU model name. +*/ +CPUClass *lookup_cpu_class (const char *cpu_model,Error **errp); + +/** * cpu_has_work: * @cpu: The vCPU to check. exec.c +12
-10@@ -982,24 +982,26 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp)#endif } +CPUClass *lookup_cpu_class (const char *cpu_model,Error **errp) +{ +ObjectClass *oc =cpu_class_by_name (CPU_RESOLVING_TYPE , cpu_model); +if (oc ==NULL ) { +error_setg (errp,"unable to find CPU model '%s'" , cpu_model); +return NULL ; + } +return CPU_CLASS (oc); +} +const char *parse_cpu_option (const char *cpu_option) { -ObjectClass *oc;CPUClass *cc;gchar **model_pieces;const char *cpu_type; model_pieces =g_strsplit (cpu_option,"," ,2 ); - oc =cpu_class_by_name (CPU_RESOLVING_TYPE , model_pieces[0 ]); -if (oc ==NULL ) { -error_report ("unable to find CPU model '%s'" , model_pieces[0 ]); -g_strfreev (model_pieces); -exit (EXIT_FAILURE ); - } - - cpu_type =object_class_get_name (oc); - cc =CPU_CLASS (oc); + cc =lookup_cpu_class (model_pieces[0 ], &error_fatal); + cpu_type =object_class_get_name (OBJECT_CLASS (cc)); cc->parse_features (cpu_type, model_pieces[1 ], &error_fatal);g_strfreev (model_pieces);return cpu_type;
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH 3/5 linux-user: Use lookup_cpu_class()
In reply to Eduardo HabkostThe return value of cpu_get_model() is just a CPU model name and never includes extra options. We don't need to call parse_cpu_option().
--- linux-user/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
linux-user/main.c +3 -1
@@ -592,6 +592,7 @@ int main(int argc, char **argv, char **envp)TaskState *ts;CPUArchState *env;CPUState *cpu; +CPUClass *cc;int optind;char **target_environ, **wrk;char **target_argv;
@@ -660,7 +661,8 @@ int main(int argc, char **argv, char **envp)if (cpu_model ==NULL ) { cpu_model =cpu_get_model (get_elf_eflags (execfd)); } - cpu_type =parse_cpu_option (cpu_model); + cc =lookup_cpu_class (cpu_model, &error_fatal); + cpu_type =object_class_get_name (OBJECT_CLASS (cc));/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 );
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
Re: [Qemu-devel] [PATCH 3/5] linux-user: Use lookup_cpu_class()
Quoted 5 lines · Eduardo Habkost
The return value of
cpu_get_model()is just a CPU model name and never includes extra options. We don't need to callparse_cpu_option().Signed-off-by Eduardo Habkost <[email protected]>
Quoted 26 lines
--- linux-user/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)linux-user/main.c +3
-1@@ -592,6 +592,7 @@ int main(int argc, char **argv, char **envp)TaskState *ts;CPUArchState *env;CPUState *cpu; +CPUClass *cc;int optind;char **target_environ, **wrk;char **target_argv;@@ -660,7 +661,8 @@ int main(int argc, char **argv, char **envp)if (cpu_model ==NULL ) { cpu_model =cpu_get_model (get_elf_eflags (execfd)); } - cpu_type =parse_cpu_option (cpu_model); + cc =lookup_cpu_class (cpu_model, &error_fatal); + cpu_type =object_class_get_name (OBJECT_CLASS (cc));/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 );
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH 3/5] linux-user: Use lookup_cpu_class()
In reply to Eduardo HabkostQuoted 3 lines · Eduardo Habkost
The return value of
cpu_get_model()is just a CPU model name and never includes extra options. We don't need to callparse_cpu_option().
Oops. I was wrong. linux-user also supports extra features in the "-cpu" option, so we do need to call parse_cpu_option().
e.g.: this worked before:
$ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true
and now this is broken:
$ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true unable to find CPU model 'Nehalem,+popcnt'
I will drop patches 2-5 from my queue. Sorry for the noise.
Signature · 1 line
Eduardo
PATCH 4/5 bsd-user: Use lookup_cpu_class()
In reply to Eduardo HabkostThe hardcoded CPU models in the code are just CPU models and don't include any extra options. We don't need to call parse_cpu_options().
--- bsd-user/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
bsd-user/main.c +3 -1
@@ -732,6 +732,7 @@ int main(int argc, char **argv)TaskState ts1, *ts = &ts1;CPUArchState *env;CPUState *cpu; +CPUClass *cc;int optind;const char *r;int gdbstub_port =0 ;
@@ -903,7 +904,8 @@ int main(int argc, char **argv)/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 ); - cpu_type =parse_cpu_option (cpu_model); + cc =lookup_cpu_class (cpu_model, &error_fatal); + cpu_type =object_class_get_name (OBJECT_CLASS (cc)); cpu =cpu_create (cpu_type); env = cpu->env_ptr;#if defined(TARGET_SPARC ) || defined(TARGET_PPC )
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
Re: [Qemu-devel] [PATCH 4/5] bsd-user: Use lookup_cpu_class()
Quoted 5 lines · Eduardo Habkost
The hardcoded CPU models in the code are just CPU models and don't include any extra options. We don't need to call
parse_cpu_options().Signed-off-by Eduardo Habkost <[email protected]>
Quoted 26 lines
--- bsd-user/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)bsd-user/main.c +3
-1@@ -732,6 +732,7 @@ int main(int argc, char **argv)TaskState ts1, *ts = &ts1;CPUArchState *env;CPUState *cpu; +CPUClass *cc;int optind;const char *r;int gdbstub_port =0 ;@@ -903,7 +904,8 @@ int main(int argc, char **argv)/* init tcg before creating CPUs and to get qemu_host_page_size */ tcg_exec_init (0 ); - cpu_type =parse_cpu_option (cpu_model); + cc =lookup_cpu_class (cpu_model, &error_fatal); + cpu_type =object_class_get_name (OBJECT_CLASS (cc)); cpu =cpu_create (cpu_type); env = cpu->env_ptr;#if defined(TARGET_SPARC ) || defined(TARGET_PPC )
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH 5/5 cpu: Add MachineState parameter to parse_features()
In reply to Eduardo HabkostThe ppc implementation of parse_features() requires the machine object to be created before it gets called. This is far from obvious when reading the code at main().
Instead of making it call qdev_get_machine(), require the caller of parse_cpu_option() to provide the machine object.
This makes the initialization dependency explicit at main(), and will let us move qdev_get_machine() to CONFIG_SOFTMMU in the future.
--- include/qom/cpu.h | 5 +++-- target/ppc/cpu-qom.h | 3 ++- exec.c | 4 ++-- qom/cpu.c | 3 ++- target/i386/cpu.c | 3 ++- target/ppc/translate_init.inc.c | 7 ++++--- target/sparc/cpu.c | 3 ++- vl.c | 3 ++- 8 files changed, 19 insertions(+), 12 deletions(-)
include/qom/cpu.h +3 -2
@@ -164,7 +164,8 @@ typedef struct CPUClass {/*< public >*/ ObjectClass *(*class_by_name)(const char *cpu_model); -void (*parse_features)(const char *typename,char *str,Error **errp); +void (*parse_features)(MachineState *machine,const char *typename, +char *str,Error **errp);void (*reset)(CPUState *cpu);int reset_dump_flags;
@@ -697,7 +698,7 @@ CPUState *cpu_create(const char *typename);* Returns: type of CPU to create or prints error and terminates process * if an error occurred. */ -const char *parse_cpu_option (const char *cpu_option); +const char *parse_cpu_option (MachineState *machine,const char *cpu_option);/** * lookup_cpu_class:
target/ppc/cpu-qom.h +2 -1
@@ -167,7 +167,8 @@ typedef struct PowerPCCPUClass {DeviceRealize parent_realize;DeviceUnrealize parent_unrealize;void (*parent_reset)(CPUState *cpu); -void (*parent_parse_features)(const char *type,char *str,Error **errp); +void (*parent_parse_features)(MachineState *machine,const char *type, +char *str,Error **errp);uint32_t pvr;bool (*pvr_match)(struct PowerPCCPUClass *pcc,uint32_t pvr);
exec.c +2 -2
@@ -992,7 +992,7 @@ CPUClass *lookup_cpu_class(const char *cpu_model, Error **errp)return CPU_CLASS (oc); } -const char *parse_cpu_option (const char *cpu_option) +const char *parse_cpu_option (MachineState *machine,const char *cpu_option) {CPUClass *cc;gchar **model_pieces;
@@ -1002,7 +1002,7 @@ const char *parse_cpu_option(const char *cpu_option) cc =lookup_cpu_class (model_pieces[0 ], &error_fatal); cpu_type =object_class_get_name (OBJECT_CLASS (cc)); - cc->parse_features (cpu_type, model_pieces[1 ], &error_fatal); + cc->parse_features (machine, cpu_type, model_pieces[1 ], &error_fatal);g_strfreev (model_pieces);return cpu_type; }
qom/cpu.c +2 -1
@@ -291,7 +291,8 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model)return cc->class_by_name (cpu_model); } -static void cpu_common_parse_features (const char *typename,char *features, +static void cpu_common_parse_features (MachineState *machine, +const char *typename,char *features,Error **errp) {char *val;
target/i386/cpu.c +2 -1
@@ -3528,7 +3528,8 @@ static gint compare_string(gconstpointer a, gconstpointer b)/* Parse "+feature,-feature,feature=foo" CPU feature string */ -static void x86_cpu_parse_featurestr (const char *typename,char *features, +static void x86_cpu_parse_featurestr (MachineState *machine, +const char *typename,char *features,Error **errp) {char *featurestr;/* Single 'key=value" string being parsed */
target/ppc/translate_init.inc.c +4 -3
@@ -10119,10 +10119,11 @@ static ObjectClass *ppc_cpu_class_by_name(const char *name)return oc; } -static void ppc_cpu_parse_featurestr (const char *type,char *features, +static void ppc_cpu_parse_featurestr (MachineState *ms, +const char *type,char *features,Error **errp) { -Object *machine =qdev_get_machine (); +Object *machine =OBJECT (ms);const PowerPCCPUClass *pcc =POWERPC_CPU_CLASS (object_class_by_name (type));if (!features) {
@@ -10171,7 +10172,7 @@ static void ppc_cpu_parse_featurestr(const char *type, char *features, }/* do property processing with generic handler */ - pcc->parent_parse_features (type, features, errp); + pcc->parent_parse_features (ms, type, features, errp); }PowerPCCPUClass *ppc_cpu_get_family_class (PowerPCCPUClass *pcc)
target/sparc/cpu.c +2 -1
@@ -115,7 +115,8 @@ cpu_add_feat_as_prop(const char *typename, const char *name, const char *val) }/* Parse "+feature,-feature,feature=foo" CPU feature string */ -static void sparc_cpu_parse_features (const char *typename,char *features, +static void sparc_cpu_parse_features (MachineState *machine, +const char *typename,char *features,Error **errp) {GList *l, *plus_features =NULL , *minus_features =NULL ;
vl.c +2 -1
@@ -4466,7 +4466,8 @@ int main(int argc, char **argv, char **envp)/* parse features once if machine provides default cpu_type */ current_machine->cpu_type = machine_class->default_cpu_type;if (cpu_option) { - current_machine->cpu_type =parse_cpu_option (cpu_option); + current_machine->cpu_type = +parse_cpu_option (current_machine, cpu_option); }parse_numa_opts (current_machine);
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
Re: [Qemu-devel] [PATCH 5/5] cpu: Add MachineState parameter to parse_features()
Quoted 156 lines · Eduardo Habkost
The ppc implementation of
parse_features()requires the machine object to be created before it gets called. This is far from obvious when reading the code atmain().Instead of making it call
qdev_get_machine(), require the caller ofparse_cpu_option()to provide the machine object.This makes the initialization dependency explicit at
main(), and will let us moveqdev_get_machine()toCONFIG_SOFTMMUin the future.Signed-off-by Eduardo Habkost <[email protected]>--- include/qom/cpu.h | 5 +++-- target/ppc/cpu-qom.h | 3 ++- exec.c | 4 ++-- qom/cpu.c | 3 ++- target/i386/cpu.c | 3 ++- target/ppc/translate_init.inc.c | 7 ++++--- target/sparc/cpu.c | 3 ++- vl.c | 3 ++- 8 files changed, 19 insertions(+), 12 deletions(-)include/qom/cpu.h +3
-2@@ -164,7 +164,8 @@ typedef struct CPUClass {/*< public >*/ ObjectClass *(*class_by_name)(const char *cpu_model); -void (*parse_features)(const char *typename,char *str,Error **errp); +void (*parse_features)(MachineState *machine,const char *typename, +char *str,Error **errp);void (*reset)(CPUState *cpu);int reset_dump_flags;@@ -697,7 +698,7 @@ CPUState *cpu_create(const char *typename);* Returns: type of CPU to create or prints error and terminates process * if an error occurred. */ -const char *parse_cpu_option (const char *cpu_option); +const char *parse_cpu_option (MachineState *machine,const char *cpu_option);/** * lookup_cpu_class: target/ppc/cpu-qom.h +2
-1@@ -167,7 +167,8 @@ typedef struct PowerPCCPUClass {DeviceRealize parent_realize;DeviceUnrealize parent_unrealize;void (*parent_reset)(CPUState *cpu); -void (*parent_parse_features)(const char *type,char *str,Error **errp); +void (*parent_parse_features)(MachineState *machine,const char *type, +char *str,Error **errp);uint32_t pvr;bool (*pvr_match)(struct PowerPCCPUClass *pcc,uint32_t pvr);exec.c +2
-2@@ -992,7 +992,7 @@ CPUClass *lookup_cpu_class(const char *cpu_model, Error **errp)return CPU_CLASS (oc); } -const char *parse_cpu_option (const char *cpu_option) +const char *parse_cpu_option (MachineState *machine,const char *cpu_option) {CPUClass *cc;gchar **model_pieces;@@ -1002,7 +1002,7 @@ const char *parse_cpu_option(const char *cpu_option) cc =lookup_cpu_class (model_pieces[0 ], &error_fatal); cpu_type =object_class_get_name (OBJECT_CLASS (cc)); - cc->parse_features (cpu_type, model_pieces[1 ], &error_fatal); + cc->parse_features (machine, cpu_type, model_pieces[1 ], &error_fatal);g_strfreev (model_pieces);return cpu_type; }qom/cpu.c +2
-1@@ -291,7 +291,8 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model)return cc->class_by_name (cpu_model); } -static void cpu_common_parse_features (const char *typename,char *features, +static void cpu_common_parse_features (MachineState *machine, +const char *typename,char *features,Error **errp) {char *val;target/i386/cpu.c +2
-1@@ -3528,7 +3528,8 @@ static gint compare_string(gconstpointer a, gconstpointer b)/* Parse "+feature,-feature,feature=foo" CPU feature string */ -static void x86_cpu_parse_featurestr (const char *typename,char *features, +static void x86_cpu_parse_featurestr (MachineState *machine, +const char *typename,char *features,Error **errp) {char *featurestr;/* Single 'key=value" string being parsed */ target/ppc/translate_init.inc.c +4
-3@@ -10119,10 +10119,11 @@ static ObjectClass *ppc_cpu_class_by_name(const char *name)return oc; } -static void ppc_cpu_parse_featurestr (const char *type,char *features, +static void ppc_cpu_parse_featurestr (MachineState *ms, +const char *type,char *features,Error **errp) { -Object *machine =qdev_get_machine (); +Object *machine =OBJECT (ms);const PowerPCCPUClass *pcc =POWERPC_CPU_CLASS (object_class_by_name (type));if (!features) {@@ -10171,7 +10172,7 @@ static void ppc_cpu_parse_featurestr(const char *type, char *features, }/* do property processing with generic handler */ - pcc->parent_parse_features (type, features, errp); + pcc->parent_parse_features (ms, type, features, errp); }PowerPCCPUClass *ppc_cpu_get_family_class (PowerPCCPUClass *pcc)target/sparc/cpu.c +2
-1@@ -115,7 +115,8 @@ cpu_add_feat_as_prop(const char *typename, const char *name, const char *val) }/* Parse "+feature,-feature,feature=foo" CPU feature string */ -static void sparc_cpu_parse_features (const char *typename,char *features, +static void sparc_cpu_parse_features (MachineState *machine, +const char *typename,char *features,Error **errp) {GList *l, *plus_features =NULL , *minus_features =NULL ;vl.c +0
-0
vl.c int main(int argc, char **argv, char **envp) · line 4472
Quoted 8 lines
vl.c +2
-1@@ -4466,7 +4466,8 @@ int main(int argc, char **argv, char **envp)/* parse features once if machine provides default cpu_type */ current_machine->cpu_type = machine_class->default_cpu_type;if (cpu_option) { - current_machine->cpu_type =parse_cpu_option (cpu_option); + current_machine->cpu_type = +parse_cpu_option (current_machine, cpu_option); }parse_numa_opts (current_machine);
Well, it's not quite as bad as the commit message made me expect: since we assign to current_machine->cpu_type, we already have a dependence on machine creation.
Regardless, replacing qdev_get_machine() by explicit data flow is an improvement. More so if it really lets us confine qdev_get_machine() to CONFIG_SOFTMMU.
Re: [Qemu-devel] [PATCH 5/5] cpu: Add MachineState parameter to parse_features()
In reply to Eduardo HabkostQuoted 4 lines · Eduardo Habkost
The ppc implementation of
parse_features()requires the machine object to be created before it gets called. This is far from obvious when reading the code atmain().
Quoted 8 lines
Instead of making it call
qdev_get_machine(), require the caller ofparse_cpu_option()to provide the machine object.This makes the initialization dependency explicit at
main(), and will let us moveqdev_get_machine()toCONFIG_SOFTMMUin the future.Signed-off-by Eduardo Habkost <[email protected]>
and ppc parts
Quoted 153 lines
--- include/qom/cpu.h | 5 +++-- target/ppc/cpu-qom.h | 3 ++- exec.c | 4 ++-- qom/cpu.c | 3 ++- target/i386/cpu.c | 3 ++- target/ppc/translate_init.inc.c | 7 ++++--- target/sparc/cpu.c | 3 ++- vl.c | 3 ++- 8 files changed, 19 insertions(+), 12 deletions(-)include/qom/cpu.h +3
-2@@ -164,7 +164,8 @@ typedef struct CPUClass {/*< public >*/ ObjectClass *(*class_by_name)(const char *cpu_model); -void (*parse_features)(const char *typename,char *str,Error **errp); +void (*parse_features)(MachineState *machine,const char *typename, +char *str,Error **errp);void (*reset)(CPUState *cpu);int reset_dump_flags;@@ -697,7 +698,7 @@ CPUState *cpu_create(const char *typename);* Returns: type of CPU to create or prints error and terminates process * if an error occurred. */ -const char *parse_cpu_option (const char *cpu_option); +const char *parse_cpu_option (MachineState *machine,const char *cpu_option);/** * lookup_cpu_class: target/ppc/cpu-qom.h +2
-1@@ -167,7 +167,8 @@ typedef struct PowerPCCPUClass {DeviceRealize parent_realize;DeviceUnrealize parent_unrealize;void (*parent_reset)(CPUState *cpu); -void (*parent_parse_features)(const char *type,char *str,Error **errp); +void (*parent_parse_features)(MachineState *machine,const char *type, +char *str,Error **errp);uint32_t pvr;bool (*pvr_match)(struct PowerPCCPUClass *pcc,uint32_t pvr);exec.c +2
-2@@ -992,7 +992,7 @@ CPUClass *lookup_cpu_class(const char *cpu_model, Error **errp)return CPU_CLASS (oc); } -const char *parse_cpu_option (const char *cpu_option) +const char *parse_cpu_option (MachineState *machine,const char *cpu_option) {CPUClass *cc;gchar **model_pieces;@@ -1002,7 +1002,7 @@ const char *parse_cpu_option(const char *cpu_option) cc =lookup_cpu_class (model_pieces[0 ], &error_fatal); cpu_type =object_class_get_name (OBJECT_CLASS (cc)); - cc->parse_features (cpu_type, model_pieces[1 ], &error_fatal); + cc->parse_features (machine, cpu_type, model_pieces[1 ], &error_fatal);g_strfreev (model_pieces);return cpu_type; }qom/cpu.c +2
-1@@ -291,7 +291,8 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model)return cc->class_by_name (cpu_model); } -static void cpu_common_parse_features (const char *typename,char *features, +static void cpu_common_parse_features (MachineState *machine, +const char *typename,char *features,Error **errp) {char *val;target/i386/cpu.c +2
-1@@ -3528,7 +3528,8 @@ static gint compare_string(gconstpointer a, gconstpointer b)/* Parse "+feature,-feature,feature=foo" CPU feature string */ -static void x86_cpu_parse_featurestr (const char *typename,char *features, +static void x86_cpu_parse_featurestr (MachineState *machine, +const char *typename,char *features,Error **errp) {char *featurestr;/* Single 'key=value" string being parsed */ target/ppc/translate_init.inc.c +4
-3@@ -10119,10 +10119,11 @@ static ObjectClass *ppc_cpu_class_by_name(const char *name)return oc; } -static void ppc_cpu_parse_featurestr (const char *type,char *features, +static void ppc_cpu_parse_featurestr (MachineState *ms, +const char *type,char *features,Error **errp) { -Object *machine =qdev_get_machine (); +Object *machine =OBJECT (ms);const PowerPCCPUClass *pcc =POWERPC_CPU_CLASS (object_class_by_name (type));if (!features) {@@ -10171,7 +10172,7 @@ static void ppc_cpu_parse_featurestr(const char *type, char *features, }/* do property processing with generic handler */ - pcc->parent_parse_features (type, features, errp); + pcc->parent_parse_features (ms, type, features, errp); }PowerPCCPUClass *ppc_cpu_get_family_class (PowerPCCPUClass *pcc)target/sparc/cpu.c +2
-1@@ -115,7 +115,8 @@ cpu_add_feat_as_prop(const char *typename, const char *name, const char *val) }/* Parse "+feature,-feature,feature=foo" CPU feature string */ -static void sparc_cpu_parse_features (const char *typename,char *features, +static void sparc_cpu_parse_features (MachineState *machine, +const char *typename,char *features,Error **errp) {GList *l, *plus_features =NULL , *minus_features =NULL ;vl.c +2
-1@@ -4466,7 +4466,8 @@ int main(int argc, char **argv, char **envp)/* parse features once if machine provides default cpu_type */ current_machine->cpu_type = machine_class->default_cpu_type;if (cpu_option) { - current_machine->cpu_type =parse_cpu_option (cpu_option); + current_machine->cpu_type = +parse_cpu_option (current_machine, cpu_option); }parse_numa_opts (current_machine);
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Quoted 8 lines · Eduardo Habkost
My initial goal was simple: removing the
qdev_get_machine()call fromppc_cpu_parse_featurestr()because I want to makeqdev_get_machine()available only to softmmu code.Before doing this, I had to make *-user not call
CPUClass::parse_features()anymore (it was pointless to call it, anyway).
Quoted 5 lines
While doing this, I decided to rename
parse_cpu_model()to something clearer (parse_cpu_option()).As a nice side effect, now the dependency between machine object creation and
parse_cpu_option()is not hidden anymore.
Series
Quoted 10 lines · Markus Armbruster
Quoted 8 lines · Eduardo Habkost
My initial goal was simple: removing the
qdev_get_machine()call fromppc_cpu_parse_featurestr()because I want to makeqdev_get_machine()available only to softmmu code.Before doing this, I had to make *-user not call
CPUClass::parse_features()anymore (it was pointless to call it, anyway).
Quoted 8 lines
Quoted 5 lines
While doing this, I decided to rename
parse_cpu_model()to something clearer (parse_cpu_option()).As a nice side effect, now the dependency between machine object creation and
parse_cpu_option()is not hidden anymore.Series
Reviewed-by Markus Armbruster <[email protected]>
Thanks. I'm queueing this even though I agree with the comments at patch 2/5, because I'm already planning to send a separate cleanup series for cpu_class_by_name() and other related code.
Signature · 1 line
Eduardo