Skip to content

USB: serial: fix initial-termios handling

Johan Hovold linux-usb 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9USB: serial: fix initial-termios handlingdrivers/usb/serial/usb-serial.c+7 -40 replies
2/9USB: serial: ark3116: drop redundant init_termiosdrivers/usb/serial/ark3116.c+0 -110 replies
3/9USB: serial: cypress_m8: drop unused driver data flagdrivers/usb/serial/cypress_m8.c+0 -10 replies
4/9USB: serial: cypress_m8: drop unused termiosdrivers/usb/serial/cypress_m8.c+1 -110 replies
5/9USB: serial: cypress_m8: clean up initial-termios handlingdrivers/usb/serial/cypress_m8.c+7 -290 replies
6/9USB: serial: iuu_phoenix: drop bogus initial cflagdrivers/usb/serial/iuu_phoenix.c+1 -20 replies
7/9USB: serial: iuu_phoenix: simplify init_termiosdrivers/usb/serial/iuu_phoenix.c+1 -20 replies
8/9USB: serial: oti6858: simplify init_termiosdrivers/usb/serial/oti6858.c+1 -40 replies
9/9USB: serial: spcp8x5: simplify init_termiosdrivers/usb/serial/spcp8x5.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] USB: serial: fix initial-termios handling

A few drivers override the default initial termios settings provided by USB serial core, but due to a long-standing bug, the terminal settings were being reset on every (first) open rather than on first use after probe as intended.

This series fixes the bug and cleans up the various init_termios implementations somewhat.

Johan

Johan Hovold (9):
USB: serial: fix initial-termios handling
USB: serial: ark3116: drop redundant init_termios
USB: serial: cypress_m8: drop unused driver data flag
USB: serial: cypress_m8: drop unused termios
USB: serial: cypress_m8: clean up initial-termios handling
USB: serial: iuu_phoenix: drop bogus initial cflag
USB: serial: iuu_phoenix: simplify init_termios
USB: serial: oti6858: simplify init_termios
USB: serial: spcp8x5: simplify init_termios

 drivers/usb/serial/ark3116.c     | 11 -------
 drivers/usb/serial/cypress_m8.c  | 49 ++++++--------------------------
 drivers/usb/serial/iuu_phoenix.c |  4 +--
 drivers/usb/serial/oti6858.c     |  5 +---
 drivers/usb/serial/spcp8x5.c     |  5 +---
 drivers/usb/serial/usb-serial.c  | 11 ++++---
 6 files changed, 18 insertions(+), 67 deletions(-)
Signature · 1 line
2.21.0