Skip to contentSkip to conversation

USB: serial: fix initial-termios handling

PATCH In review Johan Hovold 1 participant 2 messages Apr 21, 2019 – Apr 26, 2019 USB

lore
Share & tools
lore
#0 lore raw

cover USB: serial: fix initial-termios handling

A few drivers override the default initial termios settings provided by USB serial core, but due to a long-standing bug, the terminal settings were being reset on every (first) open rather than on first use after probe as intended.

This series fixes the bug and cleans up the various init_termios implementations somewhat.

Johan

Johan Hovold (9):
USB: serial: fix initial-termios handling
USB: serial: ark3116: drop redundant init_termios
USB: serial: cypress_m8: drop unused driver data flag
USB: serial: cypress_m8: drop unused termios
USB: serial: cypress_m8: clean up initial-termios handling
USB: serial: iuu_phoenix: drop bogus initial cflag
USB: serial: iuu_phoenix: simplify init_termios
USB: serial: oti6858: simplify init_termios
USB: serial: spcp8x5: simplify init_termios

 drivers/usb/serial/ark3116.c     | 11 -------
 drivers/usb/serial/cypress_m8.c  | 49 ++++++--------------------------
 drivers/usb/serial/iuu_phoenix.c |  4 +--
 drivers/usb/serial/oti6858.c     |  5 +---
 drivers/usb/serial/spcp8x5.c     |  5 +---
 drivers/usb/serial/usb-serial.c  | 11 ++++---
 6 files changed, 18 insertions(+), 67 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw
Quoted 8 lines · Johan Hovold

A few drivers override the default initial termios settings provided by USB serial core, but due to a long-standing bug, the terminal settings were being reset on every (first) open rather than on first use after probe as intended.

This series fixes the bug and cleans up the various init_termios implementations somewhat.

Quoted 10 lines

Johan Hovold (9):
USB: serial: fix initial-termios handling
USB: serial: ark3116: drop redundant init_termios
USB: serial: cypress_m8: drop unused driver data flag
USB: serial: cypress_m8: drop unused termios
USB: serial: cypress_m8: clean up initial-termios handling
USB: serial: iuu_phoenix: drop bogus initial cflag
USB: serial: iuu_phoenix: simplify init_termios
USB: serial: oti6858: simplify init_termios
USB: serial: spcp8x5: simplify init_termios

I have applied these now.

Johan