Skip to content

genirq/timings: Fixes and selftests

Daniel Lezcano lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyIn review
  2. v29 patches 5 repliesSuperseded
  3. v19 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Removed patch using the min macro
- Fixed comment typos in patch 1/8

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8genirq/timings: Fix next event index functionkernel/irq/timings.c+42 -90 replies
2/8genirq/timings: Fix timings buffer inspectionkernel/irq/timings.c+18 -50 replies
3/8genirq/timings: Optimize the period detection speedkernel/irq/timings.c+1 -10 replies
4/8genirq/timings: Encapsulate timings pushkernel/irq/internals.h+12 -90 replies
5/8genirq/timings: Encapsulate storing functionkernel/irq/timings.c+34 -190 replies
6/8genirq/timings: Add selftest for circular arraykernel/irq/Makefile kernel/irq/timings.c lib/Kconfig.debug+130 -00 replies
7/8genirq/timings: Add selftest for irqs circular bufferkernel/irq/timings.c+139 -00 replies
8/8genirq/timings: Add selftest for next event computationkernel/irq/timings.c+66 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 0/8] genirq/timings: Fixes and selftests

This series provides a couple of fixes, an optimization and the code to do the selftests.

While writing the selftests, a couple of issues were spotted with the circular buffer handling and the routine searching for the pattern multiple times.

In addition, a small optimization has been found while investigating the bugs above.

In order to write the selftest, the routine needed by the core code and the tests are wrapped into function which are always inline so the current code is not impacted by a new function call. There is no functional changes in this part.

Finally, the selftest uses samples to insert values in the arrays and use them to predict the next event. These tests cover the most difficult part of the code.

Changelog:

V3:
- Removed patch using the min macro
- Fixed comment typos in patch 1/8
V2:
- Removed defaulting to 'n' as it is already the case

*** BLURB HERE ***

Daniel Lezcano (8):
genirq/timings: Fix next event index function genirq/timings: Fix timings buffer inspection genirq/timings: Optimize the period detection speed genirq/timings: Encapsulate timings push genirq/timings: Encapsulate storing function genirq/timings: Add selftest for circular array genirq/timings: Add selftest for irqs circular buffer genirq/timings: Add selftest for next event computation

 kernel/irq/Makefile    |   3 +
 kernel/irq/internals.h |  21 +-
 kernel/irq/timings.c   | 453 +++++++++++++++++++++++++++++++++++++----
 lib/Kconfig.debug      |   8 +
 4 files changed, 442 insertions(+), 43 deletions(-)
Signature · 1 line
2.17.1